From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yang Hongyang <yanghy@cn.fujitsu.com>
Subject: Re: [PATCH] libxl: events: Do not abort remus with
	ERROR_TIMEOUT
Date: Thu, 16 Jul 2015 10:44:59 +0800
Message-ID: <55A71AAB.7020308@cn.fujitsu.com>
References: <1436962410.32371.25.camel@citrix.com>
	<1436967356-24786-1-git-send-email-ian.jackson@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1436967356-24786-1-git-send-email-ian.jackson@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xensource.com
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org



On 07/15/2015 09:35 PM, Ian Jackson wrote:
> When the timeout set for prompting the next remus iteration fires, we
> should not treat the ERROR_TIMEDOUT as an error.
>
> Bug in 31c836f4 "libxl: events: Permit timeouts to signal ao abort".
>
> Reported-by: Yang Hongyang <yanghy@cn.fujitsu.com>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> CC: Yang Hongyang <yanghy@cn.fujitsu.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> CC: Ian Campbell <ian.campbell@citrix.com>

Acked-by: Yang Hongyang <yanghy@cn.fujitsu.com>

> ---
>   tools/libxl/libxl_dom.c |    3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
> index 81adb3d..4cb247a 100644
> --- a/tools/libxl/libxl_dom.c
> +++ b/tools/libxl/libxl_dom.c
> @@ -2024,6 +2024,9 @@ static void remus_next_checkpoint(libxl__egc *egc, libxl__ev_time *ev,
>
>       STATE_AO_GC(dss->ao);
>
> +    if (rc == ERROR_TIMEDOUT) /* As intended */
> +        rc = 0;
> +
>       /*
>        * Time to checkpoint the guest again. We return 1 to libxc
>        * (xc_domain_save.c). in order to continue executing the infinite loop
>

-- 
Thanks,
Yang.