From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yang Hongyang Subject: Re: [PATCH v4 --for 4.6 COLOPre 12/25] tools/libxl: introduce enum type libxl_checkpointed_stream Date: Thu, 16 Jul 2015 18:47:13 +0800 Message-ID: <55A78BB1.7060504@cn.fujitsu.com> References: <1436946351-21118-1-git-send-email-yanghy@cn.fujitsu.com> <1436946351-21118-13-git-send-email-yanghy@cn.fujitsu.com> <1436963642.32371.34.camel@citrix.com> <55A666F4.5020600@cn.fujitsu.com> <1437042882.32371.159.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1437042882.32371.159.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: wei.liu2@citrix.com, wency@cn.fujitsu.com, andrew.cooper3@citrix.com, yunhong.jiang@intel.com, eddie.dong@intel.com, xen-devel@lists.xen.org, guijianfeng@cn.fujitsu.com, rshriram@cs.ubc.ca, ian.jackson@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 07/16/2015 06:34 PM, Ian Campbell wrote: > On Wed, 2015-07-15 at 21:58 +0800, Yang Hongyang wrote: >> >> On 07/15/2015 08:34 PM, Ian Campbell wrote: >>> On Wed, 2015-07-15 at 15:45 +0800, Yang Hongyang wrote: >>>> introduce enum type libxl_checkpointed_stream in IDL. >>>> rename the last argument of migrate_receive from "remus" to >>>> "checkpointed" since the semantics of this parameter has >>>> changed. >>>> >>>> NOTE: >>>> libxl_domain_restore_params isn't changed here, >>>> checkpointed_stream is still an int. >>>> It has to change eventually and other callers will have to be >>>> updated to cope (and there should be LIBXL_HAVE_...). >>> >>> Will this be fixed up later in this series? If so please say so. >> >> It's not fixed in this series, I plan to fix this later, but seems there >> will be another round for this series, I can fix this in the next version. >> My main concern is that this change is an api change, it will affect the >> existing callers. > > It is already an API change, whether or not is reflected in the type of > checkpointed_stream in the API struct you've already changed the > semantics of that field and so a LIBLX_HAVE is already needed, it makes > no sense to not also change the type to be correct while you are making > these changes even if the interchangeability of ints and enums seems on > the face of it to make it possible to avoid doing so. Fair enough, will fix, thank you! > > Ian. > > . > -- Thanks, Yang.