From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhengxing Subject: Re: [PATCH 1/2] ASoC: rockchip: Add machine driver for max98090 codec Date: Thu, 16 Jul 2015 19:20:52 +0800 Message-ID: <55A79394.5090905@rock-chips.com> References: <1436930143-31361-1-git-send-email-zhengxing@rock-chips.com> <1436930143-31361-2-git-send-email-zhengxing@rock-chips.com> <1437033944.27428.11.camel@tiscali.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from regular1.263xmail.com (regular1.263xmail.com [211.150.99.131]) by alsa0.perex.cz (Postfix) with ESMTP id E1DCE260561 for ; Thu, 16 Jul 2015 13:27:01 +0200 (CEST) In-Reply-To: <1437033944.27428.11.camel@tiscali.nl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Paul Bolle Cc: alsa-devel@alsa-project.org, heiko@sntech.de, Takashi Iwai , linux-kernel@vger.kernel.org, Liam Girdwood , dianders@chromium.org, linux-rockchip@lists.infradead.org, Mark Brown , dgreid@chromium.org, sonnyrao@chromium.org, linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org SGkgUGF1bCwKICAgICBUaGFuayB5b3UgZm9yIHlvdXIgcmVwbHkuCgpPbiAyMDE15bm0MDfmnIgx NuaXpSAxNjowNSwgUGF1bCBCb2xsZSB3cm90ZToKPiBPbiB3bywgMjAxNS0wNy0xNSBhdCAxMTox NSArMDgwMCwgWGluZyBaaGVuZyB3cm90ZToKPj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3Qgb2ZfZGV2 aWNlX2lkIHJvY2tjaGlwX21heDk4MDkwX29mX21hdGNoW10gPSB7Cj4+ICsJeyAuY29tcGF0aWJs ZSA9ICJyb2NrY2hpcCxyb2NrY2hpcC1hdWRpby1tYXg5ODA5MCIsIH0sCj4+ICsJe30sCj4+ICt9 Owo+PiArCj4+ICtzdGF0aWMgc3RydWN0IHBsYXRmb3JtX2RyaXZlciBzbmRfcmtfbWNfZHJpdmVy ID0gewo+PiArCS5wcm9iZSA9IHNuZF9ya19tY19wcm9iZSwKPj4gKwkucmVtb3ZlID0gc25kX3Jr X21jX3JlbW92ZSwKPj4gKwkuZHJpdmVyID0gewo+PiArCQkubmFtZSA9IERSVl9OQU1FLAo+PiAr CQkub3duZXIgPSBUSElTX01PRFVMRSwKPj4gKwkJLnBtID0mc25kX3NvY19wbV9vcHMsCj4+ICsJ CS5vZl9tYXRjaF90YWJsZSA9IHJvY2tjaGlwX21heDk4MDkwX29mX21hdGNoLAo+PiArCX0sCj4+ ICt9Owo+PiArCj4+ICttb2R1bGVfcGxhdGZvcm1fZHJpdmVyKHNuZF9ya19tY19kcml2ZXIpOwo+ IE5pdDogZW1wdHkgbGluZSBoZXJlLgpEb25lLgo+Cj4+ICtNT0RVTEVfQVVUSE9SKCJqaWFucXVu PGpheS54dUByb2NrLWNoaXBzLmNvbT4iKTsKPj4gK01PRFVMRV9ERVNDUklQVElPTigiUm9ja2No aXAgbWF4OTgwOTAgbWFjaGluZSBBU29DIGRyaXZlciIpOwo+PiArTU9EVUxFX0xJQ0VOU0UoIkdQ TCB2MiIpOwo+PiArTU9EVUxFX0FMSUFTKCJwbGF0Zm9ybToiIERSVl9OQU1FKTsKPiBUaGlzIHNl ZW1zIG9ubHkgdXNlZnVsIGlmIHRoZXJlJ3MgYSBjb3JyZXNwb25kaW5nIHN0cnVjdAo+IHBsYXRm b3JtX2RldmljZS4gSWUsIGEgcGxhdGZvcm1fZGV2aWNlIHdpdGggYSAicm9ja2NoaXAtc25kLW1h eDk4MDkwIgo+IC5uYW1lLCB3aGljaCB3aWxsIHRyaWdnZXIgYSAiTU9EQUxJQVM9cGxhdGZvcm06 cm9ja2NoaXAtc25kLW1heDk4MDkwIgo+IHVldmVudCB3aGVuIGl0J3MgY3JlYXRlZC4gQnV0IEkg Y291bGRuJ3QgZmluZCB3aGVyZSBzdWNoIGEKPiBwbGF0Zm9ybV9kZXZpY2UgaXMgY3JlYXRlZC4K Pgo+IERpZCBJIG1pc3Mgc29tZXRoaW5nPyBPciBpcyB0aGVyZSBhbm90aGVyIHdheSB0aGlzIGFs aWFzIGlzIHVzZWZ1bCBoZXJlPwpZZXMsIEkgZGlkbid0IGNhcmUgYWJvdXQgdGhpcyBidXQgSSB0 aGluayBpdCBtYXliZSBjb3JyZWN0Lgo+PiArTU9EVUxFX0RFVklDRV9UQUJMRShvZiwgcm9ja2No aXBfbWF4OTgwOTBfb2ZfbWF0Y2gpOwo+IFRoZSBjb21tb24gcGF0dGVybiBpcyB0byBwdXQgTU9E VUxFX0RFVklDRV9UQUJMRSgpIGRpcmVjdGx5IGFmdGVyIHRoZQo+IHRhYmxlIGl0IGV4cG9ydHMu CkRvbmUuCj4gTGlrZXdpc2UgZm9yIDIvMiAoZXhjZXB0IHRoZSBlbXB0eSBsaW5lIG5pdCwgdGhh dCBpcykuCk9LLCBkb25lLgoKPiBUaGFua3MsCj4KPgo+IFBhdWwgQm9sbGUKPgo+Cj4KCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpBbHNhLWRldmVsIG1h aWxpbmcgbGlzdApBbHNhLWRldmVsQGFsc2EtcHJvamVjdC5vcmcKaHR0cDovL21haWxtYW4uYWxz YS1wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Fsc2EtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhengxing@rock-chips.com (zhengxing) Date: Thu, 16 Jul 2015 19:20:52 +0800 Subject: [PATCH 1/2] ASoC: rockchip: Add machine driver for max98090 codec In-Reply-To: <1437033944.27428.11.camel@tiscali.nl> References: <1436930143-31361-1-git-send-email-zhengxing@rock-chips.com> <1436930143-31361-2-git-send-email-zhengxing@rock-chips.com> <1437033944.27428.11.camel@tiscali.nl> Message-ID: <55A79394.5090905@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Paul, Thank you for your reply. On 2015?07?16? 16:05, Paul Bolle wrote: > On wo, 2015-07-15 at 11:15 +0800, Xing Zheng wrote: >> +static const struct of_device_id rockchip_max98090_of_match[] = { >> + { .compatible = "rockchip,rockchip-audio-max98090", }, >> + {}, >> +}; >> + >> +static struct platform_driver snd_rk_mc_driver = { >> + .probe = snd_rk_mc_probe, >> + .remove = snd_rk_mc_remove, >> + .driver = { >> + .name = DRV_NAME, >> + .owner = THIS_MODULE, >> + .pm =&snd_soc_pm_ops, >> + .of_match_table = rockchip_max98090_of_match, >> + }, >> +}; >> + >> +module_platform_driver(snd_rk_mc_driver); > Nit: empty line here. Done. > >> +MODULE_AUTHOR("jianqun"); >> +MODULE_DESCRIPTION("Rockchip max98090 machine ASoC driver"); >> +MODULE_LICENSE("GPL v2"); >> +MODULE_ALIAS("platform:" DRV_NAME); > This seems only useful if there's a corresponding struct > platform_device. Ie, a platform_device with a "rockchip-snd-max98090" > .name, which will trigger a "MODALIAS=platform:rockchip-snd-max98090" > uevent when it's created. But I couldn't find where such a > platform_device is created. > > Did I miss something? Or is there another way this alias is useful here? Yes, I didn't care about this but I think it maybe correct. >> +MODULE_DEVICE_TABLE(of, rockchip_max98090_of_match); > The common pattern is to put MODULE_DEVICE_TABLE() directly after the > table it exports. Done. > Likewise for 2/2 (except the empty line nit, that is). OK, done. > Thanks, > > > Paul Bolle > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755094AbbGPL1a (ORCPT ); Thu, 16 Jul 2015 07:27:30 -0400 Received: from regular1.263xmail.com ([211.150.99.131]:35078 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754965AbbGPL12 (ORCPT ); Thu, 16 Jul 2015 07:27:28 -0400 X-Greylist: delayed 115506 seconds by postgrey-1.27 at vger.kernel.org; Thu, 16 Jul 2015 07:27:26 EDT X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: zhengxing@rock-chips.com X-FST-TO: pebolle@tiscali.nl X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: zhengxing@rock-chips.com X-UNIQUE-TAG: <8f470835237ebdb8da4faf9553212c88> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <55A79394.5090905@rock-chips.com> Date: Thu, 16 Jul 2015 19:20:52 +0800 From: zhengxing User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120410 Thunderbird/11.0.1 MIME-Version: 1.0 To: Paul Bolle CC: dgreid@chromium.org, dianders@chromium.org, heiko@sntech.de, sonnyrao@chromium.org, linux-rockchip@lists.infradead.org, Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] ASoC: rockchip: Add machine driver for max98090 codec References: <1436930143-31361-1-git-send-email-zhengxing@rock-chips.com> <1436930143-31361-2-git-send-email-zhengxing@rock-chips.com> <1437033944.27428.11.camel@tiscali.nl> In-Reply-To: <1437033944.27428.11.camel@tiscali.nl> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, Thank you for your reply. On 2015年07月16日 16:05, Paul Bolle wrote: > On wo, 2015-07-15 at 11:15 +0800, Xing Zheng wrote: >> +static const struct of_device_id rockchip_max98090_of_match[] = { >> + { .compatible = "rockchip,rockchip-audio-max98090", }, >> + {}, >> +}; >> + >> +static struct platform_driver snd_rk_mc_driver = { >> + .probe = snd_rk_mc_probe, >> + .remove = snd_rk_mc_remove, >> + .driver = { >> + .name = DRV_NAME, >> + .owner = THIS_MODULE, >> + .pm =&snd_soc_pm_ops, >> + .of_match_table = rockchip_max98090_of_match, >> + }, >> +}; >> + >> +module_platform_driver(snd_rk_mc_driver); > Nit: empty line here. Done. > >> +MODULE_AUTHOR("jianqun"); >> +MODULE_DESCRIPTION("Rockchip max98090 machine ASoC driver"); >> +MODULE_LICENSE("GPL v2"); >> +MODULE_ALIAS("platform:" DRV_NAME); > This seems only useful if there's a corresponding struct > platform_device. Ie, a platform_device with a "rockchip-snd-max98090" > .name, which will trigger a "MODALIAS=platform:rockchip-snd-max98090" > uevent when it's created. But I couldn't find where such a > platform_device is created. > > Did I miss something? Or is there another way this alias is useful here? Yes, I didn't care about this but I think it maybe correct. >> +MODULE_DEVICE_TABLE(of, rockchip_max98090_of_match); > The common pattern is to put MODULE_DEVICE_TABLE() directly after the > table it exports. Done. > Likewise for 2/2 (except the empty line nit, that is). OK, done. > Thanks, > > > Paul Bolle > > >