From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhengxing Subject: Re: [PATCH 1/2] ASoC: rockchip: Add machine driver for max98090 codec Date: Thu, 16 Jul 2015 19:22:17 +0800 Message-ID: <55A793E9.3050707@rock-chips.com> References: <1436930143-31361-1-git-send-email-zhengxing@rock-chips.com> <1436930143-31361-2-git-send-email-zhengxing@rock-chips.com> <1437033944.27428.11.camel@tiscali.nl> <20150716110032.GU11162@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from regular1.263xmail.com (regular1.263xmail.com [211.150.99.130]) by alsa0.perex.cz (Postfix) with ESMTP id 2C030260561 for ; Thu, 16 Jul 2015 13:28:24 +0200 (CEST) In-Reply-To: <20150716110032.GU11162@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: Paul Bolle , heiko@sntech.de, alsa-devel@alsa-project.org, Takashi Iwai , linux-kernel@vger.kernel.org, dianders@chromium.org, Liam Girdwood , linux-rockchip@lists.infradead.org, dgreid@chromium.org, sonnyrao@chromium.org, linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org T24gMjAxNeW5tDA35pyIMTbml6UgMTk6MDAsIE1hcmsgQnJvd24gd3JvdGU6Cj4gT24gVGh1LCBK dWwgMTYsIDIwMTUgYXQgMTA6MDU6NDRBTSArMDIwMCwgUGF1bCBCb2xsZSB3cm90ZToKPgo+Pj4g K3N0YXRpYyBzdHJ1Y3QgcGxhdGZvcm1fZHJpdmVyIHNuZF9ya19tY19kcml2ZXIgPSB7Cj4+PiAr CS5wcm9iZSA9IHNuZF9ya19tY19wcm9iZSwKPj4+ICsJLnJlbW92ZSA9IHNuZF9ya19tY19yZW1v dmUsCj4+PiArCS5kcml2ZXIgPSB7Cj4+PiArCQkubmFtZSA9IERSVl9OQU1FLAo+Pj4gK01PRFVM RV9BTElBUygicGxhdGZvcm06IiBEUlZfTkFNRSk7Cj4+IFRoaXMgc2VlbXMgb25seSB1c2VmdWwg aWYgdGhlcmUncyBhIGNvcnJlc3BvbmRpbmcgc3RydWN0Cj4+IHBsYXRmb3JtX2RldmljZS4gSWUs IGEgcGxhdGZvcm1fZGV2aWNlIHdpdGggYSAicm9ja2NoaXAtc25kLW1heDk4MDkwIgo+PiAubmFt ZSwgd2hpY2ggd2lsbCB0cmlnZ2VyIGEgIk1PREFMSUFTPXBsYXRmb3JtOnJvY2tjaGlwLXNuZC1t YXg5ODA5MCIKPj4gdWV2ZW50IHdoZW4gaXQncyBjcmVhdGVkLiBCdXQgSSBjb3VsZG4ndCBmaW5k IHdoZXJlIHN1Y2ggYQo+PiBwbGF0Zm9ybV9kZXZpY2UgaXMgY3JlYXRlZC4KPj4gRGlkIEkgbWlz cyBzb21ldGhpbmc/IE9yIGlzIHRoZXJlIGFub3RoZXIgd2F5IHRoaXMgYWxpYXMgaXMgdXNlZnVs IGhlcmU/Cj4gWW91J3ZlIGdvdCBwbGF0Zm9ybV9kZXZpY2UgYW5kIHBsYXRmb3JtX2RyaXZlciBj b25mdXNlZCBJIHRoaW5rLgpNYXJrLCBUaGFuayB5b3UuCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpBbHNhLWRldmVsIG1haWxpbmcgbGlzdApBbHNhLWRl dmVsQGFsc2EtcHJvamVjdC5vcmcKaHR0cDovL21haWxtYW4uYWxzYS1wcm9qZWN0Lm9yZy9tYWls bWFuL2xpc3RpbmZvL2Fsc2EtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhengxing@rock-chips.com (zhengxing) Date: Thu, 16 Jul 2015 19:22:17 +0800 Subject: [PATCH 1/2] ASoC: rockchip: Add machine driver for max98090 codec In-Reply-To: <20150716110032.GU11162@sirena.org.uk> References: <1436930143-31361-1-git-send-email-zhengxing@rock-chips.com> <1436930143-31361-2-git-send-email-zhengxing@rock-chips.com> <1437033944.27428.11.camel@tiscali.nl> <20150716110032.GU11162@sirena.org.uk> Message-ID: <55A793E9.3050707@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015?07?16? 19:00, Mark Brown wrote: > On Thu, Jul 16, 2015 at 10:05:44AM +0200, Paul Bolle wrote: > >>> +static struct platform_driver snd_rk_mc_driver = { >>> + .probe = snd_rk_mc_probe, >>> + .remove = snd_rk_mc_remove, >>> + .driver = { >>> + .name = DRV_NAME, >>> +MODULE_ALIAS("platform:" DRV_NAME); >> This seems only useful if there's a corresponding struct >> platform_device. Ie, a platform_device with a "rockchip-snd-max98090" >> .name, which will trigger a "MODALIAS=platform:rockchip-snd-max98090" >> uevent when it's created. But I couldn't find where such a >> platform_device is created. >> Did I miss something? Or is there another way this alias is useful here? > You've got platform_device and platform_driver confused I think. Mark, Thank you. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755578AbbGPLc2 (ORCPT ); Thu, 16 Jul 2015 07:32:28 -0400 Received: from regular1.263xmail.com ([211.150.99.130]:35469 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755208AbbGPL2d (ORCPT ); Thu, 16 Jul 2015 07:28:33 -0400 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: zhengxing@rock-chips.com X-FST-TO: broonie@kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: zhengxing@rock-chips.com X-UNIQUE-TAG: <6491034d4dc0078546b4d9be7f57438f> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <55A793E9.3050707@rock-chips.com> Date: Thu, 16 Jul 2015 19:22:17 +0800 From: zhengxing User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120410 Thunderbird/11.0.1 MIME-Version: 1.0 To: Mark Brown CC: Paul Bolle , dgreid@chromium.org, dianders@chromium.org, heiko@sntech.de, sonnyrao@chromium.org, linux-rockchip@lists.infradead.org, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] ASoC: rockchip: Add machine driver for max98090 codec References: <1436930143-31361-1-git-send-email-zhengxing@rock-chips.com> <1436930143-31361-2-git-send-email-zhengxing@rock-chips.com> <1437033944.27428.11.camel@tiscali.nl> <20150716110032.GU11162@sirena.org.uk> In-Reply-To: <20150716110032.GU11162@sirena.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015年07月16日 19:00, Mark Brown wrote: > On Thu, Jul 16, 2015 at 10:05:44AM +0200, Paul Bolle wrote: > >>> +static struct platform_driver snd_rk_mc_driver = { >>> + .probe = snd_rk_mc_probe, >>> + .remove = snd_rk_mc_remove, >>> + .driver = { >>> + .name = DRV_NAME, >>> +MODULE_ALIAS("platform:" DRV_NAME); >> This seems only useful if there's a corresponding struct >> platform_device. Ie, a platform_device with a "rockchip-snd-max98090" >> .name, which will trigger a "MODALIAS=platform:rockchip-snd-max98090" >> uevent when it's created. But I couldn't find where such a >> platform_device is created. >> Did I miss something? Or is there another way this alias is useful here? > You've got platform_device and platform_driver confused I think. Mark, Thank you.