From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v8 08/11] xen: arch-specific hooks for domain_soft_reset() Date: Thu, 16 Jul 2015 13:57:18 +0200 Message-ID: <55A79C1E.4090709@citrix.com> References: <1435075913-335-1-git-send-email-vkuznets@redhat.com> <1435075913-335-9-git-send-email-vkuznets@redhat.com> <55A6C054.1040903@citrix.com> <87io9kwczx.fsf@vitty.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZFhn2-0006pO-Rv for xen-devel@lists.xenproject.org; Thu, 16 Jul 2015 11:57:24 +0000 In-Reply-To: <87io9kwczx.fsf@vitty.brq.redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Vitaly Kuznetsov Cc: Andrew Jones , Keir Fraser , Ian Campbell , Stefano Stabellini , Andrew Cooper , Julien Grall , Ian Jackson , Olaf Hering , Tim Deegan , David Vrabel , Jan Beulich , xen-devel@lists.xenproject.org, Wei Liu , Daniel De Graaf List-Id: xen-devel@lists.xenproject.org Hi Vitaly, On 16/07/2015 13:36, Vitaly Kuznetsov wrote: > Julien Grall writes: >> On 23/06/2015 18:11, Vitaly Kuznetsov wrote: >>> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c >>> index 24b8938..c112afa 100644 >>> --- a/xen/arch/arm/domain.c >>> +++ b/xen/arch/arm/domain.c >>> @@ -653,6 +653,11 @@ void arch_domain_unpause(struct domain *d) >>> { >>> } >>> >>> +int arch_domain_soft_reset(struct domain *d) >>> +{ >>> + return 0; >> >> I suspect that it would needs some code in this function in order to >> support soft reset on ARM. If so, should not you return -ENOSYS until >> someone take care of the ARM support? >> > > I was hoping kexec for ARM will magically work without any arch-specific > bits here :-) I don't know how work kexec for Xen, but I think we will have at least to do the same as x86 for the shared info page. > Sure, let's make it -ENOSYS. Thank you! -- Julien Grall