From: Julien Grall <julien.grall@citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>,
stefano.stabellini@eu.citrix.com, xen-devel@lists.xen.org
Cc: "Chris (Christopher) Brand" <chris.brand@broadcom.com>
Subject: Re: [PATCH] xen: arm: bootfdt: Avoid reading off the front of *_cells array
Date: Thu, 16 Jul 2015 14:06:06 +0200 [thread overview]
Message-ID: <55A79E2E.3090201@citrix.com> (raw)
In-Reply-To: <1437036607-1737-1-git-send-email-ian.campbell@citrix.com>
Hi Ian,
On 16/07/2015 10:50, Ian Campbell wrote:
> In device_tree_for_each_node the call to the callback was using
> {address,size}_cells[depth - 1], which at depth 0 could read off the
> front of the array.
>
> We already handled this correctly in the rest of the loop so fixup
> this instance as well.
>
> Reported-by: Chris (Christopher) Brand <chris.brand@broadcom.com>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> Cc: Chris (Christopher) Brand <chris.brand@broadcom.com>
Good catch! Do you plan to backport to Xen 4.5 and apply to Xen 4.6?
Reviewed-by: Julien Grall <julien.grall@citrix.com>
Regards,
--
Julien Grall
next prev parent reply other threads:[~2015-07-16 12:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-22 23:02 Bug in devicetree_for_each_node() in xen/arch/arm/bootfdt.c ? Chris (Christopher) Brand
2015-06-23 9:44 ` David Vrabel
2015-06-23 9:57 ` Ian Campbell
2015-06-23 10:08 ` Ian Campbell
2015-06-23 10:10 ` Ian Campbell
2015-06-23 10:01 ` Julien Grall
2015-06-23 10:08 ` Julien Grall
2015-06-23 10:27 ` Ian Campbell
2015-06-23 10:32 ` Julien Grall
2015-06-23 10:43 ` Ian Campbell
2015-06-24 18:57 ` Chris (Christopher) Brand
2015-07-15 23:35 ` Chris (Christopher) Brand
2015-07-16 8:50 ` [PATCH] xen: arm: bootfdt: Avoid reading off the front of *_cells array Ian Campbell
2015-07-16 12:06 ` Julien Grall [this message]
2015-07-16 12:45 ` Ian Campbell
2015-07-16 15:52 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A79E2E.3090201@citrix.com \
--to=julien.grall@citrix.com \
--cc=chris.brand@broadcom.com \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.