Re: [Xenomai] [Xenomai-git] Jan Kiszka : cobalt/kernel: Remove unused mode parameter from COBALT_SYSCALL

[Jan Kiszka <jan.kiszka@siemens.com>]

On 2015-07-03 12:51, Gilles Chanteperdrix wrote:
> On Thu, Jul 02, 2015 at 10:26:24PM +0200, Jan Kiszka wrote:
>> Just FYI - still requires testing and more review - find a first
>> generator version below.
>>
>> Jan
>>
>>
>> cobalt/posix/syscall: Generate cobalt_syscalls and cobalt_sysmodes
>>
>> ---
>>  .../arch/x86/include/asm/xenomai/syscall32.h       |  12 +-
>>  kernel/cobalt/posix/Makefile                       |  12 ++
>>  kernel/cobalt/posix/gen-syscall-entries.sh         |  24 +++
>>  kernel/cobalt/posix/syscall.c                      | 208 ++-------------------
>>  scripts/prepare-kernel.sh                          |   4 +-
>>  5 files changed, 57 insertions(+), 203 deletions(-)
>>  create mode 100755 kernel/cobalt/posix/gen-syscall-entries.sh
>>
>> diff --git a/kernel/cobalt/arch/x86/include/asm/xenomai/syscall32.h b/kernel/cobalt/arch/x86/include/asm/xenomai/syscall32.h
>> index 8bd40d4..58b7336 100644
>> --- a/kernel/cobalt/arch/x86/include/asm/xenomai/syscall32.h
>> +++ b/kernel/cobalt/arch/x86/include/asm/xenomai/syscall32.h
>> @@ -45,14 +45,14 @@
>>  #define __syshand32x__(__name)	((cobalt_syshand)(cobalt32x_ ## __name))
>>  
>>  #define __COBALT_CALL32x_INITHAND(__handler)	\
>> -  , [__COBALT_X32_BASE ... __COBALT_X32_BASE + __NR_COBALT_SYSCALLS-1] = __handler
>> +	[__COBALT_X32_BASE ... __COBALT_X32_BASE + __NR_COBALT_SYSCALLS-1] = __handler,
>>  
>>  #define __COBALT_CALL32x_INITMODE(__mode)	\
>> -  , [__COBALT_X32_BASE ... __COBALT_X32_BASE + __NR_COBALT_SYSCALLS-1] = __mode
>> +	[__COBALT_X32_BASE ... __COBALT_X32_BASE + __NR_COBALT_SYSCALLS-1] = __mode,
>>  
>>  /* x32 default entry (no thunk) */
>>  #define __COBALT_CALL32x_ENTRY(__name, __handler)		\
>> -	, [sc_cobalt_ ## __name + __COBALT_X32_BASE] = __handler
>> +	[sc_cobalt_ ## __name + __COBALT_X32_BASE] = __handler,
>>  
>>  /* x32 thunk installation */
>>  #define __COBALT_CALL32x_pure_THUNK(__name)	\
>> @@ -113,14 +113,14 @@
>>  #define __syshand32emu__(__name)	((cobalt_syshand)(cobalt32emu_ ## __name))
>>  
>>  #define __COBALT_CALL32emu_INITHAND(__handler)	\
>> -  , [__COBALT_IA32_BASE ... __COBALT_IA32_BASE + __NR_COBALT_SYSCALLS-1] = __handler
>> +	[__COBALT_IA32_BASE ... __COBALT_IA32_BASE + __NR_COBALT_SYSCALLS-1] = __handler,
>>  
>>  #define __COBALT_CALL32emu_INITMODE(__mode)	\
>> -  , [__COBALT_IA32_BASE ... __COBALT_IA32_BASE + __NR_COBALT_SYSCALLS-1] = __mode
>> +	[__COBALT_IA32_BASE ... __COBALT_IA32_BASE + __NR_COBALT_SYSCALLS-1] = __mode,
>>  
>>  /* ia32 default entry (no thunk) */
>>  #define __COBALT_CALL32emu_ENTRY(__name, __handler)		\
>> -	, [sc_cobalt_ ## __name + __COBALT_IA32_BASE] = __handler
>> +	[sc_cobalt_ ## __name + __COBALT_IA32_BASE] = __handler,
>>  
>>  /* ia32 thunk installation */
>>  #define __COBALT_CALL32emu_THUNK(__name)	\
> 
> Whether this is needed is debatable. From my point of view, it is
> not needed. But in any case, this has nothing to do with what this
> patch does.

It's a precondition for generating a regular list of table entries. But
I'll split this up into a separate patch.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux