All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Clarke <pc@us.ibm.com>
To: "Martin Liška" <mliska@suse.cz>, linux-perf-users@vger.kernel.org
Subject: Re: perf annotate with sample counts
Date: Thu, 16 Jul 2015 09:59:10 -0500	[thread overview]
Message-ID: <55A7C6BE.40700@us.ibm.com> (raw)
In-Reply-To: <55A7A90A.5070008@suse.cz>

On 07/16/2015 07:52 AM, Martin Liška wrote:
> On 07/16/2015 02:44 PM, Paul Clarke wrote:
>> On 07/16/2015 03:00 AM, Martin Liška wrote:
>>> On 07/16/2015 02:55 AM, Paul Clarke wrote:
>>>> Is there a way to get perf annotate to display sample counts instead of, or in addition to, percentages?
>>>>
>>>> The percentages seem relative to the function, which isn't as helpful in a global context.
>>
>>> I think you are exactly looking for: https://lkml.org/lkml/2015/6/19/742, which
>>> I implemented couple of weeks ago :)
>>
>> Near-perfect timing, I guess!  Thanks, Martin!

>> Isn't this function analogous to perf report's "-n, --show-nr-samples" option?  For consistency and usability, would it not be better to use those options instead of "--show-total-period" ?

> Agree with you that it should be renamed to --show-nr-samples, I can come with a patch for that.

Could you include "-n" as a synonym, just like perf report?  That's 
exactly what I tried at first to see if it was supported with perf annotate.

Really appreciate it!

PC

      reply	other threads:[~2015-07-16 14:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16  0:55 perf annotate with sample counts Paul Clarke
2015-07-16  8:00 ` Martin Liška
2015-07-16 12:44   ` Paul Clarke
2015-07-16 12:52     ` Martin Liška
2015-07-16 14:59       ` Paul Clarke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55A7C6BE.40700@us.ibm.com \
    --to=pc@us.ibm.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mliska@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.