From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v2 02/20] xen: Introduce a function to split
 a Linux page into Xen page
Date: Thu, 16 Jul 2015 16:19:32 +0100
Message-ID: <55A7CB84.5070205@citrix.com>
References: <1436474552-31789-1-git-send-email-julien.grall@citrix.com>
	<1436474552-31789-3-git-send-email-julien.grall@citrix.com>
	<alpine.DEB.2.02.1507161520330.17378@kaball.uk.xensource.com>
	<55A7C5A1.7060006@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=6327ebc18=Andrew.Cooper3@citrix.com>)
	id 1ZFkxN-0001oT-Ly
	for xen-devel@lists.xenproject.org; Thu, 16 Jul 2015 15:20:17 +0000
In-Reply-To: <55A7C5A1.7060006@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org, Boris Ostrovsky <boris.ostrovsky@oracle.com>, ian.campbell@citrix.com, David Vrabel <david.vrabel@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 16/07/15 15:54, Julien Grall wrote:
> Hi Stefano,
>
> On 16/07/2015 16:23, Stefano Stabellini wrote:
>>> diff --git a/include/xen/page.h b/include/xen/page.h
>>> index 8ebd37b..b1f7722 100644
>>> --- a/include/xen/page.h
>>> +++ b/include/xen/page.h
>>> @@ -39,4 +39,24 @@ struct xen_memory_region
>>> xen_extra_mem[XEN_EXTRA_MEM_MAX_REGIONS];
>>>
>>>   extern unsigned long xen_released_pages;
>>>
>>> +typedef int (*xen_pfn_fn_t)(struct page *page, unsigned long pfn,
>>> void *data);
>>> +/* Break down the page in 4KB granularity and call fn foreach xen
>>> pfn */
>>> +static inline int xen_apply_to_page(struct page *page, xen_pfn_fn_t
>>> fn,
>>> +                    void *data)
>>> +{
>>> +    unsigned long pfn = xen_page_to_pfn(page);
>>> +    int i;
>>> +    int ret;
>>
>> please initialize ret to 0
>
> Hmmm... right. I'm not sure why the compiler didn't catch it.

Because there is not a path where it can possibly be used
uninitialised.  The for() loop is guaranteed to execute at least once.

~Andrew

>
>>
>>> +    for (i = 0; i < XEN_PFN_PER_PAGE; i++, pfn++) {
>>> +        ret = fn(page, pfn, data);
>>> +        if (ret)
>>> +            return ret;
>>> +    }
>>> +
>>> +    return ret;
>>> +}
>>> +
>>> +
>>>   #endif    /* _XEN_PAGE_H */
>>
>>
>> Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>
> Thank you,
>