From mboxrd@z Thu Jan  1 00:00:00 1970
From: julien.grall@citrix.com (Julien Grall)
Date: Thu, 16 Jul 2015 17:23:43 +0100
Subject: [Xen-devel] [PATCH v2 14/20] xen/grant-table: Make it running
 on 64KB granularity
In-Reply-To: <alpine.DEB.2.02.1507161643380.17378@kaball.uk.xensource.com>
References: <1436474552-31789-1-git-send-email-julien.grall@citrix.com>
 <1436474552-31789-15-git-send-email-julien.grall@citrix.com>
 <alpine.DEB.2.02.1507161643380.17378@kaball.uk.xensource.com>
Message-ID: <55A7DA8F.2040805@citrix.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Hi Stefano,

On 16/07/2015 16:47, Stefano Stabellini wrote:
  >> diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c
>> index 3679293..0a1f903 100644
>> --- a/drivers/xen/grant-table.c
>> +++ b/drivers/xen/grant-table.c
>
> The arm part is fine, but aren't you missing the change to RPP and SPP?

SPP has been removed by commit 548f7c94759ac58d4744ef2663e2a66a106e21c5 
as it was unused.

For RPP, it's used internally so there is no need to switch to 
XEN_PAGE_SIZE. Otherwise we will waste 60KB for each internal page 
allocated (see gnttab_init).

Regards,

-- 
Julien Grall

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755511AbbGPQXt (ORCPT <rfc822;w@1wt.eu>);
	Thu, 16 Jul 2015 12:23:49 -0400
Received: from smtp02.citrix.com ([66.165.176.63]:13207 "EHLO
	SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755459AbbGPQXq (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 16 Jul 2015 12:23:46 -0400
X-IronPort-AV: E=Sophos;i="5.15,488,1432598400"; 
   d="scan'208";a="284789844"
Message-ID: <55A7DA8F.2040805@citrix.com>
Date: Thu, 16 Jul 2015 17:23:43 +0100
From: Julien Grall <julien.grall@citrix.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
CC: Russell King <linux@arm.linux.org.uk>, <ian.campbell@citrix.com>,
        <linux-kernel@vger.kernel.org>, David Vrabel <david.vrabel@citrix.com>,
        <xen-devel@lists.xenproject.org>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [Xen-devel] [PATCH v2 14/20] xen/grant-table: Make it running
 on 64KB granularity
References: <1436474552-31789-1-git-send-email-julien.grall@citrix.com>
	<1436474552-31789-15-git-send-email-julien.grall@citrix.com>
 <alpine.DEB.2.02.1507161643380.17378@kaball.uk.xensource.com>
In-Reply-To: <alpine.DEB.2.02.1507161643380.17378@kaball.uk.xensource.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-DLP: MIA2
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Stefano,

On 16/07/2015 16:47, Stefano Stabellini wrote:
  >> diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c
>> index 3679293..0a1f903 100644
>> --- a/drivers/xen/grant-table.c
>> +++ b/drivers/xen/grant-table.c
>
> The arm part is fine, but aren't you missing the change to RPP and SPP?

SPP has been removed by commit 548f7c94759ac58d4744ef2663e2a66a106e21c5 
as it was unused.

For RPP, it's used internally so there is no need to switch to 
XEN_PAGE_SIZE. Otherwise we will waste 60KB for each internal page 
allocated (see gnttab_init).

Regards,

-- 
Julien Grall