From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFyum-0002bf-7M for qemu-devel@nongnu.org; Fri, 17 Jul 2015 02:14:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZFyuj-0003jl-1l for qemu-devel@nongnu.org; Fri, 17 Jul 2015 02:14:32 -0400 Received: from mail-wg0-x22b.google.com ([2a00:1450:400c:c00::22b]:35465) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFyui-0003im-RA for qemu-devel@nongnu.org; Fri, 17 Jul 2015 02:14:28 -0400 Received: by wgav7 with SMTP id v7so8671566wga.2 for ; Thu, 16 Jul 2015 23:14:28 -0700 (PDT) Sender: Richard Henderson References: <1436958199-5181-1-git-send-email-aurelien@aurel32.net> <1436958199-5181-3-git-send-email-aurelien@aurel32.net> From: Richard Henderson Message-ID: <55A89D41.6030501@twiddle.net> Date: Fri, 17 Jul 2015 07:14:25 +0100 MIME-Version: 1.0 In-Reply-To: <1436958199-5181-3-git-send-email-aurelien@aurel32.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC 2/9] tcg: don't abuse TCG type in tcg_gen_trunc_shr_i64_i32 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno , qemu-devel@nongnu.org Cc: Paolo Bonzini On 07/15/2015 12:03 PM, Aurelien Jarno wrote: > The tcg_gen_trunc_shr_i64_i32 function takes a 64-bit argument and > returns a 32-bit value. Directly call tcg_gen_op3 with the correct > types instead of calling tcg_gen_op3i_i32 and abusing the TCG types. > > Cc: Paolo Bonzini > Cc: Richard Henderson > Signed-off-by: Aurelien Jarno > --- > tcg/tcg-op.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r~