Re: [RFC PATCH 0/2] thermal: Add generic devfreq cooling device

[Chanwoo Choi <cw00.choi@samsung.com>]

Dear Myungjoo,

On 07/17/2015 03:40 PM, MyungJoo Ham wrote:
>>   
>>  This patchset introduce the generic devfreq cooling device for generic thermal
>> framework. The devfreq devices are used ad cooling device to reduce the
>> overheating temperature. This patch is based on drivers/thermal/cpu_cooling.c.
>> The devfreq cooling device can change the ragne of the frequency table of
>> devfreq device according to cooling level in device tree file.
> 
> Hi,
> 
> 
> 1. You've exported "update_devfreq()" in 1/2 and didn't use it anywhere.
> 2. If you've added "update_devfreq()" to notify devfreq driver when a new
>  max/min is defined, you'll need to add it at set_state, OR
>    You may do it with opp_enable()/opp_disable() function and let opp
>  notifiers do the homework for you. (no need to update_devfreq().

It is my mistake. The devfreq_set_cur_state() in patch2 use the update_devfreq()
to change the maximum frequency of devfreq device as following:

+       /* Set the limited frequency to maximum frequency of devfreq */
+       devfreq_dev->devfreq->max_freq = limited_freq;
+       update_devfreq(devfreq_dev->devfreq);

I'll resent v2 patch-set.

Thanks,
Chanwoo Choi