From: Chao Zhu <chaozhu@linux.vnet.ibm.com>
To: Zhe Tao <zhe.tao@intel.com>, dev@dpdk.org
Subject: Re: [PATCH v3] i40e: Fix the endian issue for the i40e read&write registers functions
Date: Fri, 17 Jul 2015 16:09:47 +0800 [thread overview]
Message-ID: <55A8B84B.8070004@linux.vnet.ibm.com> (raw)
In-Reply-To: <1437117940-7849-1-git-send-email-zhe.tao@intel.com>
Acked-by: Chao Zhu <chaozhu@linux.vnet.ibm.com>
On 2015/7/17 15:25, Zhe Tao wrote:
> Signed-off-by: Zhe Tao <zhe.tao@intel.com>
> ---
> PATCH v3: Edit the subject make it more clear
>
> PATCH v2: Edit the comments make it more clear
>
> PATCH v1: Add the endian conversion for registers operations.
>
> drivers/net/i40e/base/i40e_osdep.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/i40e/base/i40e_osdep.h b/drivers/net/i40e/base/i40e_osdep.h
> index 3ce8057..70d2721 100644
> --- a/drivers/net/i40e/base/i40e_osdep.h
> +++ b/drivers/net/i40e/base/i40e_osdep.h
> @@ -122,10 +122,10 @@ do { \
> ((volatile uint32_t *)((char *)(a)->hw_addr + (reg)))
> static inline uint32_t i40e_read_addr(volatile void *addr)
> {
> - return I40E_PCI_REG(addr);
> + return rte_le_to_cpu_32(I40E_PCI_REG(addr));
> }
> #define I40E_PCI_REG_WRITE(reg, value) \
> - do {I40E_PCI_REG((reg)) = (value);} while(0)
> + do { I40E_PCI_REG((reg)) = rte_cpu_to_le_32(value); } while (0)
>
> #define I40E_WRITE_FLUSH(a) I40E_READ_REG(a, I40E_GLGEN_STAT)
> #define I40EVF_WRITE_FLUSH(a) I40E_READ_REG(a, I40E_VFGEN_RSTAT)
next prev parent reply other threads:[~2015-07-17 8:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 10:36 [PATCH] i40e: Fix the endian issue for the i40e read&write registers functions Zhe Tao
2015-07-14 20:03 ` Thomas Monjalon
2015-07-15 1:01 ` Wu, Jingjing
2015-07-17 3:46 ` [PATCH v2] " Zhe Tao
2015-07-17 7:25 ` [PATCH v3] i40e: " Zhe Tao
2015-07-17 8:09 ` Chao Zhu [this message]
2015-07-19 23:17 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A8B84B.8070004@linux.vnet.ibm.com \
--to=chaozhu@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=zhe.tao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.