From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id DFBA8E009E4; Fri, 17 Jul 2015 03:27:39 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [74.125.82.45 listed in list.dnswl.org] Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 6D69FE009D2 for ; Fri, 17 Jul 2015 03:27:35 -0700 (PDT) Received: by wgmn9 with SMTP id n9so78823700wgm.0 for ; Fri, 17 Jul 2015 03:27:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=0HvsX6C0pt6g85opKqxKibu3mbI8ootnNDTr8KVzsxs=; b=S3LQPY4d3Q7jXhItambJjD7Vv0MLYWXDIKdw7ljCUoaXMAtcFJarM0rAMi8R0beTHP JSAtdG+UIwx3uUhxk6j+Y/OinCWfiXqgjWcpPUYq6XVYQaIKMSR10/17dObGEhDT56w4 +N8WzQpHRHVlbImV831k487age9xPj4l9RDZ5f0C+5lY9RS22PJgEflJp+e5yRYmsGgd dNDI1Eh33NW/Q7SaUL8yhotHakevMNS+bvC+YgaH0f37tRpYkQtWT3+rssO4rDzzMUOR rhuEHHqL4Fg8rjYJWRC8MNseuBo+g2hyLxRS1un02uSj6Hh/2Q0b2Ln3wwDwG5Pwv3k2 GjYQ== X-Gm-Message-State: ALoCoQlf4/5lid5a1znK42Twn/uvpMWcG4hjWKjBjKbl5z4nS4l77x/k1bFpo0Q/y6sSBq2n4W6f X-Received: by 10.180.10.200 with SMTP id k8mr14264917wib.52.1437128854917; Fri, 17 Jul 2015 03:27:34 -0700 (PDT) Received: from [192.168.2.157] ([83.217.123.106]) by smtp.googlemail.com with ESMTPSA id bq7sm17670661wjc.31.2015.07.17.03.27.34 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Jul 2015 03:27:34 -0700 (PDT) Message-ID: <55A8D895.5080203@intel.com> Date: Fri, 17 Jul 2015 11:27:33 +0100 From: Michael Wood User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "Damian, Alexandru" References: <55A3E7AA.10704@intel.com> In-Reply-To: Cc: "toaster@yoctoproject.org" Subject: Re: [review-request] adamian/20150707_bugs X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jul 2015 10:27:40 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit From 4c34c2261685ca45a0013ed331a9663bd5e15898 Mon Sep 17 00:00:00 2001 diff --git a/bitbake/lib/toaster/bldcontrol/management/commands/checksettings.py b/bitbake/lib/toaster/bldcontrol/management/commands/checksettings.py index 9b591ad..590a7b0 100644 --- a/bitbake/lib/toaster/bldcontrol/management/commands/checksettings.py +++ b/bitbake/lib/toaster/bldcontrol/management/commands/checksettings.py @@ -166,7 +166,12 @@ class Command(NoArgsCommand): for dirname in self._recursive_list_directories(be.sourcedir,2): if os.path.exists(os.path.join(dirname, ".templateconf")): import subprocess - conffilepath, error = subprocess.Popen('bash -c ". '+os.path.join(dirname, ".templateconf")+'; echo \"\$TEMPLATECONF\""', shell=True, stdout=subprocess.PIPE).communicate() + proc = subprocess.Popen('bash -c ". '+os.path.join(dirname, ".templateconf")+'; echo \"\$TEMPLATECONF\""', shell=True, stdout=subprocess.PIPE) + conffilepath, stderroroutput = proc.communicate() + proc.wait() + if proc.returncode != 0: + raise Exception("Failed to source TEMPLATECONF: %s" % stderroroutput) + Can't we just use subprocess.check_output and a try/except for all of this? Apart from that everything else looks fine. Michael On 15/07/15 13:31, Damian, Alexandru wrote: > Hi, > > The patch that Michael suggested to fix is now refactored, and the > patchset rebased. > > I pushed the changes on the same branch (force update). > > Can you please review ? > > Cheers, > Alex > > On Mon, Jul 13, 2015 at 5:30 PM, Michael Wood > > wrote: > > > Could you include the summary of each of the commits for review so > that we can be sure which patches are the new ones > > * 3b0073f bitbake: toaster: fix updates on failed build requests > * 1bdd687 bitbake: toaster: replace raising Exceptions in loadconf > * 99a626a bitbake: toaster: do not stop data import on bad data > > Look fine to me > > * 4fc46e7 bitbake: toastergui: fixing pylint warnings > > This one needs splitting up, pylint fixes, logging fixes , string > to int casting, etc > > Thanks, > > Michael > > > > On 08/07/15 15:52, Barros Pena, Belen wrote: > > > On 07/07/2015 17:27, "Damian, Alexandru" > > > wrote: > > Hi, > > > I have some comments below, > > > Alex > > On Tue, Jul 7, 2015 at 3:54 PM, Barros Pena, Belen > > wrote: > > > > On 07/07/2015 15:10, "Damian, Alexandru" > > > wrote: > > Hello, > > > I'm pushing two patches for review > > > - one is fixing 7955 > > Thanks for the quick fix, Alex! I've tested this on > master, and I've > noticed a couple of things: > > 1. The invalid data from the layer index causes warnings > when importing > the information. This might be because the debug mode is > enabled, though, > but I thought I'd bringing it up just in case. > > ​This happens because data doesn't match what Toaster > expect - Toaster > has a bit stricter ​requirements than Layer Index. I would > expect that > the warning messages are helpful to the user, and they > should not be > obscured. If a particular user wishes to not see some of > the messages, > they can set up the debug level to something higher in > settings.py. Or we > can ship with a higher debug level by default, but I don't > think we > should silently ignore bad data. > > Sure: I can see your point. I was only bringing it up, but I > am not sure > what's best, to be honest: showing them or not. As you said, > falling > silent doesn't sound right; on the other hand, the messages > look a bit > alarming. > > > 2. I can see at least one recipe in the 'all recipes' > table without a > name. This particular one is provided by meta-ivi. You can > add the layer > and you get a build button, which you can click, although > when you do so > the build does not seem to start. I think we need to hide > any recipes that > do not have a name from the list. They are invalid, and > should not be > exposed to users. > > ​We can add such a check, of course, on imported data. I > would say this > is the object of a different bug report, though. > > Done! https://bugzilla.yoctoproject.org/show_bug.cgi?id=7969 > > Also, I think we are going to need to back port the fix to > Fido. > > Is back porting ok? Should we track this somehow? > > Thanks! > > Belén > > Cheers > > Belén > > - one is fixing various issues highlighted by pylint > > > https://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=adamian/20 > 1 > 50707_bugs > > > > ​Can you please review ? > > > Cheers, > Alex​ > > > > > -- > Alex Damian > Yocto Project > > SSG / OTC > > > > > > > > > > > > > -- > Alex Damian > Yocto Project > > SSG / OTC > > > > > > -- > _______________________________________________ > toaster mailing list > toaster@yoctoproject.org > https://lists.yoctoproject.org/listinfo/toaster > > > > > -- > Alex Damian > Yocto Project > SSG / OTC > > --------------------------------------------------------------------- > Intel Corporation (UK) Limited > Registered No. 1134945 (England) > Registered Office: Pipers Way, Swindon SN3 1RJ > VAT No: 860 2173 47 > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. >