From: Paolo Bonzini <pbonzini@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: Linhaifeng <haifeng.lin@huawei.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Thibaut Collet <thibaut.collet@6wind.com>,
jasowang@redhat.com, QEMU <qemu-devel@nongnu.org>,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4 1/1] vhost user: add support of live migration
Date: Fri, 17 Jul 2015 15:50:25 +0200 [thread overview]
Message-ID: <55A90821.6000409@redhat.com> (raw)
In-Reply-To: <CAJ+F1CKe=aJEGTp6i8rpQNs_5ttyS02KW=7t57Vn92-f6fP=eA@mail.gmail.com>
On 17/07/2015 15:35, Marc-André Lureau wrote:
>> > LOG_FD is implemented in the kernel drivers/vhost/vhost.c. It seems to
>> > be an eventfd-like mechanism to save on dirty bitmap scans. However,
>> > it's not well documented how to implement it in a correct way.
> and it's not used by qemu, so hard to say if it actually work well.
>
> > In any case, live migration needs a new message type (like LOG_MMAP_FD)
> > in the vhost-user protocol.
>
> Yes, perhaps with size and offset. I am looking at this.
The offset should be 0...
Do you know the size of the ram_addr_t space from
VHOST_USER_SET_MEM_TABLE's user address and size fields?
If the size isn't needed, you can reuse LOG_BASE, ignoring the content
of the payload and adding the SCM_RIGHTS file descriptor.
Paolo
next prev parent reply other threads:[~2015-07-17 13:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 9:22 [Qemu-devel] [PATCH v4 0/1] Add live migration for vhost user Thibaut Collet
2015-06-26 9:22 ` [Qemu-devel] [PATCH v4 1/1] vhost user: add support of live migration Thibaut Collet
2015-07-10 13:05 ` Paolo Bonzini
2015-07-13 2:27 ` Linhaifeng
2015-07-17 0:19 ` Marc-André Lureau
2015-07-17 2:25 ` Paolo Bonzini
2015-07-17 10:34 ` Marc-André Lureau
2015-07-17 12:57 ` Paolo Bonzini
2015-07-17 13:35 ` Marc-André Lureau
2015-07-17 13:50 ` Paolo Bonzini [this message]
2015-07-18 0:07 ` Marc-André Lureau
2015-07-18 13:18 ` Paolo Bonzini
2015-07-17 0:20 ` [Qemu-devel] [PATCH v4 0/1] Add live migration for vhost user Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A90821.6000409@redhat.com \
--to=pbonzini@redhat.com \
--cc=haifeng.lin@huawei.com \
--cc=jasowang@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thibaut.collet@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.