From: Jens Axboe <axboe@kernel.dk>
To: Andrey Kuzmin <andrey.v.kuzmin@gmail.com>
Cc: fio@vger.kernel.org
Subject: Re: PATCH: Don't lose pending completions on exit in time- or size-based job with asynchronous I/O engine
Date: Fri, 17 Jul 2015 08:58:46 -0600 [thread overview]
Message-ID: <55A91826.8080407@kernel.dk> (raw)
In-Reply-To: <CANvN+en4p0q4Ff4n9KBLku5O67Cs68VUpp0qHK+ye2Cu4YbcJw@mail.gmail.com>
On 07/17/2015 08:53 AM, Andrey Kuzmin wrote:
>
> On Jul 17, 2015 5:36 PM, "Jens Axboe" <axboe@kernel.dk
> <mailto:axboe@kernel.dk>> wrote:
> >
> > On 07/17/2015 08:30 AM, Andrey Kuzmin wrote:
> >>
> >> Probably worth adding to do_verify() as well.
> >
> >
> > Might be better to ensure that they are reaped when we break out of
> the loop instead?
> >
>
> That's exactly what happens with the patch, doesn't it?
It might be... It's not very clear why a !td->cur_depth should force us
to stay in the loop?
So lets back this up a bit. What problems were observed? Test case?
--
Jens Axboe
next prev parent reply other threads:[~2015-07-17 14:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 14:30 PATCH: Don't lose pending completions on exit in time- or size-based job with asynchronous I/O engine Andrey Kuzmin
2015-07-17 14:36 ` Jens Axboe
2015-07-17 14:53 ` Andrey Kuzmin
2015-07-17 14:58 ` Jens Axboe [this message]
2015-07-17 15:02 ` Andrey Kuzmin
2015-07-17 15:11 ` Jens Axboe
[not found] ` <CANvN+e=S1Yfy3ZCtPv+LQqDOAhxhw90PDU-1fYH66W2mrH4NOw@mail.gmail.com>
2015-07-19 12:08 ` Andrey Kuzmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A91826.8080407@kernel.dk \
--to=axboe@kernel.dk \
--cc=andrey.v.kuzmin@gmail.com \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.