From: "Siluvery, Arun" <arun.siluvery@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
intel-gfx@lists.freedesktop.org,
Mika Kuoppala <mika.kuoppala@intel.com>,
Armin Reese <armin.c.reese@intel.com>
Subject: Re: [PATCH v1 3/4] drm/i915:bxt: Enable Pooled EU support
Date: Fri, 17 Jul 2015 17:54:20 +0100 [thread overview]
Message-ID: <55A9333C.3020005@linux.intel.com> (raw)
In-Reply-To: <20150717162743.GD31965@nuc-i3427.alporthouse.com>
On 17/07/2015 17:27, Chris Wilson wrote:
> On Fri, Jul 17, 2015 at 05:08:53PM +0100, Arun Siluvery wrote:
>> This mode allows to assign EUs to pools.
>> The command to enable this mode is sent in auxiliary golden context batch
>> as this is only issued once with each context initialization. Thanks to
>> Mika for the preliminary review.
>
> A quick explanation for why this has to be in the kernel would be nice.
> Privileged instruction?
This purpose of auxiliary batch is explained in patch2, but I can add
some explanation about this one also.
>
> Not fond of the split between this and patch 4. Patch 4 intoduces one
> feature flag that looks different to the one we use here to enable
> support.
I will patch4 as separate as it deals with libdrm changes but use the
feature flag in this one.
regards
Arun
> -Chris
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-07-17 16:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 16:08 [PATCH v1 0/4] Add Pooled EU support to BXT Arun Siluvery
2015-07-17 16:08 ` [PATCH v1 1/4] drm/i915: Do kunmap if renderstate parsing fails Arun Siluvery
2015-07-21 7:26 ` Daniel Vetter
2015-07-17 16:08 ` [PATCH v1 2/4] drm/i915: Add provision to extend Golden context batch Arun Siluvery
2015-07-17 16:23 ` Chris Wilson
2015-07-17 16:37 ` Mika Kuoppala
2015-07-17 16:48 ` Chris Wilson
2015-07-17 16:08 ` [PATCH v1 3/4] drm/i915:bxt: Enable Pooled EU support Arun Siluvery
2015-07-17 16:27 ` Chris Wilson
2015-07-17 16:50 ` Mika Kuoppala
2015-07-17 16:54 ` Siluvery, Arun [this message]
2015-07-17 16:58 ` Chris Wilson
2015-07-17 16:08 ` [PATCH v1 4/4] drm/i915/bxt: Add get_param to query Pooled EU availability Arun Siluvery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A9333C.3020005@linux.intel.com \
--to=arun.siluvery@linux.intel.com \
--cc=armin.c.reese@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.