From: Austin S Hemmelgarn <ahferroin7@gmail.com>
To: Oleg Nesterov <oleg@redhat.com>, Benjamin LaHaise <bcrl@kvack.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Joonsoo Kim <js1304@gmail.com>,
Fengguang Wu <fengguang.wu@intel.com>,
Jeff Moyer <jmoyer@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm-move-mremap-from-file_operations-to-vm_operations_struct-fix
Date: Fri, 17 Jul 2015 14:12:08 -0400 [thread overview]
Message-ID: <55A94578.5050306@gmail.com> (raw)
In-Reply-To: <20150717175542.GA31888@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 572 bytes --]
On 2015-07-17 13:55, Oleg Nesterov wrote:
> On 07/17, Benjamin LaHaise wrote:
>>
>> Don't add BUG(). It's the equivalent approach of saying "I think this code
>> isn't needed, but I'm lazy and not going to remove it properly."
>
> There is another interpretation: I think this code must be never called,
> if it is actually called we have a serious problem which should be loudly
> reported.
>
And not compiling it at all _will_ loudly report it, it'll just report
it during linking instead of at run-time, which is a much better time to
shout about it.
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 2967 bytes --]
next prev parent reply other threads:[~2015-07-17 18:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 23:14 [PATCH] mm-move-mremap-from-file_operations-to-vm_operations_struct-fix Oleg Nesterov
2015-07-16 23:22 ` Stephen Rothwell
2015-07-16 23:24 ` Andrew Morton
2015-07-16 23:52 ` Oleg Nesterov
2015-07-17 14:06 ` Benjamin LaHaise
2015-07-17 17:27 ` Oleg Nesterov
2015-07-17 17:37 ` Benjamin LaHaise
2015-07-17 17:55 ` Oleg Nesterov
2015-07-17 18:12 ` Austin S Hemmelgarn [this message]
2015-07-17 18:19 ` Oleg Nesterov
2015-07-17 18:39 ` Austin S Hemmelgarn
2015-07-17 18:54 ` Oleg Nesterov
2015-07-17 19:09 ` Austin S Hemmelgarn
2015-07-17 22:56 ` Oleg Nesterov
2015-07-17 22:31 ` Oleg Nesterov
2015-07-20 14:22 ` Jeff Moyer
2015-07-20 17:33 ` Oleg Nesterov
2015-07-20 17:51 ` Benjamin LaHaise
2015-07-20 18:30 ` Jeff Moyer
2015-07-20 18:31 ` Oleg Nesterov
2015-07-20 19:24 ` Oleg Nesterov
2015-07-20 19:39 ` Benjamin LaHaise
2015-07-20 20:03 ` Oleg Nesterov
2015-07-21 15:29 ` [PATCH v2] mm-move-mremap-from-file_operations-to-vm_operations_struct-fix Oleg Nesterov
2015-07-21 15:38 ` Benjamin LaHaise
2015-07-21 16:18 ` Oleg Nesterov
2015-07-21 16:20 ` [PATCH v3] mm-move-mremap-from-file_operations-to-vm_operations_struct-fix Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A94578.5050306@gmail.com \
--to=ahferroin7@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bcrl@kvack.org \
--cc=fengguang.wu@intel.com \
--cc=hannes@cmpxchg.org \
--cc=jmoyer@redhat.com \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.