From: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: JBottomley@odin.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ibmvscsi:Fix comment about return values for the function ibmvfc_target_alloc
Date: Fri, 17 Jul 2015 14:13:43 -0700 [thread overview]
Message-ID: <55A97007.4040605@linux.vnet.ibm.com> (raw)
In-Reply-To: <1436472994-31885-1-git-send-email-xerofoify@gmail.com>
On 07/09/2015 01:16 PM, Nicholas Krause wrote:
> This fixes the comment about return values for the function
> ibmvfc_target_alloc to correctly state it only returns zero
> as it always runs successfully and therefore never signals
> its caller with the error code -ENXIO due to this exact
> reasoning.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
Again, just a nit on the patch description wording. Something like the
following would suffice.
"Remove mention of -ENXIO from comment on return values for
ibmvfc_slave_alloc() as the function currently always returns 0."
Otherwise,
Acked-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
> ---
> drivers/scsi/ibmvscsi/ibmvfc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
> index 057d277..55f161b 100644
> --- a/drivers/scsi/ibmvscsi/ibmvfc.c
> +++ b/drivers/scsi/ibmvscsi/ibmvfc.c
> @@ -2854,7 +2854,7 @@ static int ibmvfc_slave_alloc(struct scsi_device *sdev)
> * expected.
> *
> * Returns:
> - * 0 on success / -ENXIO if device does not exist
> + * 0 on success
> **/
> static int ibmvfc_target_alloc(struct scsi_target *starget)
> {
>
parent reply other threads:[~2015-07-17 21:13 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1436472994-31885-1-git-send-email-xerofoify@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A97007.4040605@linux.vnet.ibm.com \
--to=tyreld@linux.vnet.ibm.com \
--cc=JBottomley@odin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.