All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexei Starovoitov <ast@plumgrid.com>
To: John Fastabend <john.fastabend@gmail.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	davem@davemloft.net
Cc: jiri@resnulli.us, jhs@mojatatu.com, edumazet@google.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH net 1/3] sched: cls_bpf: fix panic on filter replace
Date: Fri, 17 Jul 2015 14:31:02 -0700	[thread overview]
Message-ID: <55A97416.60709@plumgrid.com> (raw)
In-Reply-To: <55A96E05.2090002@gmail.com>

On 7/17/15 2:05 PM, John Fastabend wrote:
> On 15-07-17 01:38 PM, Daniel Borkmann wrote:
>> >The following test case causes a NULL pointer dereference in cls_bpf:
>> >
>> >   FOO="1,6 0 0 4294967295,"
>> >   tc filter add dev foo parent 1: bpf bytecode "$FOO" flowid 1:1 action ok
>> >   tc filter replace dev foo parent 1: pref 49152 handle 0x1 \
>> >             bpf bytecode "$FOO" flowid 1:1 action drop
>> >
>> >The problem is that commit 1f947bf151e9 ("net: sched: rcu'ify cls_bpf")
>> >accidentally swapped the arguments of list_replace_rcu(), the old
>> >element needs to be the first argument and the new element the second.
>> >
>> >Fixes: 1f947bf151e9 ("net: sched: rcu'ify cls_bpf")
>> >Signed-off-by: Daniel Borkmann<daniel@iogearbox.net>
>> >---
> Thanks Daniel. Apparently I got this right in cls_basic but botched it
> here and in cls_flow.
>
> FWIW,
>
> Acked-by: John Fastabend<john.r.fastabend@intel.com>

Thanks for the quick fix.
Acked-by: Alexei Starovoitov <ast@plumgrid.com>

  parent reply	other threads:[~2015-07-17 21:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-17 20:38 [PATCH net 0/3] Couple of classifier fixes Daniel Borkmann
2015-07-17 20:38 ` [PATCH net 1/3] sched: cls_bpf: fix panic on filter replace Daniel Borkmann
2015-07-17 21:05   ` John Fastabend
2015-07-17 21:07     ` Daniel Borkmann
2015-07-17 21:31     ` Alexei Starovoitov [this message]
2015-07-17 20:38 ` [PATCH net 2/3] sched: cls_flower: " Daniel Borkmann
2015-07-18 20:37   ` Jiri Pirko
2015-07-17 20:38 ` [PATCH net 3/3] sched: cls_flow: " Daniel Borkmann
2015-07-17 21:07   ` John Fastabend
2015-07-17 20:41 ` [PATCH net 0/3] Couple of classifier fixes Daniel Borkmann
2015-07-17 21:01   ` John Fastabend
2015-07-21  7:25 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55A97416.60709@plumgrid.com \
    --to=ast@plumgrid.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=john.fastabend@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.