From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:46013 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751496AbbGSKD5 (ORCPT ); Sun, 19 Jul 2015 06:03:57 -0400 Message-ID: <55AB760B.5020901@kernel.org> Date: Sun, 19 Jul 2015 11:03:55 +0100 From: Jonathan Cameron MIME-Version: 1.0 To: Hartmut Knaack , linux-iio@vger.kernel.org CC: Lars-Peter Clausen , Peter Meerwald , Irina Tirdea , Vlad Dogaru Subject: Re: [PATCH 3/8] iio:magnetometer:bmc150_magn: output intended variable References: <8f490c090729953bfdb9c02c9ad36cc873a701d7.1437090791.git.knaack.h@gmx.de> In-Reply-To: <8f490c090729953bfdb9c02c9ad36cc873a701d7.1437090791.git.knaack.h@gmx.de> Content-Type: text/plain; charset=windows-1252 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 17/07/15 09:52, Hartmut Knaack wrote: > According to the debug/error string, the content of chip_id is supposed to > be output, rather than the return value of the previous operation. > > Fixes: c91746a2361d ("iio: magn: Add support for BMC150 magnetometer") > > Signed-off-by: Hartmut Knaack Applied to the fixes-togreg branch of iio.git. Thanks, Jonathan > --- > drivers/iio/magnetometer/bmc150_magn.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/magnetometer/bmc150_magn.c b/drivers/iio/magnetometer/bmc150_magn.c > index cd002710dd02..7da4ce9409e8 100644 > --- a/drivers/iio/magnetometer/bmc150_magn.c > +++ b/drivers/iio/magnetometer/bmc150_magn.c > @@ -694,11 +694,11 @@ static int bmc150_magn_init(struct bmc150_magn_data *data) > goto err_poweroff; > } > if (chip_id != BMC150_MAGN_CHIP_ID_VAL) { > - dev_err(&data->client->dev, "Invalid chip id 0x%x\n", ret); > + dev_err(&data->client->dev, "Invalid chip id 0x%x\n", chip_id); > ret = -ENODEV; > goto err_poweroff; > } > - dev_dbg(&data->client->dev, "Chip id %x\n", ret); > + dev_dbg(&data->client->dev, "Chip id %x\n", chip_id); > > preset = bmc150_magn_presets_table[BMC150_MAGN_DEFAULT_PRESET]; > ret = bmc150_magn_set_odr(data, preset.odr); >