All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Daniel Baluta <daniel.baluta@intel.com>
Cc: viorel.suman@intel.com, knaack.h@gmx.de, lars@metafoo.de,
	pmeerw@pmeerw.net, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] iio: magnetometer: mmc35240: Fix SET/RESET mask
Date: Sun, 19 Jul 2015 11:54:10 +0100	[thread overview]
Message-ID: <55AB81D2.5060409@kernel.org> (raw)
In-Reply-To: <1436885814-29155-3-git-send-email-daniel.baluta@intel.com>

On 14/07/15 15:56, Daniel Baluta wrote:
> This fixes setting the SET/RESET bit in the REG_CTRL0
> register.
> 
> Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
Applied to the fixes-togreg branch of iio.git

Thanks,
> ---
>  drivers/iio/magnetometer/mmc35240.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/magnetometer/mmc35240.c b/drivers/iio/magnetometer/mmc35240.c
> index e89b059..f4d7495 100644
> --- a/drivers/iio/magnetometer/mmc35240.c
> +++ b/drivers/iio/magnetometer/mmc35240.c
> @@ -195,8 +195,8 @@ static int mmc35240_hw_set(struct mmc35240_data *data, bool set)
>  		coil_bit = MMC35240_CTRL0_RESET_BIT;
>  
>  	return regmap_update_bits(data->regmap, MMC35240_REG_CTRL0,
> -				  MMC35240_CTRL0_REFILL_BIT,
> -				  coil_bit);
> +				  coil_bit, coil_bit);
> +
>  }
>  
>  static int mmc35240_init(struct mmc35240_data *data)
> 


  reply	other threads:[~2015-07-19 10:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-14 14:56 [PATCH 0/3] MMC35240 magneto fixes Daniel Baluta
2015-07-14 14:56 ` [PATCH 1/3] iio: magnetometer: mmc35240: Fix crash in pm suspend Daniel Baluta
2015-07-19 10:49   ` Jonathan Cameron
2015-07-14 14:56 ` [PATCH 2/3] iio: magnetometer: mmc35240: Fix SET/RESET mask Daniel Baluta
2015-07-19 10:54   ` Jonathan Cameron [this message]
2015-07-14 14:56 ` [PATCH 3/3] iio: magnetometer: mmc35240: fix SET/RESET sequence Daniel Baluta
2015-07-14 20:04   ` Jonathan Cameron
2015-07-16 13:30     ` Daniel Baluta
2015-07-19 10:55       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55AB81D2.5060409@kernel.org \
    --to=jic23@kernel.org \
    --cc=daniel.baluta@intel.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=viorel.suman@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.