From: Loic Dachary <loic@dachary.org>
To: Ken Dreyer <kdreyer@redhat.com>
Cc: Ceph Development <ceph-devel@vger.kernel.org>
Subject: Breaks & Replaces in debian/control in backports
Date: Sun, 19 Jul 2015 13:28:04 +0200 [thread overview]
Message-ID: <55AB89C4.50503@dachary.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1454 bytes --]
Hi Ken,
In the context of https://github.com/ceph/ceph/pull/5206 we need to adapt the version constraints for the Breaks / Replaces in debian/control. What we currently do is something like x.y.z-vvv where we randomly pick vvv to be something we're sure won't be greater than the actual vvv from git-describe that will be associated to this specific commit (otherwise the constraints won't be satisfied and the install will break).
When backporting it translates into something like:
Package: ceph
Depends: ceph-common (>= 0.94.2-23)
Package: ceph-common
Replaces: ceph-client-tools,
ceph (<< 0.94.2-23),
Breaks: ceph (<< 0.94.2-23),
I propose instead we use the version of the previous stable release like so:
Package: ceph
Depends: ceph-common (>> 0.94.2)
Package: ceph-common
Replaces: ceph-client-tools,
ceph (<= 0.94.2),
Breaks: ceph (<= 0.94.2),
I think it achieves the same thing and is less error prone in the case of backports. The risk is that upgrading from v0.94.2-34 to the version with this change will fail because the conditions are satisified (it thinks all versions after v0.94.2 have the change). But the odds of having a test machine with this specific version already installed are close to non-existent. The odds of us picking the wrong number and ending up with something that's either too high or too small are higher.
What do you think ?
--
Loïc Dachary, Artisan Logiciel Libre
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next reply other threads:[~2015-07-19 11:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-19 11:28 Loic Dachary [this message]
2015-07-22 16:47 ` Breaks & Replaces in debian/control in backports Ken Dreyer
2015-07-30 7:28 ` Loic Dachary
2015-07-30 12:25 ` Sage Weil
2015-07-30 19:47 ` Loic Dachary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AB89C4.50503@dachary.org \
--to=loic@dachary.org \
--cc=ceph-devel@vger.kernel.org \
--cc=kdreyer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.