All of lore.kernel.org
 help / color / mirror / Atom feed
From: riel@surriel.com (Rik van Riel)
To: kernelnewbies@lists.kernelnewbies.org
Subject: What can I do if I sent a wrong patch?
Date: Sun, 19 Jul 2015 17:03:58 -0400	[thread overview]
Message-ID: <55AC10BE.5000304@surriel.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1507190544150.26267@localhost>

On 07/19/2015 05:46 AM, Robert P. J. Day wrote:
> On Sun, 19 Jul 2015, Navy wrote:
> 
>> Hello,
> 
>> A mistake was found after I sent the patch to mentors. What Can I do
>> to make up the fault?
> 
>   first, if they're truly mentors, they should check the patch
> themselves and catch the error. otherwise, they're not really doing
> their job as "mentors."
> 
>   second, you need to self-examine what you failed to do properly to
> have sent in a bad patch.

third, send out a follow-up email informing people that you found a
mistake with your patch.

People appreciate developers who take responsibility for their code,
and work to fix it up after the fact.


-- 
All rights reversed.

      reply	other threads:[~2015-07-19 21:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-19  9:40 What can I do if I sent a wrong patch? Navy
2015-07-19  9:46 ` Robert P. J. Day
2015-07-19 21:03   ` Rik van Riel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55AC10BE.5000304@surriel.com \
    --to=riel@surriel.com \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.