From: Thomas Huth <thuth@redhat.com>
To: Alexander Bezzubikov <zuban32s@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC] ATAPI-SCSI bridge GSoC project
Date: Mon, 20 Jul 2015 08:59:34 +0200 [thread overview]
Message-ID: <55AC9C56.7080605@redhat.com> (raw)
In-Reply-To: <1437245366-20156-1-git-send-email-abezzubikov@ispras.ru>
On 18/07/15 20:49, Alexander Bezzubikov wrote:
> atapi: ATAPI-SCSI bridge device created
> private SCSI bus added to bridge
> ATAPI inquiry command can use a bridge
Hi!
Not everybody is familiar with your GSoC project, so it would be great
if you could be a little bit more verbose in your patch description.
Unfortunately, your patch also has some style issues, please make sure
to read http://qemu-project.org/Contribute/SubmitAPatch first.
Especially:
- Your patch lacks a Signed-off-by line
- scripts/checkpatch.pl reports quite a bunch of errors
- Make sure to CC the right maintainers
Hope that helps,
Thomas
next prev parent reply other threads:[~2015-07-20 6:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-18 18:49 [Qemu-devel] [RFC] ATAPI-SCSI bridge GSoC project Alexander Bezzubikov
2015-07-20 6:59 ` Thomas Huth [this message]
2015-07-20 11:03 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AC9C56.7080605@redhat.com \
--to=thuth@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zuban32s@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.