From: michal.simek@xilinx.com (Michal Simek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: zynq: reserve space for jump target in secondary trampoline
Date: Mon, 20 Jul 2015 10:43:28 +0200 [thread overview]
Message-ID: <55ACB4B0.3040906@xilinx.com> (raw)
In-Reply-To: <1437166862-29782-1-git-send-email-nathan_lynch@mentor.com>
On 07/17/2015 11:01 PM, Nathan Lynch wrote:
> Add a zero argument to the .word directive in
> zynq_secondary_trampoline. Without an expression the assembler emits
> nothing for the .word directive.
>
> This makes it so that the intended range is communicated to ioremap
> and outer_flush_range in zynq_cpun_start; e.g. for LE
> trampoline_code_size evaluates to 12 now instead of 8.
>
> Found by inspection. I'm not aware of any real problem this fixes.
> Tested by doing on online/offline loop on ZC702.
>
> Signed-off-by: Nathan Lynch <nathan_lynch@mentor.com>
> ---
> arch/arm/mach-zynq/headsmp.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-zynq/headsmp.S b/arch/arm/mach-zynq/headsmp.S
> index 045c72720a4d..f6d5de073e34 100644
> --- a/arch/arm/mach-zynq/headsmp.S
> +++ b/arch/arm/mach-zynq/headsmp.S
> @@ -18,7 +18,7 @@ ARM_BE8(rev r0, r0)
> .globl zynq_secondary_trampoline_jump
> zynq_secondary_trampoline_jump:
> /* Space for jumping address */
> - .word /* cpu 1 */
> + .word 0 /* cpu 1 */
> .globl zynq_secondary_trampoline_end
> zynq_secondary_trampoline_end:
> ENDPROC(zynq_secondary_trampoline)
>
Tested and applied to zynq/cleanup.
Thanks,
Michal
prev parent reply other threads:[~2015-07-20 8:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 21:01 [PATCH] ARM: zynq: reserve space for jump target in secondary trampoline Nathan Lynch
2015-07-20 8:43 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55ACB4B0.3040906@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.