From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH v3 2/8] ACPI / irqchip: Add self-probe infrastructure to initialize IRQ controller Date: Mon, 20 Jul 2015 07:12:06 -0500 Message-ID: <55ACE596.10709@codeaurora.org> References: <1436525114-14425-1-git-send-email-hanjun.guo@linaro.org> <1436525114-14425-3-git-send-email-hanjun.guo@linaro.org> <55ACC022.1000800@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:52657 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753024AbbGTMML (ORCPT ); Mon, 20 Jul 2015 08:12:11 -0400 In-Reply-To: <55ACC022.1000800@linaro.org> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Hanjun Guo Cc: Marc Zyngier , Jason Cooper , Will Deacon , Catalin Marinas , "Rafael J. Wysocki" , Wei Huang , Lorenzo Pieralisi , Arnd Bergmann , linaro-acpi@lists.linaro.org, lkml , Tomasz Nowicki , linux-acpi@vger.kernel.org, Mark Brown , Grant Likely , Thomas Gleixner , Jiang Liu , "linux-arm-kernel@lists.infradead.org" Hanjun Guo wrote: >> Should we display an error message if we don't find a matching table? >> That can happen if the ACPI tables shows a GIC version number that is >> not listed in __irqchip_acpi_table[]? > > Hmm, did you get the error message like: "Invalid GIC version 5 in > MADT"? or just use ACPI_MADT_GIC_VERSION_V1 as the gic_version? if > the later one, it will show everything is fine, but failed to probe > the GIC. We had a bug in our ACPI tables that listed the GIC version as 1, and it failed to probe and then the kernel panicked. It took me a while to figure out what was wrong, so I think it should print an error message that says that version X is unsupported. -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation. From mboxrd@z Thu Jan 1 00:00:00 1970 From: timur@codeaurora.org (Timur Tabi) Date: Mon, 20 Jul 2015 07:12:06 -0500 Subject: [PATCH v3 2/8] ACPI / irqchip: Add self-probe infrastructure to initialize IRQ controller In-Reply-To: <55ACC022.1000800@linaro.org> References: <1436525114-14425-1-git-send-email-hanjun.guo@linaro.org> <1436525114-14425-3-git-send-email-hanjun.guo@linaro.org> <55ACC022.1000800@linaro.org> Message-ID: <55ACE596.10709@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hanjun Guo wrote: >> Should we display an error message if we don't find a matching table? >> That can happen if the ACPI tables shows a GIC version number that is >> not listed in __irqchip_acpi_table[]? > > Hmm, did you get the error message like: "Invalid GIC version 5 in > MADT"? or just use ACPI_MADT_GIC_VERSION_V1 as the gic_version? if > the later one, it will show everything is fine, but failed to probe > the GIC. We had a bug in our ACPI tables that listed the GIC version as 1, and it failed to probe and then the kernel panicked. It took me a while to figure out what was wrong, so I think it should print an error message that says that version X is unsupported. -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation.