Re: [PATCH net-next] cxgb4: Add debugfs entry to enable/disable backdoor access

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 7/20/2015 5:54 PM, Hariprasad Shenai wrote:

> Add debugfs entry 'use_backdoor' to enable/disable backdoor access
> to read sge context. By default, we read sge context's via firmware. In
> case of FW issues, one can enable backdoor access via debugfs to dump
> sge context for debugging purpose.

> Signed-off-by: Hariprasad Shenai <hariprasad@chelsio.com>
[...]
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
> index b135d05..5b525a7 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
> @@ -2386,8 +2386,11 @@ int t4_setup_debugfs(struct adapter *adap)
>   					EXT_MEM_SIZE_G(size));
>   	}
>
> -	de = debugfs_create_file_size("flash", S_IRUSR, adap->debugfs_root, adap,
> -				      &flash_debugfs_fops, adap->params.sf_size);
> +	de = debugfs_create_file_size("flash", S_IRUSR, adap->debugfs_root,
> +				      adap, &flash_debugfs_fops,
> +				      adap->params.sf_size);

    What was the point reformatting this call?

[...]
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
> index 1e6597d..f8f446e 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
> @@ -3689,6 +3689,11 @@ int t4_read_rss(struct adapter *adapter, u16 *map)
>   	return 0;
>   }
>
> +static unsigned int t4_use_ldst(struct adapter *adap)
> +{
> +	return (adap->flags & FW_OK) || (!adap->use_bd);

    Second parens not neeeded.

[...]

WBR, Sergei