From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Chen, Tiejun" <tiejun.chen@intel.com>
Subject: Re: [v10][PATCH 11/16] tools/libxl: detect and avoid
 conflicts with RDM
Date: Mon, 20 Jul 2015 22:40:02 +0800
Message-ID: <55AD0842.1010906@intel.com>
References: <1437373023-14884-1-git-send-email-tiejun.chen@intel.com>
	<1437373023-14884-12-git-send-email-tiejun.chen@intel.com>
	<21932.63595.566823.211293@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21932.63595.566823.211293@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org


Note I need more time to address others.

>> +int libxl__domain_device_construct_rdm(libxl__gc *gc,
>> +                                       libxl_domain_config *d_config,
>> +                                       uint64_t rdm_mem_boundary,
>> +                                       struct xc_hvm_build_args *args)
>> +{
> ...
>> +    /* Query all RDM entries in this platform */
>> +    if (strategy == LIBXL_RDM_RESERVE_STRATEGY_HOST) {
> ...
>> +    } else {
>> +        d_config->num_rdms = 0;
>> +    }
>
> Does this not override the domain configuration's num_rdms ?  I don't

We don't have the specific "num_rdms" parameter in .cfg so I don't 
understand what you mean here.

Thanks
Tiejun

> think that is correct.
>
> If the domain configuration has rdms and num_rdms already set, then
> the strategy should presumably be ignored.  (Passing the same domain
> configuration struct to libxl_domain_create_new, after destroying the
> domain, ought to work, even after the first call has modified it.)
>
>