Re: [Qemu-devel] [PATCH 09/10] qga: added bus type and disk location path

["Denis V. Lunev" <den@openvz.org>]

[-- Attachment #1: Type: text/plain, Size: 1759 bytes --]

On 07/20/2015 06:06 PM, Eric Blake wrote:
> On 07/06/2015 10:40 PM, Michael Roth wrote:
>> From: Olga Krishtal <okrishtal@virtuozzo.com>
>>
>> According to Microsoft disk location path can be obtained via
>> IOCTL_SCSI_GET_ADDRESS. Unfortunately this ioctl can not be used for all
>> devices. There are certain bus types which could be obtained with this
>> API. Please, refer to the following link for more details
>> https://technet.microsoft.com/en-us/library/ee851589(v=ws.10).aspx
>>
>> Bus type could be obtained using IOCTL_STORAGE_QUERY_PROPERTY. Enum
>> STORAGE_BUS_TYPE describes all buses supported by OS.
>>
>> Windows defines more bus types than Linux. Thus some values have been added
>> to GuestDiskBusType.
>>
>> Signed-off-by: Olga Krishtal <okrishtal@virtuozzo.com>
>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>> CC: Eric Blake <eblake@redhat.com>
>> CC: Michael Roth <mdroth@linux.vnet.ibm.com>
>> * fixed warning in CreateFile due to use of NULL instead of 0
>> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
>> ---
>> +++ b/qga/qapi-schema.json
>> @@ -703,12 +703,24 @@
>>   # @uml: UML disks
>>   # @sata: SATA disks
>>   # @sd: SD cards
>> +# @unknown: Unknown bus type
>> +# @ieee1394: Win IEEE 1394 bus type
>> +# @ssa: Win SSA bus type
>> +# @fibre: Win fiber channel bus type
>> +# @raid: Win RAID bus type
>> +# @iscsi: Win iScsi bus type
>> +# @sas: Win serial-attaches SCSI bus type
>> +# @mmc: Win multimedia card (MMC) bus type
>> +# @virtual: Win virtual bus type
>> +# @file-backed virtual: Win file-backed bus type
>>   #
>>   # Since: 2.2
> It would be nice to have a followup patch (since it is doc-only, it
> could still make 2.4) that mentions that all these new enum members were
> added in 2.4.
>
sure!

[-- Attachment #2: Type: text/html, Size: 2788 bytes --]