Re: [PATCH V3 10/10] [SCSI] aacraid: Replace pci_enable_msix() with pci_enable_msix_exact()

[Tomas Henzl <thenzl@redhat.com>]

On 8.7.2015 01:16, rajinikanth.pandurangan@pmcs.com wrote:
> From: Rajinikanth Pandurangan <rajinikanth.pandurangan@pmcs.com>
> 
> Description:
> 	As pci_enable_msix() deprecated, replaced with pci_enable_msix_exact()
> 
> Changes from V2:
>  Newly created for V3 based on review comment.
> 
> Signed-off-by: Rajinikanth Pandurangan <rajinikanth.pandurangan@pmcs.com>
> ---
>  drivers/scsi/aacraid/comminit.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

> 
> diff --git a/drivers/scsi/aacraid/comminit.c b/drivers/scsi/aacraid/comminit.c
> index b4b6088..e4ff47e 100644
> --- a/drivers/scsi/aacraid/comminit.c
> +++ b/drivers/scsi/aacraid/comminit.c
> @@ -366,7 +366,7 @@ void aac_define_int_mode(struct aac_dev *dev)
>  
>  	if (msi_count > 1 &&
>  	    pci_find_capability(dev->pdev, PCI_CAP_ID_MSIX)) {
> -		i = pci_enable_msix(dev->pdev,
> +		i = pci_enable_msix_exact(dev->pdev,
>  				    dev->msixentry,
>  				    msi_count);
>  		 /* Check how many MSIX vectors are allocated */
> @@ -374,7 +374,7 @@ void aac_define_int_mode(struct aac_dev *dev)
>  			dev->msi_enabled = 1;
>  			if (i) {
Hi Rajinikanth,
the pci_enable_msix_exact is not a 1;1 replacement for pci_enable_msix,
you shouldn't use it this way - it never returns a positive value.
What you probably want is to use pci_enable_msix_range

Cheers,
Tomas

>  				msi_count = i;
> -				if (pci_enable_msix(dev->pdev,
> +				if (pci_enable_msix_exact(dev->pdev,
>  				    dev->msixentry,
>  				    msi_count)) {
>  					dev->msi_enabled = 0;
>