From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47727) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHROl-0002Py-8D for qemu-devel@nongnu.org; Tue, 21 Jul 2015 02:51:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZHROg-00069U-9E for qemu-devel@nongnu.org; Tue, 21 Jul 2015 02:51:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51705) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHROg-00068X-3p for qemu-devel@nongnu.org; Tue, 21 Jul 2015 02:51:26 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id BDDB02B784F for ; Tue, 21 Jul 2015 06:51:24 +0000 (UTC) References: <1437370031-9070-1-git-send-email-pbonzini@redhat.com> <20150720074625.GA20738@ad.nay.redhat.com> <20150720100648.GA22650@ad.nay.redhat.com> <1108497253.1650856.1437396175024.JavaMail.zimbra@redhat.com> <20150721011953.GA1950@ad.nay.redhat.com> From: Paolo Bonzini Message-ID: <55ADEBE7.6020103@redhat.com> Date: Tue, 21 Jul 2015 08:51:19 +0200 MIME-Version: 1.0 In-Reply-To: <20150721011953.GA1950@ad.nay.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] AioContext: fix broken placement of event_notifier_test_and_clear List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, lersek@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, rjones@redhat.com On 21/07/2015 03:19, Fam Zheng wrote: > > Yes, that would work. I am not sure how complex it would be. You would also need > > a solution for the GSource and one (probably similar to aio-posix) for your > > epoll implementation. With ctx->notified at least you can encapsulate it in > > aio_notify_accept... > > Yes, I'll take this into consideration when I refactor for epoll > implementation. For now I think aio_notify_accept is cleaner. Ok, I'll wait for Stefan to pick up the unoptimized version, and then send v2 of aio_notify_accept. Paolo