From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Plattner Subject: Re: [PATCH] ALSA: hda - Add new GPU codec ID 0x10de007d to snd-hda Date: Tue, 21 Jul 2015 00:47:48 -0700 Message-ID: <55ADF924.5050401@nvidia.com> References: <1437437654-21375-1-git-send-email-aplattner@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Takashi Iwai Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On 07/21/2015 12:39 AM, Takashi Iwai wrote: > On Tue, 21 Jul 2015 02:14:14 +0200, > Aaron Plattner wrote: >> >> Vendor ID 0x10de007d is used by a yet-to-be-named GPU chip. >> >> Signed-off-by: Aaron Plattner > > Applied, thanks. But... > >> --- >> This chip also has the 2-ch audio swapping bug, so patch_nvhdmi is appropriate >> here. > > Please include such important information into the changelog itself at > the next time. I copied it manually. Oh, okay, sorry. I figured that since the whole point of patch_nvhdmi is the 2ch workaround, it should be obvious from context but it certainly can't hurt to have it in the commit itself too. Thanks for taking care of it! Sincerely, Aaron > Takashi > >> >> sound/pci/hda/patch_hdmi.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c >> index 95158914cc6c..a97db5fc8a15 100644 >> --- a/sound/pci/hda/patch_hdmi.c >> +++ b/sound/pci/hda/patch_hdmi.c >> @@ -3512,6 +3512,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = { >> { .id = 0x10de0070, .name = "GPU 70 HDMI/DP", .patch = patch_nvhdmi }, >> { .id = 0x10de0071, .name = "GPU 71 HDMI/DP", .patch = patch_nvhdmi }, >> { .id = 0x10de0072, .name = "GPU 72 HDMI/DP", .patch = patch_nvhdmi }, >> +{ .id = 0x10de007d, .name = "GPU 7d HDMI/DP", .patch = patch_nvhdmi }, >> { .id = 0x10de8001, .name = "MCP73 HDMI", .patch = patch_nvhdmi_2ch }, >> { .id = 0x11069f80, .name = "VX900 HDMI/DP", .patch = patch_via_hdmi }, >> { .id = 0x11069f81, .name = "VX900 HDMI/DP", .patch = patch_via_hdmi }, >> @@ -3576,6 +3577,7 @@ MODULE_ALIAS("snd-hda-codec-id:10de0067"); >> MODULE_ALIAS("snd-hda-codec-id:10de0070"); >> MODULE_ALIAS("snd-hda-codec-id:10de0071"); >> MODULE_ALIAS("snd-hda-codec-id:10de0072"); >> +MODULE_ALIAS("snd-hda-codec-id:10de007d"); >> MODULE_ALIAS("snd-hda-codec-id:10de8001"); >> MODULE_ALIAS("snd-hda-codec-id:11069f80"); >> MODULE_ALIAS("snd-hda-codec-id:11069f81"); >> -- >> 2.4.6 >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752504AbbGUHru (ORCPT ); Tue, 21 Jul 2015 03:47:50 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:15150 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751236AbbGUHrt (ORCPT ); Tue, 21 Jul 2015 03:47:49 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Tue, 21 Jul 2015 00:46:18 -0700 Subject: Re: [PATCH] ALSA: hda - Add new GPU codec ID 0x10de007d to snd-hda To: Takashi Iwai References: <1437437654-21375-1-git-send-email-aplattner@nvidia.com> CC: Jaroslav Kysela , , X-Nvconfidentiality: public From: Aaron Plattner Message-ID: <55ADF924.5050401@nvidia.com> Date: Tue, 21 Jul 2015 00:47:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/21/2015 12:39 AM, Takashi Iwai wrote: > On Tue, 21 Jul 2015 02:14:14 +0200, > Aaron Plattner wrote: >> >> Vendor ID 0x10de007d is used by a yet-to-be-named GPU chip. >> >> Signed-off-by: Aaron Plattner > > Applied, thanks. But... > >> --- >> This chip also has the 2-ch audio swapping bug, so patch_nvhdmi is appropriate >> here. > > Please include such important information into the changelog itself at > the next time. I copied it manually. Oh, okay, sorry. I figured that since the whole point of patch_nvhdmi is the 2ch workaround, it should be obvious from context but it certainly can't hurt to have it in the commit itself too. Thanks for taking care of it! Sincerely, Aaron > Takashi > >> >> sound/pci/hda/patch_hdmi.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c >> index 95158914cc6c..a97db5fc8a15 100644 >> --- a/sound/pci/hda/patch_hdmi.c >> +++ b/sound/pci/hda/patch_hdmi.c >> @@ -3512,6 +3512,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = { >> { .id = 0x10de0070, .name = "GPU 70 HDMI/DP", .patch = patch_nvhdmi }, >> { .id = 0x10de0071, .name = "GPU 71 HDMI/DP", .patch = patch_nvhdmi }, >> { .id = 0x10de0072, .name = "GPU 72 HDMI/DP", .patch = patch_nvhdmi }, >> +{ .id = 0x10de007d, .name = "GPU 7d HDMI/DP", .patch = patch_nvhdmi }, >> { .id = 0x10de8001, .name = "MCP73 HDMI", .patch = patch_nvhdmi_2ch }, >> { .id = 0x11069f80, .name = "VX900 HDMI/DP", .patch = patch_via_hdmi }, >> { .id = 0x11069f81, .name = "VX900 HDMI/DP", .patch = patch_via_hdmi }, >> @@ -3576,6 +3577,7 @@ MODULE_ALIAS("snd-hda-codec-id:10de0067"); >> MODULE_ALIAS("snd-hda-codec-id:10de0070"); >> MODULE_ALIAS("snd-hda-codec-id:10de0071"); >> MODULE_ALIAS("snd-hda-codec-id:10de0072"); >> +MODULE_ALIAS("snd-hda-codec-id:10de007d"); >> MODULE_ALIAS("snd-hda-codec-id:10de8001"); >> MODULE_ALIAS("snd-hda-codec-id:11069f80"); >> MODULE_ALIAS("snd-hda-codec-id:11069f81"); >> -- >> 2.4.6 >>