* [PATCH] ALSA: hda - Add new GPU codec ID 0x10de007d to snd-hda
@ 2015-07-21 0:14 Aaron Plattner
2015-07-21 7:39 ` Takashi Iwai
0 siblings, 1 reply; 5+ messages in thread
From: Aaron Plattner @ 2015-07-21 0:14 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai; +Cc: Aaron Plattner, alsa-devel, linux-kernel
Vendor ID 0x10de007d is used by a yet-to-be-named GPU chip.
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
---
This chip also has the 2-ch audio swapping bug, so patch_nvhdmi is appropriate
here.
sound/pci/hda/patch_hdmi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index 95158914cc6c..a97db5fc8a15 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -3512,6 +3512,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
{ .id = 0x10de0070, .name = "GPU 70 HDMI/DP", .patch = patch_nvhdmi },
{ .id = 0x10de0071, .name = "GPU 71 HDMI/DP", .patch = patch_nvhdmi },
{ .id = 0x10de0072, .name = "GPU 72 HDMI/DP", .patch = patch_nvhdmi },
+{ .id = 0x10de007d, .name = "GPU 7d HDMI/DP", .patch = patch_nvhdmi },
{ .id = 0x10de8001, .name = "MCP73 HDMI", .patch = patch_nvhdmi_2ch },
{ .id = 0x11069f80, .name = "VX900 HDMI/DP", .patch = patch_via_hdmi },
{ .id = 0x11069f81, .name = "VX900 HDMI/DP", .patch = patch_via_hdmi },
@@ -3576,6 +3577,7 @@ MODULE_ALIAS("snd-hda-codec-id:10de0067");
MODULE_ALIAS("snd-hda-codec-id:10de0070");
MODULE_ALIAS("snd-hda-codec-id:10de0071");
MODULE_ALIAS("snd-hda-codec-id:10de0072");
+MODULE_ALIAS("snd-hda-codec-id:10de007d");
MODULE_ALIAS("snd-hda-codec-id:10de8001");
MODULE_ALIAS("snd-hda-codec-id:11069f80");
MODULE_ALIAS("snd-hda-codec-id:11069f81");
--
2.4.6
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ALSA: hda - Add new GPU codec ID 0x10de007d to snd-hda
2015-07-21 0:14 [PATCH] ALSA: hda - Add new GPU codec ID 0x10de007d to snd-hda Aaron Plattner
@ 2015-07-21 7:39 ` Takashi Iwai
0 siblings, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2015-07-21 7:39 UTC (permalink / raw)
To: Aaron Plattner; +Cc: Jaroslav Kysela, alsa-devel, linux-kernel
On Tue, 21 Jul 2015 02:14:14 +0200,
Aaron Plattner wrote:
>
> Vendor ID 0x10de007d is used by a yet-to-be-named GPU chip.
>
> Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
Applied, thanks. But...
> ---
> This chip also has the 2-ch audio swapping bug, so patch_nvhdmi is appropriate
> here.
Please include such important information into the changelog itself at
the next time. I copied it manually.
Takashi
>
> sound/pci/hda/patch_hdmi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
> index 95158914cc6c..a97db5fc8a15 100644
> --- a/sound/pci/hda/patch_hdmi.c
> +++ b/sound/pci/hda/patch_hdmi.c
> @@ -3512,6 +3512,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
> { .id = 0x10de0070, .name = "GPU 70 HDMI/DP", .patch = patch_nvhdmi },
> { .id = 0x10de0071, .name = "GPU 71 HDMI/DP", .patch = patch_nvhdmi },
> { .id = 0x10de0072, .name = "GPU 72 HDMI/DP", .patch = patch_nvhdmi },
> +{ .id = 0x10de007d, .name = "GPU 7d HDMI/DP", .patch = patch_nvhdmi },
> { .id = 0x10de8001, .name = "MCP73 HDMI", .patch = patch_nvhdmi_2ch },
> { .id = 0x11069f80, .name = "VX900 HDMI/DP", .patch = patch_via_hdmi },
> { .id = 0x11069f81, .name = "VX900 HDMI/DP", .patch = patch_via_hdmi },
> @@ -3576,6 +3577,7 @@ MODULE_ALIAS("snd-hda-codec-id:10de0067");
> MODULE_ALIAS("snd-hda-codec-id:10de0070");
> MODULE_ALIAS("snd-hda-codec-id:10de0071");
> MODULE_ALIAS("snd-hda-codec-id:10de0072");
> +MODULE_ALIAS("snd-hda-codec-id:10de007d");
> MODULE_ALIAS("snd-hda-codec-id:10de8001");
> MODULE_ALIAS("snd-hda-codec-id:11069f80");
> MODULE_ALIAS("snd-hda-codec-id:11069f81");
> --
> 2.4.6
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ALSA: hda - Add new GPU codec ID 0x10de007d to snd-hda
@ 2015-07-21 7:39 ` Takashi Iwai
0 siblings, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2015-07-21 7:39 UTC (permalink / raw)
To: Aaron Plattner; +Cc: Jaroslav Kysela, alsa-devel, linux-kernel
On Tue, 21 Jul 2015 02:14:14 +0200,
Aaron Plattner wrote:
>
> Vendor ID 0x10de007d is used by a yet-to-be-named GPU chip.
>
> Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
Applied, thanks. But...
> ---
> This chip also has the 2-ch audio swapping bug, so patch_nvhdmi is appropriate
> here.
Please include such important information into the changelog itself at
the next time. I copied it manually.
Takashi
>
> sound/pci/hda/patch_hdmi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
> index 95158914cc6c..a97db5fc8a15 100644
> --- a/sound/pci/hda/patch_hdmi.c
> +++ b/sound/pci/hda/patch_hdmi.c
> @@ -3512,6 +3512,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
> { .id = 0x10de0070, .name = "GPU 70 HDMI/DP", .patch = patch_nvhdmi },
> { .id = 0x10de0071, .name = "GPU 71 HDMI/DP", .patch = patch_nvhdmi },
> { .id = 0x10de0072, .name = "GPU 72 HDMI/DP", .patch = patch_nvhdmi },
> +{ .id = 0x10de007d, .name = "GPU 7d HDMI/DP", .patch = patch_nvhdmi },
> { .id = 0x10de8001, .name = "MCP73 HDMI", .patch = patch_nvhdmi_2ch },
> { .id = 0x11069f80, .name = "VX900 HDMI/DP", .patch = patch_via_hdmi },
> { .id = 0x11069f81, .name = "VX900 HDMI/DP", .patch = patch_via_hdmi },
> @@ -3576,6 +3577,7 @@ MODULE_ALIAS("snd-hda-codec-id:10de0067");
> MODULE_ALIAS("snd-hda-codec-id:10de0070");
> MODULE_ALIAS("snd-hda-codec-id:10de0071");
> MODULE_ALIAS("snd-hda-codec-id:10de0072");
> +MODULE_ALIAS("snd-hda-codec-id:10de007d");
> MODULE_ALIAS("snd-hda-codec-id:10de8001");
> MODULE_ALIAS("snd-hda-codec-id:11069f80");
> MODULE_ALIAS("snd-hda-codec-id:11069f81");
> --
> 2.4.6
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ALSA: hda - Add new GPU codec ID 0x10de007d to snd-hda
2015-07-21 7:39 ` Takashi Iwai
@ 2015-07-21 7:47 ` Aaron Plattner
-1 siblings, 0 replies; 5+ messages in thread
From: Aaron Plattner @ 2015-07-21 7:47 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Jaroslav Kysela, alsa-devel, linux-kernel
On 07/21/2015 12:39 AM, Takashi Iwai wrote:
> On Tue, 21 Jul 2015 02:14:14 +0200,
> Aaron Plattner wrote:
>>
>> Vendor ID 0x10de007d is used by a yet-to-be-named GPU chip.
>>
>> Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
>
> Applied, thanks. But...
>
>> ---
>> This chip also has the 2-ch audio swapping bug, so patch_nvhdmi is appropriate
>> here.
>
> Please include such important information into the changelog itself at
> the next time. I copied it manually.
Oh, okay, sorry. I figured that since the whole point of patch_nvhdmi
is the 2ch workaround, it should be obvious from context but it
certainly can't hurt to have it in the commit itself too. Thanks for
taking care of it!
Sincerely,
Aaron
> Takashi
>
>>
>> sound/pci/hda/patch_hdmi.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
>> index 95158914cc6c..a97db5fc8a15 100644
>> --- a/sound/pci/hda/patch_hdmi.c
>> +++ b/sound/pci/hda/patch_hdmi.c
>> @@ -3512,6 +3512,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
>> { .id = 0x10de0070, .name = "GPU 70 HDMI/DP", .patch = patch_nvhdmi },
>> { .id = 0x10de0071, .name = "GPU 71 HDMI/DP", .patch = patch_nvhdmi },
>> { .id = 0x10de0072, .name = "GPU 72 HDMI/DP", .patch = patch_nvhdmi },
>> +{ .id = 0x10de007d, .name = "GPU 7d HDMI/DP", .patch = patch_nvhdmi },
>> { .id = 0x10de8001, .name = "MCP73 HDMI", .patch = patch_nvhdmi_2ch },
>> { .id = 0x11069f80, .name = "VX900 HDMI/DP", .patch = patch_via_hdmi },
>> { .id = 0x11069f81, .name = "VX900 HDMI/DP", .patch = patch_via_hdmi },
>> @@ -3576,6 +3577,7 @@ MODULE_ALIAS("snd-hda-codec-id:10de0067");
>> MODULE_ALIAS("snd-hda-codec-id:10de0070");
>> MODULE_ALIAS("snd-hda-codec-id:10de0071");
>> MODULE_ALIAS("snd-hda-codec-id:10de0072");
>> +MODULE_ALIAS("snd-hda-codec-id:10de007d");
>> MODULE_ALIAS("snd-hda-codec-id:10de8001");
>> MODULE_ALIAS("snd-hda-codec-id:11069f80");
>> MODULE_ALIAS("snd-hda-codec-id:11069f81");
>> --
>> 2.4.6
>>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ALSA: hda - Add new GPU codec ID 0x10de007d to snd-hda
@ 2015-07-21 7:47 ` Aaron Plattner
0 siblings, 0 replies; 5+ messages in thread
From: Aaron Plattner @ 2015-07-21 7:47 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Jaroslav Kysela, alsa-devel, linux-kernel
On 07/21/2015 12:39 AM, Takashi Iwai wrote:
> On Tue, 21 Jul 2015 02:14:14 +0200,
> Aaron Plattner wrote:
>>
>> Vendor ID 0x10de007d is used by a yet-to-be-named GPU chip.
>>
>> Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
>
> Applied, thanks. But...
>
>> ---
>> This chip also has the 2-ch audio swapping bug, so patch_nvhdmi is appropriate
>> here.
>
> Please include such important information into the changelog itself at
> the next time. I copied it manually.
Oh, okay, sorry. I figured that since the whole point of patch_nvhdmi
is the 2ch workaround, it should be obvious from context but it
certainly can't hurt to have it in the commit itself too. Thanks for
taking care of it!
Sincerely,
Aaron
> Takashi
>
>>
>> sound/pci/hda/patch_hdmi.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
>> index 95158914cc6c..a97db5fc8a15 100644
>> --- a/sound/pci/hda/patch_hdmi.c
>> +++ b/sound/pci/hda/patch_hdmi.c
>> @@ -3512,6 +3512,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
>> { .id = 0x10de0070, .name = "GPU 70 HDMI/DP", .patch = patch_nvhdmi },
>> { .id = 0x10de0071, .name = "GPU 71 HDMI/DP", .patch = patch_nvhdmi },
>> { .id = 0x10de0072, .name = "GPU 72 HDMI/DP", .patch = patch_nvhdmi },
>> +{ .id = 0x10de007d, .name = "GPU 7d HDMI/DP", .patch = patch_nvhdmi },
>> { .id = 0x10de8001, .name = "MCP73 HDMI", .patch = patch_nvhdmi_2ch },
>> { .id = 0x11069f80, .name = "VX900 HDMI/DP", .patch = patch_via_hdmi },
>> { .id = 0x11069f81, .name = "VX900 HDMI/DP", .patch = patch_via_hdmi },
>> @@ -3576,6 +3577,7 @@ MODULE_ALIAS("snd-hda-codec-id:10de0067");
>> MODULE_ALIAS("snd-hda-codec-id:10de0070");
>> MODULE_ALIAS("snd-hda-codec-id:10de0071");
>> MODULE_ALIAS("snd-hda-codec-id:10de0072");
>> +MODULE_ALIAS("snd-hda-codec-id:10de007d");
>> MODULE_ALIAS("snd-hda-codec-id:10de8001");
>> MODULE_ALIAS("snd-hda-codec-id:11069f80");
>> MODULE_ALIAS("snd-hda-codec-id:11069f81");
>> --
>> 2.4.6
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-07-21 7:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-21 0:14 [PATCH] ALSA: hda - Add new GPU codec ID 0x10de007d to snd-hda Aaron Plattner
2015-07-21 7:39 ` Takashi Iwai
2015-07-21 7:39 ` Takashi Iwai
2015-07-21 7:47 ` Aaron Plattner
2015-07-21 7:47 ` Aaron Plattner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.