From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Bob Liu <bob.liu@oracle.com>, <xen-devel@lists.xenproject.org>
Cc: <david.vrabel@citrix.com>, <linux-kernel@vger.kernel.org>,
<konrad.wilk@oracle.com>
Subject: Re: [PATCH 2/3] xen-blkfront: rm BUG_ON(info->feature_persistent) in blkif_free
Date: Tue, 21 Jul 2015 11:25:45 +0200 [thread overview]
Message-ID: <55AE1019.6080906@citrix.com> (raw)
In-Reply-To: <1437449441-2964-2-git-send-email-bob.liu@oracle.com>
El 21/07/15 a les 5.30, Bob Liu ha escrit:
> This BUG_ON() in blkif_free() is incorrect, because indirect page can be added
> to list info->indirect_pages in blkif_completion() no matter feature_persistent
> is true or false.
>
> Signed-off-by: Bob Liu <bob.liu@oracle.com>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
This was probably an oversight from when blkif_completion was changed to
check for gnttab_query_foreign_access. It should be backported to stable
trees.
Roger.
next prev parent reply other threads:[~2015-07-21 9:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 3:30 [PATCH 1/3] xen-blkfront: introduce blkfront_gather_backend_features() Bob Liu
2015-07-21 3:30 ` [PATCH 2/3] xen-blkfront: rm BUG_ON(info->feature_persistent) in blkif_free Bob Liu
2015-07-21 9:25 ` Roger Pau Monné [this message]
2015-07-22 4:43 ` Bob Liu
2015-07-22 5:34 ` Bob Liu
2015-07-22 5:34 ` Bob Liu
2015-07-22 4:43 ` Bob Liu
2015-07-21 9:25 ` Roger Pau Monné
2015-07-21 3:30 ` Bob Liu
2015-07-21 3:30 ` [PATCH 3/3] xen-blkback: rm BUG_ON() in purge_persistent_gnt() Bob Liu
2015-07-21 3:30 ` Bob Liu
2015-07-21 9:13 ` Roger Pau Monné
2015-07-21 9:13 ` Roger Pau Monné
2015-07-21 10:50 ` Bob Liu
2015-07-21 10:50 ` Bob Liu
2015-07-21 9:32 ` [PATCH 1/3] xen-blkfront: introduce blkfront_gather_backend_features() Roger Pau Monné
2015-07-21 9:32 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AE1019.6080906@citrix.com \
--to=roger.pau@citrix.com \
--cc=bob.liu@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.