From: Daniel Borkmann <daniel@iogearbox.net>
To: Alexei Starovoitov <ast@plumgrid.com>
Cc: Alex Gartrell <alexgartrell@gmail.com>, netdev <netdev@vger.kernel.org>
Subject: Re: Why return E2BIG from bpf map update?
Date: Tue, 21 Jul 2015 11:40:04 +0200 [thread overview]
Message-ID: <55AE1374.6010608@iogearbox.net> (raw)
In-Reply-To: <55AD7514.7040906@plumgrid.com>
On 07/21/2015 12:24 AM, Alexei Starovoitov wrote:
> On 7/20/15 3:15 PM, Alex Gartrell wrote:
>> The ship has probably sailed on this one, but it seems like ENOSPC
>> makes more sense than E2BIG. Any chance of changing it so that poor
>> ebpf library maintainers in the future don't have to wonder how their
>> argument list got too big?
>
> sorry, too late.
> It's in tests and even document in bpf manpage:
> "E2BIG - indicates that the number of elements in the map reached the
> max_entries limit specified at map creation time."
> I read E2BIG as "too big" and not as "argument list is too long" :)
If some libraries do an strerror(3) on errno then it certainly sounds
a bit weird, "no space left on device" perhaps also a bit misleading.
The bpf(2) manpage was actually submitted/discussed longer time ago,
but I still didn't see it in Michael's tree yet, will ping him again.
next prev parent reply other threads:[~2015-07-21 9:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 22:15 Why return E2BIG from bpf map update? Alex Gartrell
2015-07-20 22:24 ` Alexei Starovoitov
2015-07-21 9:40 ` Daniel Borkmann [this message]
2015-07-21 10:13 ` Alex Gartrell
2015-07-21 21:34 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AE1374.6010608@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=alexgartrell@gmail.com \
--cc=ast@plumgrid.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.