From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [Xen-Devel] Enabling IRQ Crossbar (Secondary Interrupt Controller) Support Date: Tue, 21 Jul 2015 10:41:21 +0100 Message-ID: <55AE13C1.1060507@citrix.com> References: <55AD817E.6020300@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <55AD817E.6020300@ti.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Brandon Perez , xen-devel@lists.xen.org Cc: Ian Campbell , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 21/07/2015 00:17, Brandon Perez wrote: > Hello All, Hi Brandon, We use to send one mail by patch rather than sending them as an attachment of a single email. It's easier for reviewing the patches. You also need to add you Signed-off-by on each patch and CC all the relevant maintainers. Please see [1] for all the guidelines to submit a patch to Xen. A couple of comments I about this series: - Patch #2: You are allowing any guest to do smc which, unless you trust all the guest, is unsecure. There was some discussion about different solution to handle SMC back in 2013 [2]. So far I didn't see any more update on it. It may be worth to send a separate thread about how to handle SMC. - Patch #3, I can't find any documentation or implementation of the property "default-mapping" in Linux. Can you provide a link about it? I will comment more when you will resend the patches inline. Regards, [1] http://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches [2] http://lists.xen.org/archives/html/xen-devel/2013-07/msg02779.html -- Julien Grall