From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Chen, Tiejun" <tiejun.chen@intel.com>
Subject: Re: [v10][PATCH 11/16] tools/libxl: detect and avoid
 conflicts with RDM
Date: Tue, 21 Jul 2015 19:12:51 +0800
Message-ID: <55AE2933.2010009@intel.com>
References: <1437373023-14884-1-git-send-email-tiejun.chen@intel.com>
	<1437373023-14884-12-git-send-email-tiejun.chen@intel.com>
	<21932.63595.566823.211293@mariner.uk.xensource.com>
	<55ADE8FC.1050700@intel.com>
	<21934.9089.947673.654067@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21934.9089.947673.654067@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

>> +static void
>> +add_rdm_entry(libxl__gc *gc, libxl_domain_config *d_config,
>> +              uint64_t rdm_start, uint64_t rdm_size, int rdm_policy)
>> +{
>> +    assert(d_config->num_rdms);
>> +
>> +    d_config->rdms = libxl__realloc(NOGC, d_config->rdms,
>> +                            d_config->num_rdms * sizeof(libxl_device_rdm));
>> +
>> +    d_config->rdms[d_config->num_rdms - 1].start = rdm_start;
>> +    d_config->rdms[d_config->num_rdms - 1].size = rdm_size;
>> +    d_config->rdms[d_config->num_rdms - 1].policy = rdm_policy;
>> +}
>
> But, I wrote:
>
>     Can I suggest a function
>
>        void add_rdm_entry(libxl__gc *gc, libxl_domain_config *d_config,
>                      uint64_t rdm_start, uint64_t rdm_size, int rdm_policy)
>
>     which assumes that d_config->num_rdms is set correctly, and increments
>     it ?
>
>     (Please put the increment at the end so that the assignments are to
>     ->rdms[d_config->num_rdms], or perhaps make a convenience alias.)
>
> Did you not notice that both call sites for add_rdm_entry are preceded
> by the increment ?  As I wrote earlier:
>
>     Finding multiple occurrences of very similar code is usually a sign
>     that refactoring is needed.

Sorry I should make this better.

So I just need to move increment into the callee like this?

static void
add_rdm_entry(libxl__gc *gc, libxl_domain_config *d_config,
               uint64_t rdm_start, uint64_t rdm_size, int rdm_policy)
{
     d_config->num_rdms++;
     d_config->rdms = libxl__realloc(NOGC, d_config->rdms,
                             d_config->num_rdms * sizeof(libxl_device_rdm));

     d_config->rdms[d_config->num_rdms - 1].start = rdm_start;
     d_config->rdms[d_config->num_rdms - 1].size = rdm_size;
     d_config->rdms[d_config->num_rdms - 1].policy = rdm_policy;
}

>
>
> See also my other mail about the handling of existing rdms with
> strategy=host.
>

I also replied there.

Thanks
Tiejun