All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann Cantin <yann.cantin@laposte.net>
To: Oliver Neukum <oneukum@suse.com>
Cc: linux-input@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
	dmitry.torokhov@gmail.com, jkosina@suse.cz,
	gregkh@linuxfoundation.org
Subject: Re: [RFC ebeam PATCH 2/2] input: misc: New USB eBeam input driver
Date: Tue, 21 Jul 2015 14:38:37 +0200	[thread overview]
Message-ID: <55AE3D4D.2040706@laposte.net> (raw)
In-Reply-To: <1437466763.3823.1.camel@suse.com>

Hi,

Le 21/07/2015 10:19, Oliver Neukum a écrit :
> On Mon, 2015-07-20 at 23:03 +0200, Yann Cantin wrote:

>> diff --git a/drivers/input/misc/ebeam.c b/drivers/input/misc/ebeam.c
>> new file mode 100644
>> index 0000000..79cac51
>> --- /dev/null
>> +++ b/drivers/input/misc/ebeam.c

>> +/* Electronics For Imaging, Inc */
>> +#define USB_VENDOR_ID_EFI	0x2650
>
> You are defining these IDs twice. That is not good.

Is it okay to do this :

#if !defined(CONFIG_INPUT_EBEAM_USB)
#define USB_VENDOR_ID_EFI	0x2650
#...
#endif

so that the driver can also be build outside the kernel tree ?

thanks,

-- 
Yann Cantin
A4FEB47F
--

  reply	other threads:[~2015-07-21 12:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-20 21:03 [RFC ebeam PATCH 0/3] new USB eBeam input driver Yann Cantin
2015-07-20 21:03 ` Yann Cantin
     [not found] ` <1437426199-29866-1-git-send-email-yann.cantin-QFKgK+z4sOrR7s880joybQ@public.gmane.org>
2015-07-20 21:03   ` [RFC ebeam PATCH 1/2] hid: Blacklist eBeam devices Yann Cantin
2015-07-20 21:03     ` Yann Cantin
2015-07-20 21:03 ` [RFC ebeam PATCH 2/2] input: misc: New USB eBeam input driver Yann Cantin
2015-07-20 21:59   ` Greg KH
2015-07-20 22:26     ` Dmitry Torokhov
2015-07-20 22:40       ` Greg KH
2015-07-20 23:09         ` Dmitry Torokhov
     [not found]         ` <20150720224033.GA23884-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-07-21 13:54           ` Yann Cantin
2015-07-21 13:54             ` Yann Cantin
     [not found]     ` <20150720215956.GA21796-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-07-21 12:18       ` Yann Cantin
2015-07-21 12:18         ` Yann Cantin
     [not found]   ` <1437426199-29866-3-git-send-email-yann.cantin-QFKgK+z4sOrR7s880joybQ@public.gmane.org>
2015-07-21  8:19     ` Oliver Neukum
2015-07-21  8:19       ` Oliver Neukum
2015-07-21 12:38       ` Yann Cantin [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-07-24 23:52 [RFC ebeam PATCH 0/2] new " Yann Cantin
2013-07-24 23:52 ` [RFC ebeam PATCH 2/2] input: misc: New " Yann Cantin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55AE3D4D.2040706@laposte.net \
    --to=yann.cantin@laposte.net \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jkosina@suse.cz \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oneukum@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.