From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Szyprowski Subject: Re: [PATCHv7 14/15] cec: s5p-cec: Add s5p-cec driver Date: Tue, 21 Jul 2015 15:03:06 +0200 Message-ID: <55AE430A.8040300@samsung.com> References: <1435572900-56998-1-git-send-email-hans.verkuil@cisco.com> <1435572900-56998-15-git-send-email-hans.verkuil@cisco.com> <55A7AD20.3080703@xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <55A7AD20.3080703@xs4all.nl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Hans Verkuil , Hans Verkuil , linux-media@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org, sean@mess.org, dmitry.torokhov@gmail.com, lars@opdenkamp.eu, dri-devel@lists.freedesktop.org, kamil@wypas.org, kyungmin.park@samsung.com, thomas@tommie-lie.de, linux-input@vger.kernel.org List-Id: linux-input@vger.kernel.org SGVsbG8sCgpPbiAyMDE1LTA3LTE2IDE1OjA5LCBIYW5zIFZlcmt1aWwgd3JvdGU6Cj4gTWFyZWss IEthbWlsLAo+Cj4gT24gMDYvMjkvMTUgMTI6MTQsIEhhbnMgVmVya3VpbCB3cm90ZToKPj4gRnJv bTogS2FtaWwgRGVic2tpIDxrYW1pbEB3eXBhcy5vcmc+Cj4+Cj4+IEFkZCBDRUMgaW50ZXJmYWNl IGRyaXZlciBwcmVzZW50IGluIHRoZSBTYW1zdW5nIEV4eW5vcyByYW5nZSBvZgo+PiBTb0NzLgo+ Pgo+PiBUaGUgZm9sbG93aW5nIGZpbGVzIHdlcmUgYmFzZWQgb24gd29yayBieSBTYW5nUGlsIE1v b246Cj4+IC0gZXh5bm9zX2hkbWlfY2VjLmgKPj4gLSBleHlub3NfaGRtaV9jZWNjdGwuYwo+Pgo+ PiBTaWduZWQtb2ZmLWJ5OiBLYW1pbCBEZWJza2kgPGthbWlsQHd5cGFzLm9yZz4KPj4gU2lnbmVk LW9mZi1ieTogSGFucyBWZXJrdWlsIDxoYW5zLnZlcmt1aWxAY2lzY28uY29tPgo+PiAtLS0KPiA8 c25pcD4KPgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9zNXAtY2VjL3M1 cF9jZWMuYyBiL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vczVwLWNlYy9zNXBfY2VjLmMKPj4gbmV3 IGZpbGUgbW9kZSAxMDA2NDQKPj4gaW5kZXggMDAwMDAwMC4uMGYxNmQwMAo+PiAtLS0gL2Rldi9u dWxsCj4+ICsrKyBiL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vczVwLWNlYy9zNXBfY2VjLmMKPj4g QEAgLTAsMCArMSwyODMgQEAKPj4gKy8qIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vczVwLWNlYy9z NXBfY2VjLmMKPj4gKyAqCj4+ICsgKiBTYW1zdW5nIFM1UCBDRUMgZHJpdmVyCj4+ICsgKgo+PiAr ICogQ29weXJpZ2h0IChjKSAyMDE0IFNhbXN1bmcgRWxlY3Ryb25pY3MgQ28uLCBMdGQuCj4+ICsg Kgo+PiArICogVGhpcyBwcm9ncmFtIGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmli dXRlIGl0IGFuZC9vciBtb2RpZnkKPj4gKyAqIGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05V IEdlbmVyYWwgUHVibGljIExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5Cj4+ICsgKiB0aGUgRnJlZSBT b2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIgdmVyc2lvbiAyIG9mIHRoZSBMaWNlbnNlLCBvcgo+ PiArICogKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4KPj4gKyAqCj4+ICsgKiBU aGlzIGRyaXZlciBpcyBiYXNlZCBvbiB0aGUgImNlYyBpbnRlcmZhY2UgZHJpdmVyIGZvciBleHlu b3Mgc29jIiBieQo+PiArICogU2FuZ1BpbCBNb29uLgo+PiArICovCj4+ICsKPj4gKyNpbmNsdWRl IDxsaW51eC9jbGsuaD4KPj4gKyNpbmNsdWRlIDxsaW51eC9pbnRlcnJ1cHQuaD4KPj4gKyNpbmNs dWRlIDxsaW51eC9rZXJuZWwuaD4KPj4gKyNpbmNsdWRlIDxsaW51eC9tZmQvc3lzY29uLmg+Cj4+ ICsjaW5jbHVkZSA8bGludXgvbW9kdWxlLmg+Cj4+ICsjaW5jbHVkZSA8bGludXgvb2YuaD4KPj4g KyNpbmNsdWRlIDxsaW51eC9wbGF0Zm9ybV9kZXZpY2UuaD4KPj4gKyNpbmNsdWRlIDxsaW51eC9w bV9ydW50aW1lLmg+Cj4+ICsjaW5jbHVkZSA8bGludXgvdGltZXIuaD4KPj4gKyNpbmNsdWRlIDxs aW51eC92ZXJzaW9uLmg+Cj4+ICsjaW5jbHVkZSA8bGludXgvd29ya3F1ZXVlLmg+Cj4+ICsjaW5j bHVkZSA8bWVkaWEvY2VjLmg+Cj4+ICsKPj4gKyNpbmNsdWRlICJleHlub3NfaGRtaV9jZWMuaCIK Pj4gKyNpbmNsdWRlICJyZWdzLWNlYy5oIgo+PiArI2luY2x1ZGUgInM1cF9jZWMuaCIKPj4gKwo+ PiArI2RlZmluZSBDRUNfTkFNRQkiczVwLWNlYyIKPj4gKwo+PiArc3RhdGljIGludCBkZWJ1ZzsK Pj4gK21vZHVsZV9wYXJhbShkZWJ1ZywgaW50LCAwNjQ0KTsKPj4gK01PRFVMRV9QQVJNX0RFU0Mo ZGVidWcsICJkZWJ1ZyBsZXZlbCAoMC0yKSIpOwo+PiArCj4+ICtzdGF0aWMgaW50IHM1cF9jZWNf ZW5hYmxlKHN0cnVjdCBjZWNfYWRhcHRlciAqYWRhcCwgYm9vbCBlbmFibGUpCj4+ICt7Cj4+ICsJ c3RydWN0IHM1cF9jZWNfZGV2ICpjZWMgPSBjb250YWluZXJfb2YoYWRhcCwgc3RydWN0IHM1cF9j ZWNfZGV2LCBhZGFwKTsKPj4gKwlpbnQgcmV0Owo+PiArCj4+ICsJaWYgKGVuYWJsZSkgewo+PiAr CQlyZXQgPSBwbV9ydW50aW1lX2dldF9zeW5jKGNlYy0+ZGV2KTsKPj4gKwo+PiArCQlhZGFwLT5w aHlzX2FkZHIgPSAweDEwMGI7Cj4gVGhpcyBpcyBhIGJvZ3VzIHBoeXNpY2FsIGFkZHJlc3MuIFRo ZSBhY3R1YWwgcGh5c2ljYWwgYWRkcmVzcyBoYXMgdG8gYmUgZGVyaXZlZAo+IGZyb20gdGhlIEVE SUQgdGhhdCBpcyByZWFkIGJ5IHRoZSBIRE1JIHRyYW5zbWl0dGVyLgo+Cj4gSSB0aGluayBpbiB0 aGUgY2FzZSBvZiB0aGlzIGRyaXZlciBpdCB3aWxsIGhhdmUgdG8gYmUgdXNlcnNwYWNlIHRoYXQg YXNzaWducwo+IHRoZSBwaHlzaWNhbCBhZGRyZXNzIGFmdGVyIHJlYWRpbmcgdGhlIEVESUQgZnJv bSBkcm0va21zPwo+Cj4gSG93IGRpZCB5b3UgdGVzdCB0aGlzLCBLYW1pbD8KCklmIEkgcmVtZW1i ZXIgY29ycmVjdGx5LCBwaHlzaWNhbCBhZGRyZXNzIGhhcyBiZWVuIGRlcml2ZWQgZnJvbSBFRElE IGluIHRoZQp1c2Vyc3BhY2UgKGl0IGlzIGF2YWlsYWJsZSBpbiAvc3lzL2NsYXNzL2RybS8qKSBh bmQgcGFzc2VkIHRvIHM1cC1jZWMgCmRyaXZlciBieQphcHByb3ByaWF0ZSBpb2N0bC4KCkkgZG9u J3Qga25vdyB3aGF0IGlzIHRoZSByZWFzb24gZm9yIHRoZSBhYm92ZSAnYWRhcC0+cGh5c19hZGRy ID0gMHgxMDBiJyAKYXNzaWdubWVudC4KCkJlc3QgcmVnYXJkcwotLSAKTWFyZWsgU3p5cHJvd3Nr aSwgUGhEClNhbXN1bmcgUiZEIEluc3RpdHV0ZSBQb2xhbmQKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailout3.w1.samsung.com ([210.118.77.13]:29265 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754062AbbGUNDL (ORCPT ); Tue, 21 Jul 2015 09:03:11 -0400 Subject: Re: [PATCHv7 14/15] cec: s5p-cec: Add s5p-cec driver To: Hans Verkuil , Hans Verkuil , linux-media@vger.kernel.org References: <1435572900-56998-1-git-send-email-hans.verkuil@cisco.com> <1435572900-56998-15-git-send-email-hans.verkuil@cisco.com> <55A7AD20.3080703@xs4all.nl> Cc: dri-devel@lists.freedesktop.org, kyungmin.park@samsung.com, thomas@tommie-lie.de, sean@mess.org, dmitry.torokhov@gmail.com, linux-input@vger.kernel.org, linux-samsung-soc@vger.kernel.org, lars@opdenkamp.eu, kamil@wypas.org From: Marek Szyprowski Message-id: <55AE430A.8040300@samsung.com> Date: Tue, 21 Jul 2015 15:03:06 +0200 MIME-version: 1.0 In-reply-to: <55A7AD20.3080703@xs4all.nl> Content-type: text/plain; charset=utf-8; format=flowed Content-transfer-encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hello, On 2015-07-16 15:09, Hans Verkuil wrote: > Marek, Kamil, > > On 06/29/15 12:14, Hans Verkuil wrote: >> From: Kamil Debski >> >> Add CEC interface driver present in the Samsung Exynos range of >> SoCs. >> >> The following files were based on work by SangPil Moon: >> - exynos_hdmi_cec.h >> - exynos_hdmi_cecctl.c >> >> Signed-off-by: Kamil Debski >> Signed-off-by: Hans Verkuil >> --- > > >> diff --git a/drivers/media/platform/s5p-cec/s5p_cec.c b/drivers/media/platform/s5p-cec/s5p_cec.c >> new file mode 100644 >> index 0000000..0f16d00 >> --- /dev/null >> +++ b/drivers/media/platform/s5p-cec/s5p_cec.c >> @@ -0,0 +1,283 @@ >> +/* drivers/media/platform/s5p-cec/s5p_cec.c >> + * >> + * Samsung S5P CEC driver >> + * >> + * Copyright (c) 2014 Samsung Electronics Co., Ltd. >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License as published by >> + * the Free Software Foundation; either version 2 of the License, or >> + * (at your option) any later version. >> + * >> + * This driver is based on the "cec interface driver for exynos soc" by >> + * SangPil Moon. >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#include "exynos_hdmi_cec.h" >> +#include "regs-cec.h" >> +#include "s5p_cec.h" >> + >> +#define CEC_NAME "s5p-cec" >> + >> +static int debug; >> +module_param(debug, int, 0644); >> +MODULE_PARM_DESC(debug, "debug level (0-2)"); >> + >> +static int s5p_cec_enable(struct cec_adapter *adap, bool enable) >> +{ >> + struct s5p_cec_dev *cec = container_of(adap, struct s5p_cec_dev, adap); >> + int ret; >> + >> + if (enable) { >> + ret = pm_runtime_get_sync(cec->dev); >> + >> + adap->phys_addr = 0x100b; > This is a bogus physical address. The actual physical address has to be derived > from the EDID that is read by the HDMI transmitter. > > I think in the case of this driver it will have to be userspace that assigns > the physical address after reading the EDID from drm/kms? > > How did you test this, Kamil? If I remember correctly, physical address has been derived from EDID in the userspace (it is available in /sys/class/drm/*) and passed to s5p-cec driver by appropriate ioctl. I don't know what is the reason for the above 'adap->phys_addr = 0x100b' assignment. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland