Re: [PATCH] net: phy: dp83867: Fix warning check for setting the internal delay

[Florian Fainelli <f.fainelli@gmail.com>]

On 21/07/15 10:06, Dan Murphy wrote:
> Fix warning: logical ‘or’ of collectively exhaustive tests is always true
> 
> Change the internal delay check from an 'or' condition to an 'and'
> condition.
> 
> Reported-by: David Binderman <dcb314@hotmail.com>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>

> ---
>  drivers/net/phy/dp83867.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
> index c7a12e2..8a3bf54 100644
> --- a/drivers/net/phy/dp83867.c
> +++ b/drivers/net/phy/dp83867.c
> @@ -164,7 +164,7 @@ static int dp83867_config_init(struct phy_device *phydev)
>  			return ret;
>  	}
>  
> -	if ((phydev->interface >= PHY_INTERFACE_MODE_RGMII_ID) ||
> +	if ((phydev->interface >= PHY_INTERFACE_MODE_RGMII_ID) &&
>  	    (phydev->interface <= PHY_INTERFACE_MODE_RGMII_RXID)) {
>  		val = phy_read_mmd_indirect(phydev, DP83867_RGMIICTL,
>  					    DP83867_DEVADDR, phydev->addr);
> 


-- 
Florian