From: Michael Haggerty <mhagger@alum.mit.edu>
To: Junio C Hamano <gitster@pobox.com>,
David Turner <dturner@twopensource.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v9 6/7] update-ref and tag: add --create-reflog arg
Date: Tue, 21 Jul 2015 13:02:36 -0700 [thread overview]
Message-ID: <55AEA55C.2020501@alum.mit.edu> (raw)
In-Reply-To: <xmqqio9dwjh6.fsf@gitster.dls.corp.google.com>
On 07/21/2015 09:42 AM, Junio C Hamano wrote:
> David Turner <dturner@twopensource.com> writes:
>
>> diff --git a/builtin/update-ref.c b/builtin/update-ref.c
>> index 6763cf1..d9646ef 100644
>> --- a/builtin/update-ref.c
>> +++ b/builtin/update-ref.c
>> @@ -14,6 +14,7 @@ static const char * const git_update_ref_usage[] = {
>>
>> static char line_termination = '\n';
>> static int update_flags;
>> +int create_reflog_flag;
>
> No need to reroll only for this, but I'll s/^int/static &/; while
> queuing.
>
> I may have more comments later; this was found in the first pass.
In fact, this variable is used as the "flags" argument to
ref_transaction_create(), so it should be
s/^int/static unsigned &/
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
next prev parent reply other threads:[~2015-07-21 20:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 15:44 [PATCH v9 0/7] refs backend preamble David Turner
2015-07-21 15:44 ` [PATCH v9 1/7] refs.c: add err arguments to reflog functions David Turner
2015-07-21 19:50 ` Michael Haggerty
2015-07-21 15:44 ` [PATCH v9 2/7] refs: Break out check for reflog autocreation David Turner
2015-07-21 15:45 ` [PATCH v9 3/7] refs: new public ref function: safe_create_reflog David Turner
2015-07-21 19:57 ` Michael Haggerty
2015-07-21 15:45 ` [PATCH v9 4/7] git-reflog: add exists command David Turner
2015-07-21 19:51 ` Michael Haggerty
2015-07-21 15:45 ` [PATCH v9 5/7] refs: add REF_FORCE_CREATE_REFLOG flag David Turner
2015-07-21 15:45 ` [PATCH v9 6/7] update-ref and tag: add --create-reflog arg David Turner
2015-07-21 16:42 ` Junio C Hamano
2015-07-21 20:02 ` Michael Haggerty [this message]
2015-07-21 20:06 ` Michael Haggerty
2015-07-21 15:45 ` [PATCH v9 7/7] git-stash: use update-ref --create-reflog instead of creating files David Turner
2015-07-21 20:20 ` [PATCH v9 0/7] refs backend preamble Michael Haggerty
2015-07-21 20:43 ` David Turner
2015-07-21 20:49 ` Junio C Hamano
2015-07-21 21:05 ` David Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AEA55C.2020501@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.