From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Tue, 21 Jul 2015 20:09:27 -0600 Subject: [PATCH v2 4/4] irqchip: Add bcm2836 interrupt controller for Raspberry Pi 2. In-Reply-To: <1436837718-956-5-git-send-email-eric@anholt.net> References: <1436837718-956-1-git-send-email-eric@anholt.net> <1436837718-956-5-git-send-email-eric@anholt.net> Message-ID: <55AEFB57.6030902@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 07/13/2015 07:35 PM, Eric Anholt wrote: > This interrupt controller is the new root interrupt controller with > the timer, PMU events, and IPIs, and the bcm2835's interrupt > controller is chained off of it to handle the peripherals. > diff --git a/drivers/irqchip/irq-bcm2836.c b/drivers/irqchip/irq-bcm2836.c > +static void bcm2836_arm_irqchip_mask_pmu_irq(struct irq_data *d) > +{ > + pr_err("%d: mask PMU\n", smp_processor_id()); > + writel(1 << smp_processor_id(), intc.base + LOCAL_PM_ROUTING_CLR); > +} > + > +static void bcm2836_arm_irqchip_unmask_pmu_irq(struct irq_data *d) > +{ > + pr_err("%d: unmask PMU\n", smp_processor_id()); > + writel(1 << smp_processor_id(), intc.base + LOCAL_PM_ROUTING_SET); > +} Are those pr_err() calls left-over debug, or is there some reason it's an error to call those functions? Aside from this and the other minor comment, the series, Acked-by: Stephen Warren From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH v2 4/4] irqchip: Add bcm2836 interrupt controller for Raspberry Pi 2. Date: Tue, 21 Jul 2015 20:09:27 -0600 Message-ID: <55AEFB57.6030902@wwwdotorg.org> References: <1436837718-956-1-git-send-email-eric@anholt.net> <1436837718-956-5-git-send-email-eric@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1436837718-956-5-git-send-email-eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Eric Anholt Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Lee Jones , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Thomas Gleixner , Jason Cooper , Andrea Merello List-Id: devicetree@vger.kernel.org On 07/13/2015 07:35 PM, Eric Anholt wrote: > This interrupt controller is the new root interrupt controller with > the timer, PMU events, and IPIs, and the bcm2835's interrupt > controller is chained off of it to handle the peripherals. > diff --git a/drivers/irqchip/irq-bcm2836.c b/drivers/irqchip/irq-bcm2836.c > +static void bcm2836_arm_irqchip_mask_pmu_irq(struct irq_data *d) > +{ > + pr_err("%d: mask PMU\n", smp_processor_id()); > + writel(1 << smp_processor_id(), intc.base + LOCAL_PM_ROUTING_CLR); > +} > + > +static void bcm2836_arm_irqchip_unmask_pmu_irq(struct irq_data *d) > +{ > + pr_err("%d: unmask PMU\n", smp_processor_id()); > + writel(1 << smp_processor_id(), intc.base + LOCAL_PM_ROUTING_SET); > +} Are those pr_err() calls left-over debug, or is there some reason it's an error to call those functions? Aside from this and the other minor comment, the series, Acked-by: Stephen Warren -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755571AbbGVCJb (ORCPT ); Tue, 21 Jul 2015 22:09:31 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:55944 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752169AbbGVCJ3 (ORCPT ); Tue, 21 Jul 2015 22:09:29 -0400 Message-ID: <55AEFB57.6030902@wwwdotorg.org> Date: Tue, 21 Jul 2015 20:09:27 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Eric Anholt CC: linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , devicetree@vger.kernel.org, Thomas Gleixner , Jason Cooper , Andrea Merello Subject: Re: [PATCH v2 4/4] irqchip: Add bcm2836 interrupt controller for Raspberry Pi 2. References: <1436837718-956-1-git-send-email-eric@anholt.net> <1436837718-956-5-git-send-email-eric@anholt.net> In-Reply-To: <1436837718-956-5-git-send-email-eric@anholt.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/13/2015 07:35 PM, Eric Anholt wrote: > This interrupt controller is the new root interrupt controller with > the timer, PMU events, and IPIs, and the bcm2835's interrupt > controller is chained off of it to handle the peripherals. > diff --git a/drivers/irqchip/irq-bcm2836.c b/drivers/irqchip/irq-bcm2836.c > +static void bcm2836_arm_irqchip_mask_pmu_irq(struct irq_data *d) > +{ > + pr_err("%d: mask PMU\n", smp_processor_id()); > + writel(1 << smp_processor_id(), intc.base + LOCAL_PM_ROUTING_CLR); > +} > + > +static void bcm2836_arm_irqchip_unmask_pmu_irq(struct irq_data *d) > +{ > + pr_err("%d: unmask PMU\n", smp_processor_id()); > + writel(1 << smp_processor_id(), intc.base + LOCAL_PM_ROUTING_SET); > +} Are those pr_err() calls left-over debug, or is there some reason it's an error to call those functions? Aside from this and the other minor comment, the series, Acked-by: Stephen Warren