From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: Re: Linux-next, Exynos Octa boot fail, bisected to: "drm/exynos: remove drm_iommu_attach_device_if_possible" Date: Wed, 22 Jul 2015 13:55:11 +0900 Message-ID: <55AF222F.1060303@samsung.com> References: <55AEF9AD.6090709@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <55AEF9AD.6090709@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Joonyoung Shim , Krzysztof Kozlowski , Seung-Woo Kim Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kyungmin Park , Kukjin Kim , Marek Szyprowski List-Id: linux-samsung-soc@vger.kernel.org T24gMjAxNeuFhCAwN+yblCAyMuydvCAxMTowMiwgSm9vbnlvdW5nIFNoaW0gd3JvdGU6Cj4gT24g MDcvMjEvMjAxNSAxMDoxOSBQTSwgS3J6eXN6dG9mIEtvemxvd3NraSB3cm90ZToKPj4gSGksCj4+ Cj4+IFRvZGF5J3MgbGludXgtbmV4dCAobmV4dC0yMDE1MDcyMSkgZW5jb3VudGVycyBib290IGZh aWx1cmVzIG9uIEV4eW5vcwo+PiBPY3RhIChFeHlub3M1NDIyKSBiYXNlZCBib2FyZHMuIFRoZSBi b2FyZHMgaGFuZ3MuIEkgYmlzZWN0ZWQgaXQgdG86Cj4+Cj4+IGQ4MDE2N2I4NTAyNDk4MmM1ZjE4 ZDA0ODFhNWMyNDgxMDAzNjAxMTggaXMgdGhlIGZpcnN0IGJhZCBjb21taXQKPj4gY29tbWl0IGQ4 MDE2N2I4NTAyNDk4MmM1ZjE4ZDA0ODFhNWMyNDgxMDAzNjAxMTgKPj4gQXV0aG9yOiBKb29ueW91 bmcgU2hpbSA8ankwOTIyLnNoaW1Ac2Ftc3VuZy5jb20+Cj4+IERhdGU6ICAgVGh1IEp1bCAyIDIx OjQ5OjM5IDIwMTUgKzA5MDAKPj4KPj4gICAgIGRybS9leHlub3M6IHJlbW92ZSBkcm1faW9tbXVf YXR0YWNoX2RldmljZV9pZl9wb3NzaWJsZQo+Pgo+PiAgICAgQWxyZWFkeSBkcm1faW9tbXVfYXR0 YWNoX2RldmljZSBjaGVja3Mgd2hldGhlciBzdXBwb3J0IGlvbW11IGludGVybmFsbHkuCj4+ICAg ICBJdCBzaG91bGQgY2xlYXIgY2hhbm5lbHMgYWx3YXlzIHJlZ2FyZGxlc3MgaW9tbXUgc3VwcG9y dC4gV2UgZGlkbid0IGtub3cKPj4gICAgIGJlY2F1c2Ugd2UgY2FuIGRldGVjdCB0aGUgcHJvYmxl bSB3aGVuIGlvbW11IGlzIGVuYWJsZWQsIHNvIHdlIGRvbid0Cj4+ICAgICBoYXZlIHRvIHVzZSBk cm1faW9tbXVfYXR0YWNoX2RldmljZV9pZl9wb3NzaWJsZSBhbmQgdGhlbiB3ZSBjYW4gcmVtb3Zl Cj4+ICAgICBkcm1faW9tbXVfYXR0YWNoX2RldmljZV9pZl9wb3NzaWJsZSBhbmQgY2xlYXJfY2hh bm5lbHMgZnVuY3Rpb24gcG9pbnRlci4KPj4KPj4gICAgIFNpZ25lZC1vZmYtYnk6IEpvb255b3Vu ZyBTaGltIDxqeTA5MjIuc2hpbUBzYW1zdW5nLmNvbT4KPj4gICAgIFRlc3RlZC1ieTogTWFyZWsg U3p5cHJvd3NraSA8bS5zenlwcm93c2tpQHNhbXN1bmcuY29tPgo+PiAgICAgU2lnbmVkLW9mZi1i eTogSW5raSBEYWUgPGlua2kuZGFlQHNhbXN1bmcuY29tPgo+Pgo+PiA6MDQwMDAwIDA0MDAwMCA4 MzM3OWVmYmY0OTYwZjU4ZDY4MDM3MTYyOGVjMDQzODc5MzViZDUzCj4+IGRhMDNjMzM4Yjg4ZTdj YjZiZGE4OTViM2RkNTJkNzhkOWI2ZWJhMzAgTSBkcml2ZXJzCj4+Cj4+Cj4+IENvbmZpZzogZXh5 bm9zCj4+IEJvb3QgbG9nIGZyb20gT2Ryb2lkIFhVMy1MaXRlIGF0dGFjaGVkLgo+Pgo+PiBBbnkg aGludHMgb3IgaWRlYXM/Cj4gCj4gVGhlIHBvaW50IHRoYXQgaGFuZ3MgaXMgd2hlbiBhY2Nlc3Nl cyBmaW1kIHJlZ2lzdGVyIGluCj4gZmltZF9jbGVhcl9jaGFubmVscyBmdW5jdGlvbiwgc28gaSBk b3VidCBjbG9jayBzZXR0aW5nIGZvciBmaW1kLgo+IAo+IEl0J3MgZ29uZSBzb21ldGhpbmcgdGhh dCBoYW5ncyBhZnRlciBpIGVuYWJsZSBnYXRpbmcgZm9yIEFDTEtfMjAwX0RJU1AxCj4gY2xvY2su Cj4gCj4gSWYgQUNMS18yMDBfRElTUDEgY2xvY2sgbmVlZHMgZm9yIGZpbWQgcmVhbGx5LCBpJ20g dGhpbmtpbmcgaG93IGNhbiBpdAo+IHN1cHBvcnQuIEFueSBpZGVhcz8KCkkgdGhpbmsgYm9vdGxv YWRlciBzaG91bGQgaGF2ZSBlbmFibGVkIEFDTEtfMjAwX0RJU1AxIGNsb2NrIGFuZCBhbHNvCmRl dmljZSBkcml2ZXIgc2hvdWxkIGVuYWJsZSBhbGwgcmVsZXZhbnQgY2xvY2tzIGJlZm9yZSB0aGUg ZGV2aWNlCmFjY2Vzc2VzIGl0cyBvd24gcmVnaXN0ZXJzLgoKQmVzdCB3YXkgd291bGQgYmUgdGhh dCB0aGUgY2xvY2sgaXMgZW5hYmxlZCBieSBjb21tb24gY2xvY2sgZnJhbWV3b3JrCmJ1dCBpdCBz ZWVtcyB0aGVyZSBpcyBubyBhbnl0aGluZyB0aGF0IHRoZSBjbG9jayBmcmFtZXdvcmsgY2FuIGRv IGl0LiBTbwpJIHRoaW5rIHdoYXQgd2UgaGF2ZSB0byBkbyBpcyB0byBhZGQgdGhlIGNsb2NrIHN1 cHBvcnQgdG8gZGV2aWNlIHRyZWUuCgpPdGhlciBpZGVhPwoKVGhhbmtzLApJbmtpIERhZQoKPiAK PiBUaGFua3MuCj4gLS0KPiBUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUg bGluZSAidW5zdWJzY3JpYmUgbGludXgtc2Ftc3VuZy1zb2MiIGluCj4gdGhlIGJvZHkgb2YgYSBt ZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcKPiBNb3JlIG1ham9yZG9tbyBpbmZv IGF0ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwKPiAKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754804AbbGVEzS (ORCPT ); Wed, 22 Jul 2015 00:55:18 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:48995 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752284AbbGVEzP (ORCPT ); Wed, 22 Jul 2015 00:55:15 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68d-f79106d00000728c-75-55af22305751 Content-transfer-encoding: 8BIT Message-id: <55AF222F.1060303@samsung.com> Date: Wed, 22 Jul 2015 13:55:11 +0900 From: Inki Dae User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 To: Joonyoung Shim , Krzysztof Kozlowski , Seung-Woo Kim Cc: dri-devel@lists.freedesktop.org, Kyungmin Park , Kukjin Kim , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Marek Szyprowski Subject: Re: Linux-next, Exynos Octa boot fail, bisected to: "drm/exynos: remove drm_iommu_attach_device_if_possible" References: <55AEF9AD.6090709@samsung.com> In-reply-to: <55AEF9AD.6090709@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrOIsWRmVeSWpSXmKPExsWyRsSkUNdAaX2owY/zohZXvr5ns3hx7yKL xesXhhb9j18zW5xtesNucXnXHDaLGef3MVmsPXKX3WLG5JdsDpwem1Z1snnc7z7O5NG3ZRWj x+dNcgEsUVw2Kak5mWWpRfp2CVwZb/+sYy9YJFSx/tELpgbGd3xdjJwcEgImEs/6djND2GIS F+6tZ+ti5OIQEljKKHF3xR8mmKKeN7dYIBLTGSUaX3eDdfAKCEr8mHwPKMHBwSwgL3HkUjZI mFlAXWLSvEXMEPX3GSXOb+lggajXklj4bDaYzSKgKvG6bRrYHDYge+KK+2wgtqhAhMTbyyfB FosItDNKbH3vADKIGWRQY9MMsAZhgXKJu9v/gNlCAsUS3S+ngDVzCmhLfLj0ghGkQULgGrvE 5h/zmSC2CUh8m3wI7FIJAVmJTQegXpaUOLjiBssERrFZSP6ZhfDPLCT/LGBkXsUomlqQXFCc lF5kqFecmFtcmpeul5yfu4kRGH+n/z3r3cF4+4D1IUYBDkYlHt4JR9eFCrEmlhVX5h5iNAU6 YiKzlGhyPjDK80riDY3NjCxMTUyNjcwtzZTEeRWlfgYLCaQnlqRmp6YWpBbFF5XmpBYfYmTi 4JRqYFRreKHfP+v234epN5//KhXfJnZevj/pyNpUv6TOHJll3tt2L+XOmLfJkl3wZ/Yz26yc t03+i97rNkYk/P2wLuvth19/OYU2lpueEtDvem1qraEWtu1CGsNqFb5pe3SeaOkbbz3a+9X9 3sy3/tOOGM999Vgx2mWHSWfy0qvC28VYp8ssvdZwdqUSS3FGoqEWc1FxIgDOfpeNugIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrIIsWRmVeSWpSXmKPExsVy+t9jQV0DpfWhButn8Vtc+fqezeLFvYss Fq9fGFr0P37NbHG26Q27xeVdc9gsZpzfx2Sx9shddosZk1+yOXB6bFrVyeZxv/s4k0ffllWM Hp83yQWwRDUw2mSkJqakFimk5iXnp2TmpdsqeQfHO8ebmhkY6hpaWpgrKeQl5qbaKrn4BOi6 ZeYA3aKkUJaYUwoUCkgsLlbSt8M0ITTETdcCpjFC1zckCK7HyAANJKxhzHj7Zx17wSKhivWP XjA1ML7j62Lk5JAQMJHoeXOLBcIWk7hwbz1bFyMXh5DAdEaJxtfdzCAJXgFBiR+T7wEVcXAw C8hLHLmUDRJmFlCXmDRvETNE/X1GifNbOlgg6rUkFj6bDWazCKhKvG6bBjaHDcieuOI+G4gt KhAh8fbySSYQW0SgnVFi63sHkEHMIIMam2aANQgLlEvc3f4HzBYSKJbofjkFrJlTQFviw6UX jBMYBWYhuW8Wwn2zkNy3gJF5FaNoakFyQXFSeq6RXnFibnFpXrpecn7uJkZwdD+T3sG4qsHi EKMAB6MSD++Eo+tChVgTy4orcw8xSnAwK4nwKnOvDxXiTUmsrEotyo8vKs1JLT7EaAr03URm KdHkfGDiySuJNzQ2MTOyNDI3tDAyNlcS5z2Z7xMqJJCeWJKanZpakFoE08fEwSnVwJh+SfuB dMiX9SGTa2f/dHn1bu71iEaD40oX1C887znaIHpqovqr7f32gU1u1uEinDpWhncz70z+cvrQ 0oigc3rSc+bUigWd1zkSmeFr5/rV6EPnnFWPDyS9nqO8yXadgAzf1S0r39bcK2BfIGjsGHxi 8qGH57h+relT7r7/+ff5/jWTY+9Mus+pxFKckWioxVxUnAgAJDLl1QQDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015년 07월 22일 11:02, Joonyoung Shim wrote: > On 07/21/2015 10:19 PM, Krzysztof Kozlowski wrote: >> Hi, >> >> Today's linux-next (next-20150721) encounters boot failures on Exynos >> Octa (Exynos5422) based boards. The boards hangs. I bisected it to: >> >> d80167b85024982c5f18d0481a5c248100360118 is the first bad commit >> commit d80167b85024982c5f18d0481a5c248100360118 >> Author: Joonyoung Shim >> Date: Thu Jul 2 21:49:39 2015 +0900 >> >> drm/exynos: remove drm_iommu_attach_device_if_possible >> >> Already drm_iommu_attach_device checks whether support iommu internally. >> It should clear channels always regardless iommu support. We didn't know >> because we can detect the problem when iommu is enabled, so we don't >> have to use drm_iommu_attach_device_if_possible and then we can remove >> drm_iommu_attach_device_if_possible and clear_channels function pointer. >> >> Signed-off-by: Joonyoung Shim >> Tested-by: Marek Szyprowski >> Signed-off-by: Inki Dae >> >> :040000 040000 83379efbf4960f58d680371628ec04387935bd53 >> da03c338b88e7cb6bda895b3dd52d78d9b6eba30 M drivers >> >> >> Config: exynos >> Boot log from Odroid XU3-Lite attached. >> >> Any hints or ideas? > > The point that hangs is when accesses fimd register in > fimd_clear_channels function, so i doubt clock setting for fimd. > > It's gone something that hangs after i enable gating for ACLK_200_DISP1 > clock. > > If ACLK_200_DISP1 clock needs for fimd really, i'm thinking how can it > support. Any ideas? I think bootloader should have enabled ACLK_200_DISP1 clock and also device driver should enable all relevant clocks before the device accesses its own registers. Best way would be that the clock is enabled by common clock framework but it seems there is no anything that the clock framework can do it. So I think what we have to do is to add the clock support to device tree. Other idea? Thanks, Inki Dae > > Thanks. > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >