From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonyoung Shim Subject: Re: Linux-next, Exynos Octa boot fail, bisected to: "drm/exynos: remove drm_iommu_attach_device_if_possible" Date: Wed, 22 Jul 2015 17:12:08 +0900 Message-ID: <55AF5058.3060106@samsung.com> References: <55AEF9AD.6090709@samsung.com> <55AF222F.1060303@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <55AF222F.1060303@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Inki Dae , Krzysztof Kozlowski , Seung-Woo Kim Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kyungmin Park , Kukjin Kim , Marek Szyprowski List-Id: linux-samsung-soc@vger.kernel.org T24gMDcvMjIvMjAxNSAwMTo1NSBQTSwgSW5raSBEYWUgd3JvdGU6Cj4gT24gMjAxNeuFhCAwN+yb lCAyMuydvCAxMTowMiwgSm9vbnlvdW5nIFNoaW0gd3JvdGU6Cj4+IE9uIDA3LzIxLzIwMTUgMTA6 MTkgUE0sIEtyenlzenRvZiBLb3psb3dza2kgd3JvdGU6Cj4+PiBIaSwKPj4+Cj4+PiBUb2RheSdz IGxpbnV4LW5leHQgKG5leHQtMjAxNTA3MjEpIGVuY291bnRlcnMgYm9vdCBmYWlsdXJlcyBvbiBF eHlub3MKPj4+IE9jdGEgKEV4eW5vczU0MjIpIGJhc2VkIGJvYXJkcy4gVGhlIGJvYXJkcyBoYW5n cy4gSSBiaXNlY3RlZCBpdCB0bzoKPj4+Cj4+PiBkODAxNjdiODUwMjQ5ODJjNWYxOGQwNDgxYTVj MjQ4MTAwMzYwMTE4IGlzIHRoZSBmaXJzdCBiYWQgY29tbWl0Cj4+PiBjb21taXQgZDgwMTY3Yjg1 MDI0OTgyYzVmMThkMDQ4MWE1YzI0ODEwMDM2MDExOAo+Pj4gQXV0aG9yOiBKb29ueW91bmcgU2hp bSA8ankwOTIyLnNoaW1Ac2Ftc3VuZy5jb20+Cj4+PiBEYXRlOiAgIFRodSBKdWwgMiAyMTo0OToz OSAyMDE1ICswOTAwCj4+Pgo+Pj4gICAgIGRybS9leHlub3M6IHJlbW92ZSBkcm1faW9tbXVfYXR0 YWNoX2RldmljZV9pZl9wb3NzaWJsZQo+Pj4KPj4+ICAgICBBbHJlYWR5IGRybV9pb21tdV9hdHRh Y2hfZGV2aWNlIGNoZWNrcyB3aGV0aGVyIHN1cHBvcnQgaW9tbXUgaW50ZXJuYWxseS4KPj4+ICAg ICBJdCBzaG91bGQgY2xlYXIgY2hhbm5lbHMgYWx3YXlzIHJlZ2FyZGxlc3MgaW9tbXUgc3VwcG9y dC4gV2UgZGlkbid0IGtub3cKPj4+ICAgICBiZWNhdXNlIHdlIGNhbiBkZXRlY3QgdGhlIHByb2Js ZW0gd2hlbiBpb21tdSBpcyBlbmFibGVkLCBzbyB3ZSBkb24ndAo+Pj4gICAgIGhhdmUgdG8gdXNl IGRybV9pb21tdV9hdHRhY2hfZGV2aWNlX2lmX3Bvc3NpYmxlIGFuZCB0aGVuIHdlIGNhbiByZW1v dmUKPj4+ICAgICBkcm1faW9tbXVfYXR0YWNoX2RldmljZV9pZl9wb3NzaWJsZSBhbmQgY2xlYXJf Y2hhbm5lbHMgZnVuY3Rpb24gcG9pbnRlci4KPj4+Cj4+PiAgICAgU2lnbmVkLW9mZi1ieTogSm9v bnlvdW5nIFNoaW0gPGp5MDkyMi5zaGltQHNhbXN1bmcuY29tPgo+Pj4gICAgIFRlc3RlZC1ieTog TWFyZWsgU3p5cHJvd3NraSA8bS5zenlwcm93c2tpQHNhbXN1bmcuY29tPgo+Pj4gICAgIFNpZ25l ZC1vZmYtYnk6IElua2kgRGFlIDxpbmtpLmRhZUBzYW1zdW5nLmNvbT4KPj4+Cj4+PiA6MDQwMDAw IDA0MDAwMCA4MzM3OWVmYmY0OTYwZjU4ZDY4MDM3MTYyOGVjMDQzODc5MzViZDUzCj4+PiBkYTAz YzMzOGI4OGU3Y2I2YmRhODk1YjNkZDUyZDc4ZDliNmViYTMwIE0gZHJpdmVycwo+Pj4KPj4+Cj4+ PiBDb25maWc6IGV4eW5vcwo+Pj4gQm9vdCBsb2cgZnJvbSBPZHJvaWQgWFUzLUxpdGUgYXR0YWNo ZWQuCj4+Pgo+Pj4gQW55IGhpbnRzIG9yIGlkZWFzPwo+Pgo+PiBUaGUgcG9pbnQgdGhhdCBoYW5n cyBpcyB3aGVuIGFjY2Vzc2VzIGZpbWQgcmVnaXN0ZXIgaW4KPj4gZmltZF9jbGVhcl9jaGFubmVs cyBmdW5jdGlvbiwgc28gaSBkb3VidCBjbG9jayBzZXR0aW5nIGZvciBmaW1kLgo+Pgo+PiBJdCdz IGdvbmUgc29tZXRoaW5nIHRoYXQgaGFuZ3MgYWZ0ZXIgaSBlbmFibGUgZ2F0aW5nIGZvciBBQ0xL XzIwMF9ESVNQMQo+PiBjbG9jay4KPj4KPj4gSWYgQUNMS18yMDBfRElTUDEgY2xvY2sgbmVlZHMg Zm9yIGZpbWQgcmVhbGx5LCBpJ20gdGhpbmtpbmcgaG93IGNhbiBpdAo+PiBzdXBwb3J0LiBBbnkg aWRlYXM/Cj4gCj4gSSB0aGluayBib290bG9hZGVyIHNob3VsZCBoYXZlIGVuYWJsZWQgQUNMS18y MDBfRElTUDEgY2xvY2sgYW5kIGFsc28KPiBkZXZpY2UgZHJpdmVyIHNob3VsZCBlbmFibGUgYWxs IHJlbGV2YW50IGNsb2NrcyBiZWZvcmUgdGhlIGRldmljZQo+IGFjY2Vzc2VzIGl0cyBvd24gcmVn aXN0ZXJzLgo+IAo+IEJlc3Qgd2F5IHdvdWxkIGJlIHRoYXQgdGhlIGNsb2NrIGlzIGVuYWJsZWQg YnkgY29tbW9uIGNsb2NrIGZyYW1ld29yawo+IGJ1dCBpdCBzZWVtcyB0aGVyZSBpcyBubyBhbnl0 aGluZyB0aGF0IHRoZSBjbG9jayBmcmFtZXdvcmsgY2FuIGRvIGl0LiBTbwo+IEkgdGhpbmsgd2hh dCB3ZSBoYXZlIHRvIGRvIGlzIHRvIGFkZCB0aGUgY2xvY2sgc3VwcG9ydCB0byBkZXZpY2UgdHJl ZS4KCkl0J3Mgbm90IGVhc3kgcHJvYmxlbSB0byBtZS4gU2hvdWxkIHdlIGFkZCB3aGljaCBjbG9j az8gSSB0aGluayB3ZQpjYW5ub3QgY29udHJvbCBBQ0xLXzIwMF9ESVNQMSBvciBDTEtESVYyX0RJ U1AxX0JMSyBkaXJlY3RseSBieSBiZWxvdwpoaWVyYXJjaHksIHJpZ2h0PyBUaGVuIHdlIHNob3Vs ZCBjb250cm9sIGdhdGUgY2xvY2tzLCBidXQgd2UgaGF2ZSBub3QKY29udHJvbGxlZCBhbnkgZ2F0 ZSBjbG9ja3MgdXNpbmcgQlRTXyBwcmVmaXguCgpUaGUgY2xvY2sgaGllcmFyY2h5IGZyb20gRXh5 bm9zNTQyMiB1c2VyIG1hbnVhbCwKQUNMS18yMDBfRElTUDEgLS0gQ0xLRElWMl9ESVNQMV9CTEsg LS0gSERNSSBMSU5LCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEhETUkg UEhZCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIE1JQzEKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRFNJTTEKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgRFBUWCBMSU5LCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIE1ETklFMQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBT WVNNTVVfTUlYRVIKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgU1lTTU1V X0ZJTUQxX00wCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFNZU01NVV9G SU1EMV9NMQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBCVFNfVFZNMAog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBCVFNfVFZNMQogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBCVFNfRklNRDFfTTAKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgQlRTX0ZJTUQxX00xCgpPdGhlciB3YXksIElNSE8sIGZp bWQgZHJpdmVyIGRvZXNuJ3QgaGF2ZSB0byBlbmFibGUgQUNMS18yMDBfRElTUDEgY2xvY2ssCmp1 c3QgaXQgc2hvdWxkIGJlIGNvbnRyb2xsZWQgYnkgY29ubmVjdG9yIGRyaXZlcnMsIGUuZy4gZHNp LCBkcCBiZWNhdXNlCmZpbWQgb25seSBjYW5ub3Qgb3BlcmF0ZSwgc28gZHNpIG9yIGRwIG11c3Qg bmVlZCAoQWN0dWFsbHkgaSdtIG5vdCBzdXJlCmFib3V0IHRoaXMsIGp1c3QgaSB0aG91Z2h0IHRo YXQgRXh5bm9zNSBTb0NzIGRvbid0IGhhdmUgYW55IGdwaW9zIGZvcgpkcGksIHNvIHRoZXkgY2Fu bm90IHVzZSBkcGksIHJpZ2h0PykuCgpJdCBuZWVkcyB0byBwcm9iZSBjb25uZWN0b3IgZHJpdmVy IGxpa2UgZHNpIG9yIGRwIGVhcmxpZXIgdGhhbiBmaW1kIGFuZApmaW1kX2JpbmQgZnVuY3Rpb24g c2hvdWxkIHJldHVybiBlcnJvciBpZiBjb25uZWN0b3IgZHJpdmVyIGxpa2UgZHNpIG9yCmRwIHdh cyBub3QgcHJvYmVkLiBUaGlzIGlzIGFsc28gbm90IGVhc3kgdG8gbWUuCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756358AbbGVIMS (ORCPT ); Wed, 22 Jul 2015 04:12:18 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:45431 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754802AbbGVIMG (ORCPT ); Wed, 22 Jul 2015 04:12:06 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee68f-f793b6d000005f66-0b-55af5053807e Content-transfer-encoding: 8BIT Message-id: <55AF5058.3060106@samsung.com> Date: Wed, 22 Jul 2015 17:12:08 +0900 From: Joonyoung Shim User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 To: Inki Dae , Krzysztof Kozlowski , Seung-Woo Kim Cc: dri-devel@lists.freedesktop.org, Kyungmin Park , Kukjin Kim , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Marek Szyprowski Subject: Re: Linux-next, Exynos Octa boot fail, bisected to: "drm/exynos: remove drm_iommu_attach_device_if_possible" References: <55AEF9AD.6090709@samsung.com> <55AF222F.1060303@samsung.com> In-reply-to: <55AF222F.1060303@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMIsWRmVeSWpSXmKPExsWyRsSkRDc4YH2owfLNEhZXvr5ns5h0fwKL xesXhhb9j18zW5xtesNucXnXHDaLGef3MVmsPXKX3WLG5JdsDpwem1Z1snnc7z7O5NG3ZRWj x+dNcgEsUVw2Kak5mWWpRfp2CVwZe9YqFZyUqfjffJetgXGVSBcjJ4eEgInEkYcrGCFsMYkL 99azdTFycQgJLGWUWH/6LnMXIwdY0f43JRDx6YwSXZ+2MYE08AoISvyYfI8FpIZZQF7iyKVs CFNdYsqUXIjyB4wSx55dZoQo15JYfucEmM0ioCqxacFkNhCbTUBP4s6242AjRQXCJM7M6GAB sUUE6iR6j/xgBhnELHCfUaKxaQYzSEJYoFzi7vY/YLaQwCRGiQ1XXUBsTgFtidn/21lAGiQE rrFLTOyazwKxTUDi2+RDLBDPyEpsOsAM8bCkxMEVN1gmMIrNQvLOLIR3ZiG8s4CReRWjaGpB ckFxUnqRsV5xYm5xaV66XnJ+7iZGYNyd/vesfwfj3QPWhxgFOBiVeHgnHF0XKsSaWFZcmXuI 0RTohonMUqLJ+cDoziuJNzQ2M7IwNTE1NjK3NFMS510o9TNYSCA9sSQ1OzW1ILUovqg0J7X4 ECMTB6dUA+PS6iVtlrJnGW5r7d58qXdfk5FhRSS3XfzLn0u1almOmJ2LzfRlOfBpSqzuih3B cc9LUt4JdvCfPm1zcOpH0fIH6yYcjnoyZ5Wi8Kq737+Zrzq6oUvtcLJP/8+t3HKzn4d735YW 3+Z91NHNVJE3Nbjpdsr+9Y+S13xjMbgx55ne+aTXFp//vLymxFKckWioxVxUnAgA1FCglrYC AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLIsWRmVeSWpSXmKPExsVy+t9jQd3ggPWhBjPaBCyufH3PZjHp/gQW i9cvDC36H79mtjjb9Ibd4vKuOWwWM87vY7JYe+Quu8WMyS/ZHDg9Nq3qZPO4332cyaNvyypG j8+b5AJYohoYbTJSE1NSixRS85LzUzLz0m2VvIPjneNNzQwMdQ0tLcyVFPISc1NtlVx8AnTd MnOAblFSKEvMKQUKBSQWFyvp22GaEBripmsB0xih6xsSBNdjZIAGEtYwZuxZq1RwUqbif/Nd tgbGVSJdjBwcEgImEvvflHQxcgKZYhIX7q1n62Lk4hASmM4o0fVpGxNIgldAUOLH5HssIPXM AvISRy5lQ5jqElOm5EKUP2CUOPbsMiNEuZbE8jsnwGwWAVWJTQsms4HYbAJ6Ene2HQcbKSoQ JnFmRgcLiC0iUCfRe+QHM8ggZoH7jBKNTTOYQRLCAuUSd7f/AbOFBCYxSmy46gJicwpoS8z+ 384ygVFgFpLzZiGcNwvhvAWMzKsYRVMLkguKk9JzjfSKE3OLS/PS9ZLzczcxgqP6mfQOxlUN FocYBTgYlXh4JxxdFyrEmlhWXJl7iFGCg1lJhFeZe32oEG9KYmVValF+fFFpTmrxIUZToOcm MkuJJucDE05eSbyhsYmZkaWRuaGFkbG5kjjvyXyfUCGB9MSS1OzU1ILUIpg+Jg5OqQZGb786 Nh9t8ezs1jWz+7ZM1P95tuLfqqWnolkk7s66f0NK9NL7buPbm/NldR4f8PnTc4Tl836VyTMa X4Ykl99nlbPdtP38iSs/PXvDnqx+x389c7IL4+/k33kVkR/rGL1aRH87LVY4rf18nxYDV7SO qpZmcmrdIv49aRd4fzWL32Y6sf462/IPSizFGYmGWsxFxYkASHPFXwADAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/22/2015 01:55 PM, Inki Dae wrote: > On 2015년 07월 22일 11:02, Joonyoung Shim wrote: >> On 07/21/2015 10:19 PM, Krzysztof Kozlowski wrote: >>> Hi, >>> >>> Today's linux-next (next-20150721) encounters boot failures on Exynos >>> Octa (Exynos5422) based boards. The boards hangs. I bisected it to: >>> >>> d80167b85024982c5f18d0481a5c248100360118 is the first bad commit >>> commit d80167b85024982c5f18d0481a5c248100360118 >>> Author: Joonyoung Shim >>> Date: Thu Jul 2 21:49:39 2015 +0900 >>> >>> drm/exynos: remove drm_iommu_attach_device_if_possible >>> >>> Already drm_iommu_attach_device checks whether support iommu internally. >>> It should clear channels always regardless iommu support. We didn't know >>> because we can detect the problem when iommu is enabled, so we don't >>> have to use drm_iommu_attach_device_if_possible and then we can remove >>> drm_iommu_attach_device_if_possible and clear_channels function pointer. >>> >>> Signed-off-by: Joonyoung Shim >>> Tested-by: Marek Szyprowski >>> Signed-off-by: Inki Dae >>> >>> :040000 040000 83379efbf4960f58d680371628ec04387935bd53 >>> da03c338b88e7cb6bda895b3dd52d78d9b6eba30 M drivers >>> >>> >>> Config: exynos >>> Boot log from Odroid XU3-Lite attached. >>> >>> Any hints or ideas? >> >> The point that hangs is when accesses fimd register in >> fimd_clear_channels function, so i doubt clock setting for fimd. >> >> It's gone something that hangs after i enable gating for ACLK_200_DISP1 >> clock. >> >> If ACLK_200_DISP1 clock needs for fimd really, i'm thinking how can it >> support. Any ideas? > > I think bootloader should have enabled ACLK_200_DISP1 clock and also > device driver should enable all relevant clocks before the device > accesses its own registers. > > Best way would be that the clock is enabled by common clock framework > but it seems there is no anything that the clock framework can do it. So > I think what we have to do is to add the clock support to device tree. It's not easy problem to me. Should we add which clock? I think we cannot control ACLK_200_DISP1 or CLKDIV2_DISP1_BLK directly by below hierarchy, right? Then we should control gate clocks, but we have not controlled any gate clocks using BTS_ prefix. The clock hierarchy from Exynos5422 user manual, ACLK_200_DISP1 -- CLKDIV2_DISP1_BLK -- HDMI LINK HDMI PHY MIC1 DSIM1 DPTX LINK MDNIE1 SYSMMU_MIXER SYSMMU_FIMD1_M0 SYSMMU_FIMD1_M1 BTS_TVM0 BTS_TVM1 BTS_FIMD1_M0 BTS_FIMD1_M1 Other way, IMHO, fimd driver doesn't have to enable ACLK_200_DISP1 clock, just it should be controlled by connector drivers, e.g. dsi, dp because fimd only cannot operate, so dsi or dp must need (Actually i'm not sure about this, just i thought that Exynos5 SoCs don't have any gpios for dpi, so they cannot use dpi, right?). It needs to probe connector driver like dsi or dp earlier than fimd and fimd_bind function should return error if connector driver like dsi or dp was not probed. This is also not easy to me.