All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michel Dänzer" <michel@daenzer.net>
To: Alexandr Akulich <akulichalexander@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] libdrm/amdgpu: Fixed drm.h include.
Date: Wed, 22 Jul 2015 17:20:46 +0900	[thread overview]
Message-ID: <55AF525E.1010908@daenzer.net> (raw)
In-Reply-To: <CAA1VrPpMy-AKvC-W09dOjHeR5HjYK0fj97Jfex-1rZq5Wu_DaA@mail.gmail.com>

On 22.07.2015 16:33, Alexandr Akulich wrote:
> On Wed, Jul 22, 2015 at 1:19 PM, Michel Dänzer <michel@daenzer.net> wrote:
>> On 17.07.2015 22:33, Alexandr Akulich wrote:
>>> As I see, this is not a kernel header, but a local (belongs to libdrm) one.
>>> (Otherwise, I would like you to point me on such file at, say,
>>> https://github.com/torvalds/linux/tree/master/include/drm)
>>
>> https://github.com/torvalds/linux/blob/master/include/uapi/drm/amdgpu_drm.h
>>
>>
>>> At files drm_sarea.h, mga_drm.h, qxl_drm.h, radeon_drm.h and via_drm.h we have
>>>
>>> #include "drm.h"
>>>
>>> At the same time, at i915_drm.h and tegra_drm.h. we have
>>>
>>> #include <drm.h>
>>>
>>> I'm pretty sure that the first case is correct, because drm.h is
>>> always would be local file (in the same directory), related to
>>> amdgpu_drm.h, and that is why local include "drm.h" would be always
>>> valid.
>>
>> Makes sense to me, the patch is
>>
>> Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
> Thanks! I have no write access to this fd.o repository. Can you apply it please?

I assume your patch is against the amdgpu branch of
http://cgit.freedesktop.org/~agd5f/drm/, right? Only Alex Deucher has
write access to that.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2015-07-22  8:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16 20:19 [PATCH] libdrm/amdgpu: Fixed drm.h include akulichalexander
2015-07-17  9:13 ` Michel Dänzer
2015-07-17 13:33   ` Alexandr Akulich
2015-07-22  7:19     ` Michel Dänzer
2015-07-22  7:33       ` Alexandr Akulich
2015-07-22  7:35         ` Alexandr Akulich
2015-07-22  8:20         ` Michel Dänzer [this message]
2015-07-29  2:35           ` Alexandr Akulich
2015-07-29 20:59             ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55AF525E.1010908@daenzer.net \
    --to=michel@daenzer.net \
    --cc=akulichalexander@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.