From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: Re: Linux-next, Exynos Octa boot fail, bisected to: "drm/exynos: remove drm_iommu_attach_device_if_possible" Date: Wed, 22 Jul 2015 17:22:23 +0900 Message-ID: <55AF52BF.4030201@samsung.com> References: <55AEF9AD.6090709@samsung.com> <55AF222F.1060303@samsung.com> <55AF5058.3060106@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <55AF5058.3060106@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Joonyoung Shim , Krzysztof Kozlowski , Seung-Woo Kim Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kyungmin Park , Kukjin Kim , Marek Szyprowski List-Id: linux-samsung-soc@vger.kernel.org T24gMjAxNeuFhCAwN+yblCAyMuydvCAxNzoxMiwgSm9vbnlvdW5nIFNoaW0gd3JvdGU6Cj4gT24g MDcvMjIvMjAxNSAwMTo1NSBQTSwgSW5raSBEYWUgd3JvdGU6Cj4+IE9uIDIwMTXrhYQgMDfsm5Qg MjLsnbwgMTE6MDIsIEpvb255b3VuZyBTaGltIHdyb3RlOgo+Pj4gT24gMDcvMjEvMjAxNSAxMDox OSBQTSwgS3J6eXN6dG9mIEtvemxvd3NraSB3cm90ZToKPj4+PiBIaSwKPj4+Pgo+Pj4+IFRvZGF5 J3MgbGludXgtbmV4dCAobmV4dC0yMDE1MDcyMSkgZW5jb3VudGVycyBib290IGZhaWx1cmVzIG9u IEV4eW5vcwo+Pj4+IE9jdGEgKEV4eW5vczU0MjIpIGJhc2VkIGJvYXJkcy4gVGhlIGJvYXJkcyBo YW5ncy4gSSBiaXNlY3RlZCBpdCB0bzoKPj4+Pgo+Pj4+IGQ4MDE2N2I4NTAyNDk4MmM1ZjE4ZDA0 ODFhNWMyNDgxMDAzNjAxMTggaXMgdGhlIGZpcnN0IGJhZCBjb21taXQKPj4+PiBjb21taXQgZDgw MTY3Yjg1MDI0OTgyYzVmMThkMDQ4MWE1YzI0ODEwMDM2MDExOAo+Pj4+IEF1dGhvcjogSm9vbnlv dW5nIFNoaW0gPGp5MDkyMi5zaGltQHNhbXN1bmcuY29tPgo+Pj4+IERhdGU6ICAgVGh1IEp1bCAy IDIxOjQ5OjM5IDIwMTUgKzA5MDAKPj4+Pgo+Pj4+ICAgICBkcm0vZXh5bm9zOiByZW1vdmUgZHJt X2lvbW11X2F0dGFjaF9kZXZpY2VfaWZfcG9zc2libGUKPj4+Pgo+Pj4+ICAgICBBbHJlYWR5IGRy bV9pb21tdV9hdHRhY2hfZGV2aWNlIGNoZWNrcyB3aGV0aGVyIHN1cHBvcnQgaW9tbXUgaW50ZXJu YWxseS4KPj4+PiAgICAgSXQgc2hvdWxkIGNsZWFyIGNoYW5uZWxzIGFsd2F5cyByZWdhcmRsZXNz IGlvbW11IHN1cHBvcnQuIFdlIGRpZG4ndCBrbm93Cj4+Pj4gICAgIGJlY2F1c2Ugd2UgY2FuIGRl dGVjdCB0aGUgcHJvYmxlbSB3aGVuIGlvbW11IGlzIGVuYWJsZWQsIHNvIHdlIGRvbid0Cj4+Pj4g ICAgIGhhdmUgdG8gdXNlIGRybV9pb21tdV9hdHRhY2hfZGV2aWNlX2lmX3Bvc3NpYmxlIGFuZCB0 aGVuIHdlIGNhbiByZW1vdmUKPj4+PiAgICAgZHJtX2lvbW11X2F0dGFjaF9kZXZpY2VfaWZfcG9z c2libGUgYW5kIGNsZWFyX2NoYW5uZWxzIGZ1bmN0aW9uIHBvaW50ZXIuCj4+Pj4KPj4+PiAgICAg U2lnbmVkLW9mZi1ieTogSm9vbnlvdW5nIFNoaW0gPGp5MDkyMi5zaGltQHNhbXN1bmcuY29tPgo+ Pj4+ICAgICBUZXN0ZWQtYnk6IE1hcmVrIFN6eXByb3dza2kgPG0uc3p5cHJvd3NraUBzYW1zdW5n LmNvbT4KPj4+PiAgICAgU2lnbmVkLW9mZi1ieTogSW5raSBEYWUgPGlua2kuZGFlQHNhbXN1bmcu Y29tPgo+Pj4+Cj4+Pj4gOjA0MDAwMCAwNDAwMDAgODMzNzllZmJmNDk2MGY1OGQ2ODAzNzE2Mjhl YzA0Mzg3OTM1YmQ1Mwo+Pj4+IGRhMDNjMzM4Yjg4ZTdjYjZiZGE4OTViM2RkNTJkNzhkOWI2ZWJh MzAgTSBkcml2ZXJzCj4+Pj4KPj4+Pgo+Pj4+IENvbmZpZzogZXh5bm9zCj4+Pj4gQm9vdCBsb2cg ZnJvbSBPZHJvaWQgWFUzLUxpdGUgYXR0YWNoZWQuCj4+Pj4KPj4+PiBBbnkgaGludHMgb3IgaWRl YXM/Cj4+Pgo+Pj4gVGhlIHBvaW50IHRoYXQgaGFuZ3MgaXMgd2hlbiBhY2Nlc3NlcyBmaW1kIHJl Z2lzdGVyIGluCj4+PiBmaW1kX2NsZWFyX2NoYW5uZWxzIGZ1bmN0aW9uLCBzbyBpIGRvdWJ0IGNs b2NrIHNldHRpbmcgZm9yIGZpbWQuCj4+Pgo+Pj4gSXQncyBnb25lIHNvbWV0aGluZyB0aGF0IGhh bmdzIGFmdGVyIGkgZW5hYmxlIGdhdGluZyBmb3IgQUNMS18yMDBfRElTUDEKPj4+IGNsb2NrLgo+ Pj4KPj4+IElmIEFDTEtfMjAwX0RJU1AxIGNsb2NrIG5lZWRzIGZvciBmaW1kIHJlYWxseSwgaSdt IHRoaW5raW5nIGhvdyBjYW4gaXQKPj4+IHN1cHBvcnQuIEFueSBpZGVhcz8KPj4KPj4gSSB0aGlu ayBib290bG9hZGVyIHNob3VsZCBoYXZlIGVuYWJsZWQgQUNMS18yMDBfRElTUDEgY2xvY2sgYW5k IGFsc28KPj4gZGV2aWNlIGRyaXZlciBzaG91bGQgZW5hYmxlIGFsbCByZWxldmFudCBjbG9ja3Mg YmVmb3JlIHRoZSBkZXZpY2UKPj4gYWNjZXNzZXMgaXRzIG93biByZWdpc3RlcnMuCj4+Cj4+IEJl c3Qgd2F5IHdvdWxkIGJlIHRoYXQgdGhlIGNsb2NrIGlzIGVuYWJsZWQgYnkgY29tbW9uIGNsb2Nr IGZyYW1ld29yawo+PiBidXQgaXQgc2VlbXMgdGhlcmUgaXMgbm8gYW55dGhpbmcgdGhhdCB0aGUg Y2xvY2sgZnJhbWV3b3JrIGNhbiBkbyBpdC4gU28KPj4gSSB0aGluayB3aGF0IHdlIGhhdmUgdG8g ZG8gaXMgdG8gYWRkIHRoZSBjbG9jayBzdXBwb3J0IHRvIGRldmljZSB0cmVlLgo+IAo+IEl0J3Mg bm90IGVhc3kgcHJvYmxlbSB0byBtZS4gU2hvdWxkIHdlIGFkZCB3aGljaCBjbG9jaz8gSSB0aGlu ayB3ZQo+IGNhbm5vdCBjb250cm9sIEFDTEtfMjAwX0RJU1AxIG9yIENMS0RJVjJfRElTUDFfQkxL IGRpcmVjdGx5IGJ5IGJlbG93Cj4gaGllcmFyY2h5LCByaWdodD8gVGhlbiB3ZSBzaG91bGQgY29u dHJvbCBnYXRlIGNsb2NrcywgYnV0IHdlIGhhdmUgbm90Cj4gY29udHJvbGxlZCBhbnkgZ2F0ZSBj bG9ja3MgdXNpbmcgQlRTXyBwcmVmaXguCj4gCj4gVGhlIGNsb2NrIGhpZXJhcmNoeSBmcm9tIEV4 eW5vczU0MjIgdXNlciBtYW51YWwsCj4gQUNMS18yMDBfRElTUDEgLS0gQ0xLRElWMl9ESVNQMV9C TEsgLS0gSERNSSBMSU5LCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg SERNSSBQSFkKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBNSUMxCj4g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRFNJTTEKPiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBEUFRYIExJTksKPiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBNRE5JRTEKPiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBTWVNNTVVfTUlYRVIKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBTWVNNTVVfRklNRDFfTTAKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBTWVNNTVVfRklNRDFfTTEKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBCVFNfVFZNMAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIEJUU19UVk0xCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgQlRT X0ZJTUQxX00wCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgQlRTX0ZJ TUQxX00xCj4gCj4gT3RoZXIgd2F5LCBJTUhPLCBmaW1kIGRyaXZlciBkb2Vzbid0IGhhdmUgdG8g ZW5hYmxlIEFDTEtfMjAwX0RJU1AxIGNsb2NrLAo+IGp1c3QgaXQgc2hvdWxkIGJlIGNvbnRyb2xs ZWQgYnkgY29ubmVjdG9yIGRyaXZlcnMsIGUuZy4gZHNpLCBkcCBiZWNhdXNlCj4gZmltZCBvbmx5 IGNhbm5vdCBvcGVyYXRlLCBzbyBkc2kgb3IgZHAgbXVzdCBuZWVkIChBY3R1YWxseSBpJ20gbm90 IHN1cmUKPiBhYm91dCB0aGlzLCBqdXN0IGkgdGhvdWdodCB0aGF0IEV4eW5vczUgU29DcyBkb24n dCBoYXZlIGFueSBncGlvcyBmb3IKPiBkcGksIHNvIHRoZXkgY2Fubm90IHVzZSBkcGksIHJpZ2h0 PykuCj4gCj4gSXQgbmVlZHMgdG8gcHJvYmUgY29ubmVjdG9yIGRyaXZlciBsaWtlIGRzaSBvciBk cCBlYXJsaWVyIHRoYW4gZmltZCBhbmQKPiBmaW1kX2JpbmQgZnVuY3Rpb24gc2hvdWxkIHJldHVy biBlcnJvciBpZiBjb25uZWN0b3IgZHJpdmVyIGxpa2UgZHNpIG9yCj4gZHAgd2FzIG5vdCBwcm9i ZWQuIFRoaXMgaXMgYWxzbyBub3QgZWFzeSB0byBtZS4KCkluIHRoaXMgY2FzZSwgaWYgb25lIG9m IGFib3ZlIGdhdGUgY2xvY2tzIGlzIGVuYWJsZWQsIHRoZSBBQ0xLXzIwMF9ESVNQMQpzaG91bGQg YmUgZW5hYmxlZC4gU28gSSBndWVzcyB0aGUgcHJvYmxlbSB3b3VsZCBiZSBkdWUgdG8gYmVsb3cg bGluZSBvZgpjbGstZXh5bm9zNTQyMC5jLAoKR0FURShDTEtfRklNRDEsICJmaW1kMSIsICJhY2xr MzAwX2Rpc3AxIiwgR0FURV9JUF9ESVNQMSwgMCwgMCwgMCksCgpDYW4geW91IGNoZWNrIGl0IGFn YWluIGFmdGVyIG1vZGlmeWluZyBpdCBsaWtlIGJlbG93PywKR0FURShDTEtfRklNRDEsICJmaW1k MSIsICJhY2xrMjAwX2Rpc3AxIiwgR0FURV9JUF9ESVNQMSwgMCwgMCwgMCksCgpUaGFua3MsCklu a2kgRGFlCgo+IC0tCj4gVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxp bmUgInVuc3Vic2NyaWJlIGxpbnV4LXNhbXN1bmctc29jIiBpbgo+IHRoZSBib2R5IG9mIGEgbWVz c2FnZSB0byBtYWpvcmRvbW9Admdlci5rZXJuZWwub3JnCj4gTW9yZSBtYWpvcmRvbW8gaW5mbyBh dCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sCj4gCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933196AbbGVIfs (ORCPT ); Wed, 22 Jul 2015 04:35:48 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:52138 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756145AbbGVIf1 convert rfc822-to-8bit (ORCPT ); Wed, 22 Jul 2015 04:35:27 -0400 X-AuditID: cbfee691-f79ca6d00000456a-3d-55af55cb3f38 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT Message-id: <55AF52BF.4030201@samsung.com> Date: Wed, 22 Jul 2015 17:22:23 +0900 From: Inki Dae User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 To: Joonyoung Shim , Krzysztof Kozlowski , Seung-Woo Kim Cc: dri-devel@lists.freedesktop.org, Kyungmin Park , Kukjin Kim , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Marek Szyprowski Subject: Re: Linux-next, Exynos Octa boot fail, bisected to: "drm/exynos: remove drm_iommu_attach_device_if_possible" References: <55AEF9AD.6090709@samsung.com> <55AF222F.1060303@samsung.com> <55AF5058.3060106@samsung.com> In-reply-to: <55AF5058.3060106@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPIsWRmVeSWpSXmKPExsWyRsSkRPd06PpQgzvXzCyufH3PZvHi3kUW i9cvDC36H79mtjjb9Ibd4vKuOWwWM87vY7JYe+Quu8WMyS/ZHDg9Nq3qZPO4332cyaNvyypG j8+b5AJYorhsUlJzMstSi/TtErgyeqc7FPxUqpi9cC5zA+MRyS5GTg4JAROJdRtmsULYYhIX 7q1n62Lk4hASWMooMX/WPBaYomdfrrBDJKYzStybdgkswSsgKPFj8j0gm4ODWUBdYsqUXJAw s4CIxJrlj5ggbG2JZQtfM0P03meU2DVxHjNEr5ZEb99WMJtFQFXi/toZ7CA2G5A9ccV9NhBb VCBC4u3lk2CDRATaGSW2vncAGcQMMqixaQZYs7BAucTd7X+gNmxmlPh6uo8RJMEJtHrVpY1g CQmBS+wS+5ta2CDWCUh8m3wI7GwJAVmJTQeYId6UlDi44gbLBEbxWUiem4Xw3Cwkz81C8twC RpZVjKKpBckFxUnpRaZ6xYm5xaV56XrJ+bmbGIHxevrfs4k7GO8fsD7EKMDBqMTDO+HoulAh 1sSy4srcQ4ymQAdNZJYSTc4HJoW8knhDYzMjC1MTU2Mjc0szJXFeHemfwUIC6YklqdmpqQWp RfFFpTmpxYcYmTg4pRoYFWffObZsVf/DttP8Yl7sbZPiHd9+PrV287dlCU4vZF9NPtjSd9vo +mf3b00G7nOEHA7kaxnqLj9bk6Q1SWcNn9vOqtaPu4LTErhTm/1cQhpiI8/r51pP+NDU4WCR 8OrCwbkcC1+9OXWs/OrJpC9HWVj2FNw99PlGw5GvP7t4wybxTFq1urt3qhJLcUaioRZzUXEi AA8d46bSAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrAIsWRmVeSWpSXmKPExsVy+t9jQd39QetDDeY91LG48vU9m8WLexdZ LF6/MLTof/ya2eJs0xt2i8u75rBZzDi/j8li7ZG77BYzJr9kc+D02LSqk83jfvdxJo++LasY PT5vkgtgiWpgtMlITUxJLVJIzUvOT8nMS7dV8g6Od443NTMw1DW0tDBXUshLzE21VXLxCdB1 y8wBukVJoSwxpxQoFJBYXKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjDmHH07Wq2gpNKFff7 3jA2ME6R7GLk5JAQMJF49uUKO4QtJnHh3nq2LkYuDiGB6YwS96ZdYgFJ8AoISvyYfA/I5uBg FpCXOHIpG8JUl5gyJRei/D6jxK6J85ghyrUkevu2gtksAqoS99fOAJvPBmRPXHGfDcQWFYiQ eHv5JBOILSLQziix9b0DyCBmkEGNTTPAmoUFyiXubv/DDLFhM6PE19N9jCAJTgFtiVWXNjJP YBSYheS+WQj3zUK4bwEj8ypG0dSC5ILipPRcQ73ixNzi0rx0veT83E2M4Nh+JrWDcWWDxSFG AQ5GJR7eCUfXhQqxJpYVV+YeYpTgYFYS4VXmXh8qxJuSWFmVWpQfX1Sak1p8iNEU6LuJzFKi yfnAtJNXEm9obGJmZGlkbmhhZGyuJM57Mt8nVEggPbEkNTs1tSC1CKaPiYNTqoGxIOTj++iN qw4yzdJJeqda/eSBb33xxc3/EiX/n/a7diDk8GXVu682KBRLiYYXhsqpfJQXvZt+4uW99g+y adIGDnuzBN7HZGS4KrrwyYXZ/QsMqLFyU+cT2bm+zVzB/9f9qB5b9Z9qJ+fI2Uo+k8gTT7rE eFZw7WfVzXcVdY1VWvPMDK+1OCqxFGckGmoxFxUnAgDGmuQsAwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015년 07월 22일 17:12, Joonyoung Shim wrote: > On 07/22/2015 01:55 PM, Inki Dae wrote: >> On 2015년 07월 22일 11:02, Joonyoung Shim wrote: >>> On 07/21/2015 10:19 PM, Krzysztof Kozlowski wrote: >>>> Hi, >>>> >>>> Today's linux-next (next-20150721) encounters boot failures on Exynos >>>> Octa (Exynos5422) based boards. The boards hangs. I bisected it to: >>>> >>>> d80167b85024982c5f18d0481a5c248100360118 is the first bad commit >>>> commit d80167b85024982c5f18d0481a5c248100360118 >>>> Author: Joonyoung Shim >>>> Date: Thu Jul 2 21:49:39 2015 +0900 >>>> >>>> drm/exynos: remove drm_iommu_attach_device_if_possible >>>> >>>> Already drm_iommu_attach_device checks whether support iommu internally. >>>> It should clear channels always regardless iommu support. We didn't know >>>> because we can detect the problem when iommu is enabled, so we don't >>>> have to use drm_iommu_attach_device_if_possible and then we can remove >>>> drm_iommu_attach_device_if_possible and clear_channels function pointer. >>>> >>>> Signed-off-by: Joonyoung Shim >>>> Tested-by: Marek Szyprowski >>>> Signed-off-by: Inki Dae >>>> >>>> :040000 040000 83379efbf4960f58d680371628ec04387935bd53 >>>> da03c338b88e7cb6bda895b3dd52d78d9b6eba30 M drivers >>>> >>>> >>>> Config: exynos >>>> Boot log from Odroid XU3-Lite attached. >>>> >>>> Any hints or ideas? >>> >>> The point that hangs is when accesses fimd register in >>> fimd_clear_channels function, so i doubt clock setting for fimd. >>> >>> It's gone something that hangs after i enable gating for ACLK_200_DISP1 >>> clock. >>> >>> If ACLK_200_DISP1 clock needs for fimd really, i'm thinking how can it >>> support. Any ideas? >> >> I think bootloader should have enabled ACLK_200_DISP1 clock and also >> device driver should enable all relevant clocks before the device >> accesses its own registers. >> >> Best way would be that the clock is enabled by common clock framework >> but it seems there is no anything that the clock framework can do it. So >> I think what we have to do is to add the clock support to device tree. > > It's not easy problem to me. Should we add which clock? I think we > cannot control ACLK_200_DISP1 or CLKDIV2_DISP1_BLK directly by below > hierarchy, right? Then we should control gate clocks, but we have not > controlled any gate clocks using BTS_ prefix. > > The clock hierarchy from Exynos5422 user manual, > ACLK_200_DISP1 -- CLKDIV2_DISP1_BLK -- HDMI LINK > HDMI PHY > MIC1 > DSIM1 > DPTX LINK > MDNIE1 > SYSMMU_MIXER > SYSMMU_FIMD1_M0 > SYSMMU_FIMD1_M1 > BTS_TVM0 > BTS_TVM1 > BTS_FIMD1_M0 > BTS_FIMD1_M1 > > Other way, IMHO, fimd driver doesn't have to enable ACLK_200_DISP1 clock, > just it should be controlled by connector drivers, e.g. dsi, dp because > fimd only cannot operate, so dsi or dp must need (Actually i'm not sure > about this, just i thought that Exynos5 SoCs don't have any gpios for > dpi, so they cannot use dpi, right?). > > It needs to probe connector driver like dsi or dp earlier than fimd and > fimd_bind function should return error if connector driver like dsi or > dp was not probed. This is also not easy to me. In this case, if one of above gate clocks is enabled, the ACLK_200_DISP1 should be enabled. So I guess the problem would be due to below line of clk-exynos5420.c, GATE(CLK_FIMD1, "fimd1", "aclk300_disp1", GATE_IP_DISP1, 0, 0, 0), Can you check it again after modifying it like below?, GATE(CLK_FIMD1, "fimd1", "aclk200_disp1", GATE_IP_DISP1, 0, 0, 0), Thanks, Inki Dae > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >