From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonyoung Shim Subject: Re: Linux-next, Exynos Octa boot fail, bisected to: "drm/exynos: remove drm_iommu_attach_device_if_possible" Date: Wed, 22 Jul 2015 17:42:39 +0900 Message-ID: <55AF577F.10606@samsung.com> References: <55AEF9AD.6090709@samsung.com> <55AF222F.1060303@samsung.com> <55AF5058.3060106@samsung.com> <55AF52BF.4030201@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <55AF52BF.4030201@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Inki Dae , Krzysztof Kozlowski , Seung-Woo Kim Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kyungmin Park , Kukjin Kim , Marek Szyprowski List-Id: linux-samsung-soc@vger.kernel.org T24gMDcvMjIvMjAxNSAwNToyMiBQTSwgSW5raSBEYWUgd3JvdGU6Cj4gT24gMjAxNeuFhCAwN+yb lCAyMuydvCAxNzoxMiwgSm9vbnlvdW5nIFNoaW0gd3JvdGU6Cj4+IE9uIDA3LzIyLzIwMTUgMDE6 NTUgUE0sIElua2kgRGFlIHdyb3RlOgo+Pj4gT24gMjAxNeuFhCAwN+yblCAyMuydvCAxMTowMiwg Sm9vbnlvdW5nIFNoaW0gd3JvdGU6Cj4+Pj4gT24gMDcvMjEvMjAxNSAxMDoxOSBQTSwgS3J6eXN6 dG9mIEtvemxvd3NraSB3cm90ZToKPj4+Pj4gSGksCj4+Pj4+Cj4+Pj4+IFRvZGF5J3MgbGludXgt bmV4dCAobmV4dC0yMDE1MDcyMSkgZW5jb3VudGVycyBib290IGZhaWx1cmVzIG9uIEV4eW5vcwo+ Pj4+PiBPY3RhIChFeHlub3M1NDIyKSBiYXNlZCBib2FyZHMuIFRoZSBib2FyZHMgaGFuZ3MuIEkg YmlzZWN0ZWQgaXQgdG86Cj4+Pj4+Cj4+Pj4+IGQ4MDE2N2I4NTAyNDk4MmM1ZjE4ZDA0ODFhNWMy NDgxMDAzNjAxMTggaXMgdGhlIGZpcnN0IGJhZCBjb21taXQKPj4+Pj4gY29tbWl0IGQ4MDE2N2I4 NTAyNDk4MmM1ZjE4ZDA0ODFhNWMyNDgxMDAzNjAxMTgKPj4+Pj4gQXV0aG9yOiBKb29ueW91bmcg U2hpbSA8ankwOTIyLnNoaW1Ac2Ftc3VuZy5jb20+Cj4+Pj4+IERhdGU6ICAgVGh1IEp1bCAyIDIx OjQ5OjM5IDIwMTUgKzA5MDAKPj4+Pj4KPj4+Pj4gICAgIGRybS9leHlub3M6IHJlbW92ZSBkcm1f aW9tbXVfYXR0YWNoX2RldmljZV9pZl9wb3NzaWJsZQo+Pj4+Pgo+Pj4+PiAgICAgQWxyZWFkeSBk cm1faW9tbXVfYXR0YWNoX2RldmljZSBjaGVja3Mgd2hldGhlciBzdXBwb3J0IGlvbW11IGludGVy bmFsbHkuCj4+Pj4+ICAgICBJdCBzaG91bGQgY2xlYXIgY2hhbm5lbHMgYWx3YXlzIHJlZ2FyZGxl c3MgaW9tbXUgc3VwcG9ydC4gV2UgZGlkbid0IGtub3cKPj4+Pj4gICAgIGJlY2F1c2Ugd2UgY2Fu IGRldGVjdCB0aGUgcHJvYmxlbSB3aGVuIGlvbW11IGlzIGVuYWJsZWQsIHNvIHdlIGRvbid0Cj4+ Pj4+ICAgICBoYXZlIHRvIHVzZSBkcm1faW9tbXVfYXR0YWNoX2RldmljZV9pZl9wb3NzaWJsZSBh bmQgdGhlbiB3ZSBjYW4gcmVtb3ZlCj4+Pj4+ICAgICBkcm1faW9tbXVfYXR0YWNoX2RldmljZV9p Zl9wb3NzaWJsZSBhbmQgY2xlYXJfY2hhbm5lbHMgZnVuY3Rpb24gcG9pbnRlci4KPj4+Pj4KPj4+ Pj4gICAgIFNpZ25lZC1vZmYtYnk6IEpvb255b3VuZyBTaGltIDxqeTA5MjIuc2hpbUBzYW1zdW5n LmNvbT4KPj4+Pj4gICAgIFRlc3RlZC1ieTogTWFyZWsgU3p5cHJvd3NraSA8bS5zenlwcm93c2tp QHNhbXN1bmcuY29tPgo+Pj4+PiAgICAgU2lnbmVkLW9mZi1ieTogSW5raSBEYWUgPGlua2kuZGFl QHNhbXN1bmcuY29tPgo+Pj4+Pgo+Pj4+PiA6MDQwMDAwIDA0MDAwMCA4MzM3OWVmYmY0OTYwZjU4 ZDY4MDM3MTYyOGVjMDQzODc5MzViZDUzCj4+Pj4+IGRhMDNjMzM4Yjg4ZTdjYjZiZGE4OTViM2Rk NTJkNzhkOWI2ZWJhMzAgTSBkcml2ZXJzCj4+Pj4+Cj4+Pj4+Cj4+Pj4+IENvbmZpZzogZXh5bm9z Cj4+Pj4+IEJvb3QgbG9nIGZyb20gT2Ryb2lkIFhVMy1MaXRlIGF0dGFjaGVkLgo+Pj4+Pgo+Pj4+ PiBBbnkgaGludHMgb3IgaWRlYXM/Cj4+Pj4KPj4+PiBUaGUgcG9pbnQgdGhhdCBoYW5ncyBpcyB3 aGVuIGFjY2Vzc2VzIGZpbWQgcmVnaXN0ZXIgaW4KPj4+PiBmaW1kX2NsZWFyX2NoYW5uZWxzIGZ1 bmN0aW9uLCBzbyBpIGRvdWJ0IGNsb2NrIHNldHRpbmcgZm9yIGZpbWQuCj4+Pj4KPj4+PiBJdCdz IGdvbmUgc29tZXRoaW5nIHRoYXQgaGFuZ3MgYWZ0ZXIgaSBlbmFibGUgZ2F0aW5nIGZvciBBQ0xL XzIwMF9ESVNQMQo+Pj4+IGNsb2NrLgo+Pj4+Cj4+Pj4gSWYgQUNMS18yMDBfRElTUDEgY2xvY2sg bmVlZHMgZm9yIGZpbWQgcmVhbGx5LCBpJ20gdGhpbmtpbmcgaG93IGNhbiBpdAo+Pj4+IHN1cHBv cnQuIEFueSBpZGVhcz8KPj4+Cj4+PiBJIHRoaW5rIGJvb3Rsb2FkZXIgc2hvdWxkIGhhdmUgZW5h YmxlZCBBQ0xLXzIwMF9ESVNQMSBjbG9jayBhbmQgYWxzbwo+Pj4gZGV2aWNlIGRyaXZlciBzaG91 bGQgZW5hYmxlIGFsbCByZWxldmFudCBjbG9ja3MgYmVmb3JlIHRoZSBkZXZpY2UKPj4+IGFjY2Vz c2VzIGl0cyBvd24gcmVnaXN0ZXJzLgo+Pj4KPj4+IEJlc3Qgd2F5IHdvdWxkIGJlIHRoYXQgdGhl IGNsb2NrIGlzIGVuYWJsZWQgYnkgY29tbW9uIGNsb2NrIGZyYW1ld29yawo+Pj4gYnV0IGl0IHNl ZW1zIHRoZXJlIGlzIG5vIGFueXRoaW5nIHRoYXQgdGhlIGNsb2NrIGZyYW1ld29yayBjYW4gZG8g aXQuIFNvCj4+PiBJIHRoaW5rIHdoYXQgd2UgaGF2ZSB0byBkbyBpcyB0byBhZGQgdGhlIGNsb2Nr IHN1cHBvcnQgdG8gZGV2aWNlIHRyZWUuCj4+Cj4+IEl0J3Mgbm90IGVhc3kgcHJvYmxlbSB0byBt ZS4gU2hvdWxkIHdlIGFkZCB3aGljaCBjbG9jaz8gSSB0aGluayB3ZQo+PiBjYW5ub3QgY29udHJv bCBBQ0xLXzIwMF9ESVNQMSBvciBDTEtESVYyX0RJU1AxX0JMSyBkaXJlY3RseSBieSBiZWxvdwo+ PiBoaWVyYXJjaHksIHJpZ2h0PyBUaGVuIHdlIHNob3VsZCBjb250cm9sIGdhdGUgY2xvY2tzLCBi dXQgd2UgaGF2ZSBub3QKPj4gY29udHJvbGxlZCBhbnkgZ2F0ZSBjbG9ja3MgdXNpbmcgQlRTXyBw cmVmaXguCj4+Cj4+IFRoZSBjbG9jayBoaWVyYXJjaHkgZnJvbSBFeHlub3M1NDIyIHVzZXIgbWFu dWFsLAo+PiBBQ0xLXzIwMF9ESVNQMSAtLSBDTEtESVYyX0RJU1AxX0JMSyAtLSBIRE1JIExJTksK Pj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgSERNSSBQSFkKPj4gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgTUlDMQo+PiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBEU0lNMQo+PiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBEUFRYIExJTksKPj4gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgTUROSUUxCj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIFNZU01NVV9NSVhFUgo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBTWVNNTVVfRklNRDFfTTAKPj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgU1lTTU1VX0ZJTUQxX00xCj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIEJUU19UVk0wCj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEJU U19UVk0xCj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEJUU19GSU1E MV9NMAo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBCVFNfRklNRDFf TTEKPj4KPj4gT3RoZXIgd2F5LCBJTUhPLCBmaW1kIGRyaXZlciBkb2Vzbid0IGhhdmUgdG8gZW5h YmxlIEFDTEtfMjAwX0RJU1AxIGNsb2NrLAo+PiBqdXN0IGl0IHNob3VsZCBiZSBjb250cm9sbGVk IGJ5IGNvbm5lY3RvciBkcml2ZXJzLCBlLmcuIGRzaSwgZHAgYmVjYXVzZQo+PiBmaW1kIG9ubHkg Y2Fubm90IG9wZXJhdGUsIHNvIGRzaSBvciBkcCBtdXN0IG5lZWQgKEFjdHVhbGx5IGknbSBub3Qg c3VyZQo+PiBhYm91dCB0aGlzLCBqdXN0IGkgdGhvdWdodCB0aGF0IEV4eW5vczUgU29DcyBkb24n dCBoYXZlIGFueSBncGlvcyBmb3IKPj4gZHBpLCBzbyB0aGV5IGNhbm5vdCB1c2UgZHBpLCByaWdo dD8pLgo+Pgo+PiBJdCBuZWVkcyB0byBwcm9iZSBjb25uZWN0b3IgZHJpdmVyIGxpa2UgZHNpIG9y IGRwIGVhcmxpZXIgdGhhbiBmaW1kIGFuZAo+PiBmaW1kX2JpbmQgZnVuY3Rpb24gc2hvdWxkIHJl dHVybiBlcnJvciBpZiBjb25uZWN0b3IgZHJpdmVyIGxpa2UgZHNpIG9yCj4+IGRwIHdhcyBub3Qg cHJvYmVkLiBUaGlzIGlzIGFsc28gbm90IGVhc3kgdG8gbWUuCj4gCj4gSW4gdGhpcyBjYXNlLCBp ZiBvbmUgb2YgYWJvdmUgZ2F0ZSBjbG9ja3MgaXMgZW5hYmxlZCwgdGhlIEFDTEtfMjAwX0RJU1Ax Cj4gc2hvdWxkIGJlIGVuYWJsZWQuIFNvIEkgZ3Vlc3MgdGhlIHByb2JsZW0gd291bGQgYmUgZHVl IHRvIGJlbG93IGxpbmUgb2YKPiBjbGstZXh5bm9zNTQyMC5jLAo+IAo+IEdBVEUoQ0xLX0ZJTUQx LCAiZmltZDEiLCAiYWNsazMwMF9kaXNwMSIsIEdBVEVfSVBfRElTUDEsIDAsIDAsIDApLAo+IAo+ IENhbiB5b3UgY2hlY2sgaXQgYWdhaW4gYWZ0ZXIgbW9kaWZ5aW5nIGl0IGxpa2UgYmVsb3c/LAo+ IEdBVEUoQ0xLX0ZJTUQxLCAiZmltZDEiLCAiYWNsazIwMF9kaXNwMSIsIEdBVEVfSVBfRElTUDEs IDAsIDAsIDApLAoKTm8sIHBhcmVudCBjbG9jayBvZiBmaW1kMSBnYXRlIGNsb2NrIGlzIEFDTEtf MzAwX0RJU1AxLgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933687AbbGVImj (ORCPT ); Wed, 22 Jul 2015 04:42:39 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:45561 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932590AbbGVImf convert rfc822-to-8bit (ORCPT ); Wed, 22 Jul 2015 04:42:35 -0400 X-AuditID: cbfee68e-f79c56d000006efb-aa-55af5779a298 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT Message-id: <55AF577F.10606@samsung.com> Date: Wed, 22 Jul 2015 17:42:39 +0900 From: Joonyoung Shim User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 To: Inki Dae , Krzysztof Kozlowski , Seung-Woo Kim Cc: dri-devel@lists.freedesktop.org, Kyungmin Park , Kukjin Kim , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Marek Szyprowski Subject: Re: Linux-next, Exynos Octa boot fail, bisected to: "drm/exynos: remove drm_iommu_attach_device_if_possible" References: <55AEF9AD.6090709@samsung.com> <55AF222F.1060303@samsung.com> <55AF5058.3060106@samsung.com> <55AF52BF.4030201@samsung.com> In-reply-to: <55AF52BF.4030201@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPIsWRmVeSWpSXmKPExsWyRsSkQLcyfH2owafzAhZXvr5ns5h0fwKL xesXhhb9j18zW5xtesNucXnXHDaLGef3MVmsPXKX3WLG5JdsDpwem1Z1snnc7z7O5NG3ZRWj x+dNcgEsUVw2Kak5mWWpRfp2CVwZGy7fYS84rVTxY/URpgbG1ZJdjJwcEgImEi3bVrJB2GIS F+6tB7K5OIQEljJKNHduZ4MpuvenESoxnVHi65ET7CAJXgFBiR+T77F0MXJwMAuoS0yZkgsS ZhYQkfj8eg0ThK0tsWzha2aI3gdAQ1/0sUH0akjseDUbrJdFQFXi2iE/kDCbgJ7EnW3HwXpF BcIkzszoYAGxRQTqJHqP/ACbwyxwn1GisWkGM0hCWKBc4u72P1ALLjFKHNn/AGwBJ9Dmyf8P soMkJASusUvs2rYGLMEiICDxbfIhsM0SArISmw4wQ3wpKXFwxQ2WCYzis5D8Ngvht1lIfpuF 5LcFjCyrGEVTC5ILipPSi4z0ihNzi0vz0vWS83M3MQLj9fS/Z307GG8esD7EKMDBqMTDO+Ho ulAh1sSy4srcQ4ymQAdNZJYSTc4HJoW8knhDYzMjC1MTU2Mjc0szJXHeBKmfwUIC6Yklqdmp qQWpRfFFpTmpxYcYmTg4pRoYJx35embr8181IhrqC82/Jz1kvmzlJbfrvfOy/T0luaclUnZK l9jKNlTkmYeFf9G/d1zF6HPnwY5FNsIcv898aM54nCj1ZWlFqgL7Av34S+FSN8857609/GaZ 7rPmhv1tr3ucm56J/7d5mdp9Tm/t4+qLR+qv5m17L1BuaRdkwLUtes4PkypGJZbijERDLeai 4kQAg6Qk2dICAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrPIsWRmVeSWpSXmKPExsVy+t9jQd3K8PWhBvtPc1lc+fqezWLS/Qks Fq9fGFr0P37NbHG26Q27xeVdc9gsZpzfx2Sx9shddosZk1+yOXB6bFrVyeZxv/s4k0ffllWM Hp83yQWwRDUw2mSkJqakFimk5iXnp2TmpdsqeQfHO8ebmhkY6hpaWpgrKeQl5qbaKrn4BOi6 ZeYA3aKkUJaYUwoUCkgsLlbSt8M0ITTETdcCpjFC1zckCK7HyAANJKxhzDi9/zdjwWylionP +1kaGH9LdDFyckgImEjc+9PIBmGLSVy4tx7I5uIQEpjOKPH1yAl2kASvgKDEj8n3WLoYOTiY BeQljlzKhjDVJaZMyYUof8Ao0fyijw2iXENix6vZYOUsAqoS1w75gYTZBPQk7mw7zgRiiwqE SZyZ0cECYosI1En0HvnBDDKHWeA+o0Rj0wxmkISwQLnE3e1/mCEWXGKUOLL/AdgCTgFticn/ D7JPYBSYheS8WQjnzUI4bwEj8ypG0dSC5ILipPRcQ73ixNzi0rx0veT83E2M4Mh+JrWDcWWD xSFGAQ5GJR7eCUfXhQqxJpYVV+YeYpTgYFYS4VXmXh8qxJuSWFmVWpQfX1Sak1p8iNEU6LmJ zFKiyfnApJNXEm9obGJmZGlkbmhhZGyuJM57Mt8nVEggPbEkNTs1tSC1CKaPiYNTqoHR7nAv 397zu/T1HXkqX6nZbK04UhM+zVeY/UDjt3ViCqs3WSvdf9WqsU779nIHr1lbtbv/dNT7hl15 cej0oXui4r3Mn77v/RBz8WjQrd0rd9z+f+eG3WOfLOaDeVf3CR7XXfHV8NCMf0J+M2M4y53+ 1Hxwm6y+64DwXB3ub5MmnL66Kn3lUt0XykosxRmJhlrMRcWJAExyZWoCAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/22/2015 05:22 PM, Inki Dae wrote: > On 2015년 07월 22일 17:12, Joonyoung Shim wrote: >> On 07/22/2015 01:55 PM, Inki Dae wrote: >>> On 2015년 07월 22일 11:02, Joonyoung Shim wrote: >>>> On 07/21/2015 10:19 PM, Krzysztof Kozlowski wrote: >>>>> Hi, >>>>> >>>>> Today's linux-next (next-20150721) encounters boot failures on Exynos >>>>> Octa (Exynos5422) based boards. The boards hangs. I bisected it to: >>>>> >>>>> d80167b85024982c5f18d0481a5c248100360118 is the first bad commit >>>>> commit d80167b85024982c5f18d0481a5c248100360118 >>>>> Author: Joonyoung Shim >>>>> Date: Thu Jul 2 21:49:39 2015 +0900 >>>>> >>>>> drm/exynos: remove drm_iommu_attach_device_if_possible >>>>> >>>>> Already drm_iommu_attach_device checks whether support iommu internally. >>>>> It should clear channels always regardless iommu support. We didn't know >>>>> because we can detect the problem when iommu is enabled, so we don't >>>>> have to use drm_iommu_attach_device_if_possible and then we can remove >>>>> drm_iommu_attach_device_if_possible and clear_channels function pointer. >>>>> >>>>> Signed-off-by: Joonyoung Shim >>>>> Tested-by: Marek Szyprowski >>>>> Signed-off-by: Inki Dae >>>>> >>>>> :040000 040000 83379efbf4960f58d680371628ec04387935bd53 >>>>> da03c338b88e7cb6bda895b3dd52d78d9b6eba30 M drivers >>>>> >>>>> >>>>> Config: exynos >>>>> Boot log from Odroid XU3-Lite attached. >>>>> >>>>> Any hints or ideas? >>>> >>>> The point that hangs is when accesses fimd register in >>>> fimd_clear_channels function, so i doubt clock setting for fimd. >>>> >>>> It's gone something that hangs after i enable gating for ACLK_200_DISP1 >>>> clock. >>>> >>>> If ACLK_200_DISP1 clock needs for fimd really, i'm thinking how can it >>>> support. Any ideas? >>> >>> I think bootloader should have enabled ACLK_200_DISP1 clock and also >>> device driver should enable all relevant clocks before the device >>> accesses its own registers. >>> >>> Best way would be that the clock is enabled by common clock framework >>> but it seems there is no anything that the clock framework can do it. So >>> I think what we have to do is to add the clock support to device tree. >> >> It's not easy problem to me. Should we add which clock? I think we >> cannot control ACLK_200_DISP1 or CLKDIV2_DISP1_BLK directly by below >> hierarchy, right? Then we should control gate clocks, but we have not >> controlled any gate clocks using BTS_ prefix. >> >> The clock hierarchy from Exynos5422 user manual, >> ACLK_200_DISP1 -- CLKDIV2_DISP1_BLK -- HDMI LINK >> HDMI PHY >> MIC1 >> DSIM1 >> DPTX LINK >> MDNIE1 >> SYSMMU_MIXER >> SYSMMU_FIMD1_M0 >> SYSMMU_FIMD1_M1 >> BTS_TVM0 >> BTS_TVM1 >> BTS_FIMD1_M0 >> BTS_FIMD1_M1 >> >> Other way, IMHO, fimd driver doesn't have to enable ACLK_200_DISP1 clock, >> just it should be controlled by connector drivers, e.g. dsi, dp because >> fimd only cannot operate, so dsi or dp must need (Actually i'm not sure >> about this, just i thought that Exynos5 SoCs don't have any gpios for >> dpi, so they cannot use dpi, right?). >> >> It needs to probe connector driver like dsi or dp earlier than fimd and >> fimd_bind function should return error if connector driver like dsi or >> dp was not probed. This is also not easy to me. > > In this case, if one of above gate clocks is enabled, the ACLK_200_DISP1 > should be enabled. So I guess the problem would be due to below line of > clk-exynos5420.c, > > GATE(CLK_FIMD1, "fimd1", "aclk300_disp1", GATE_IP_DISP1, 0, 0, 0), > > Can you check it again after modifying it like below?, > GATE(CLK_FIMD1, "fimd1", "aclk200_disp1", GATE_IP_DISP1, 0, 0, 0), No, parent clock of fimd1 gate clock is ACLK_300_DISP1.