From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH for-4.6 1/3] xen/x86/libxl: replace non-POSIX error codes used by PSR code
Date: Wed, 22 Jul 2015 11:51:23 +0200 [thread overview]
Message-ID: <55AF679B.5010401@citrix.com> (raw)
In-Reply-To: <55AE8B6D0200007800093BD1@prv-mh.provo.novell.com>
El 21/07/15 a les 18.11, Jan Beulich ha escrit:
>>>> On 21.07.15 at 17:56, <roger.pau@citrix.com> wrote:
>> PSR was using EBADSLT and EUSERS which are not POSIX error codes, replace
>> them with EINVAL and EOVERFLOW respectively.
>
> Considering that we use EINVAL for almost everything (well beyond
> parameter checking I'm afraid), I don't think using this value for
> something intended to yield a specific user mode error message is
> really a good choice. Looking at the two respective hypervisor side
> changes - how about e.g. using EDOM, EBADF, or ENXIO instead?
As suggested in a later email, replacing EBADSLT with ENOTSOCK seems
better here.
Roger.
next prev parent reply other threads:[~2015-07-22 9:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 15:56 [PATCH for-4.6 0/3] Get rid of non-POSIX error codes Roger Pau Monne
2015-07-21 15:56 ` [PATCH for-4.6 1/3] xen/x86/libxl: replace non-POSIX error codes used by PSR code Roger Pau Monne
2015-07-21 16:11 ` Jan Beulich
2015-07-21 16:17 ` Ian Jackson
2015-07-22 9:51 ` Roger Pau Monné [this message]
2015-07-21 15:56 ` [PATCH for-4.6 2/3] xen: replace non-POSIX error codes Roger Pau Monne
2015-07-21 16:15 ` Jan Beulich
2015-07-22 9:43 ` George Dunlap
2015-07-22 9:45 ` George Dunlap
2015-07-21 15:56 ` [PATCH for-4.6 3/3] xen: remove " Roger Pau Monne
2015-07-21 16:19 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AF679B.5010401@citrix.com \
--to=roger.pau@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.