All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>
Cc: Yang Hongyang <yanghy@cn.fujitsu.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Wen Congyang <wency@cn.fujitsu.com>,
	Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH for 4.6 0/6] Prune legacy migration and move migration v2 out of daft status
Date: Wed, 22 Jul 2015 12:26:19 +0100	[thread overview]
Message-ID: <55AF7DDB.3060601@citrix.com> (raw)
In-Reply-To: <20150722112242.GA6831@zion.uk.xensource.com>

On 22/07/15 12:22, Wei Liu wrote:
> On Wed, Jul 22, 2015 at 11:33:06AM +0100, Ian Campbell wrote:
>> On Mon, 2015-07-20 at 11:37 +0100, Andrew Cooper wrote:
>>> This series is some cleanup following the integration of migration v2
>>> into the codebase.  It removes the legacy migration implementation
>>> (compatability is provided with the python conversion script), and
>>> adjusts the migration v2 docs/implementation to no longer be
>>> experimental.
>> IMHO we should take this for 4.6, there is no point in shipping
>> obsolete/unused code and leaving it there with the xc_domain_save name
>> and the supported thing with a 2 suffix will only tempt people to
>> continue to use or build on it.
>>
>> The only real risk here is breaking the build, since if it builds it
>> will surely work.
>>
>> Wei, final call is yours.
>>
> Yes. I agree with you. But please do check this doesn't conflict with
> COLOPre before applying.
>
> Wei.

There are no conflicts I am aware of, having rebased this series myself.

I will however put together a v2 series, covering the two comments from
review here.

~Andrew

  reply	other threads:[~2015-07-22 11:26 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-20 10:37 [PATCH for 4.6 0/6] Prune legacy migration and move migration v2 out of daft status Andrew Cooper
2015-07-20 10:37 ` [PATCH 1/6] tools/libxc: Remove legacy migration implementation Andrew Cooper
2015-07-22 10:25   ` Ian Campbell
2015-07-22 11:05     ` Andrew Cooper
2015-07-20 10:37 ` [PATCH 2/6] tools/libx{l, c}: Remove the toolstack_{save, restore} callbacks Andrew Cooper
2015-07-22 10:27   ` Ian Campbell
2015-07-22 11:07     ` Andrew Cooper
2015-07-22 11:14       ` Ian Campbell
2015-07-28 10:09         ` Ian Campbell
2015-07-20 10:37 ` [PATCH 3/6] tools/libx{l, c}: Remove XC_DEVICE_MODEL_RESTORE_FILE Andrew Cooper
2015-07-22 10:28   ` Ian Campbell
2015-07-20 10:37 ` [PATCH 4/6] tools/libx{l, c}: Drop '2' suffixes from xc_domain_{save, restore}2() functions Andrew Cooper
2015-07-22 10:29   ` Ian Campbell
2015-07-20 10:37 ` [PATCH 5/6] docs: Migration v2 is now no longer draft Andrew Cooper
2015-07-22 10:29   ` Ian Campbell
2015-07-20 10:37 ` [PATCH 6/6] tools/libx{l, c}: Fix trivial Coverity defects in migration v2 code Andrew Cooper
2015-07-22 10:31   ` Ian Campbell
2015-07-22 10:33 ` [PATCH for 4.6 0/6] Prune legacy migration and move migration v2 out of daft status Ian Campbell
2015-07-22 11:22   ` Wei Liu
2015-07-22 11:26     ` Andrew Cooper [this message]
2015-07-22 11:30       ` Wei Liu
2015-07-22 11:57         ` Andrew Cooper
2015-07-22 12:20           ` Wei Liu
2015-07-22 12:47             ` Yang Hongyang
2015-07-28 10:42             ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55AF7DDB.3060601@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=wency@cn.fujitsu.com \
    --cc=xen-devel@lists.xen.org \
    --cc=yanghy@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.